[bitbake-devel] Git Fetcher Branch Default


Konrad Weihmann
 



On 12 May 2021 14:51, Chuck Wolber <chuckwolber@...> wrote:

I got a fetcher failure on go-systemd today, which puzzled me. That
recipe has not changed in ages, and the SRCPV hash is clearly visible
in the repository.

After looking at it closer, it seems that github.com/coreos/go-systemd
has changed its default branch from master to main about six days ago.
This appears to break a fundamental assumption on the part of the
fetcher when looking for SRCREV and SRCPV hashes.

Looking at lib/bb/fetch2/git.py makes it evident that this is the
case. I can trivially fix this with a .bbappend, but it seems to me
that the fundamental default branch assumption needs to be updated.

Iirc there has been the same discussion already last year or the year before... and the agreement was to leave it as it is. IMHO most of the used projects still go with master instead of main, so a patch of yours would create a lot of work for the majority of the recipes.
And as there is the branch attribute for the git fetcher already available (and widely used for especially these cases) I personally don't see the need for such a patch, unless it provides full backward compatibility



Has anyone discussed adding main to the list of default branches to
try? If not, I may be able to come up with a patch, but the code does
process default branches as a list, so I will need to think a bit on
the best way to approach this. Any guidance would be appreciated.

..Ch:W..


--
"Perfection must be reached by degrees; she requires the slow hand of
time." - Voltaire