CONFIDENTIALITY: The contents of this e-mail are confidential and intended only for the above addressee(s). If you are not the intended recipient, or the person responsible for delivering it to the intended recipient, copying or delivering it to anyone else or using it in any unauthorized manner is prohibited and may be unlawful. If you receive this e-mail by mistake, please notify the sender and the systems administrator at straymail@... immediately.

"TTTech - Internal"

It's hard to say anything without seeing the recipe and the patches.
Can you publish them somewhere?

Alex

I think that I am not allowed to publish the code, but I can try to explain what I have done.
1. There were in total 8 patches before I started to work
2. Run: devtool modify linux-ttc
3. I applied changes to one header file (added 2 lines at the end of the file) and run git add . and git commit -m “some message”
4. Run devtool finish linux-ttc ../repo/meta-fusion-bsp
5. Command passes and it added my new patch file and updated .bb file, but old patches are deleted and removed from .bb file

Same behaviour is when I used devtool update-recipe linux-ttc

Best regards,
Vanja

On Tue, 2022-04-12 at 04:19 -0700, Vanja Žerić wrote:

I think that I am not allowed to publish the code, but I can try to explain
what I have done.
1. There were in total 8 patches before I started to work
2. Run: devtool modify linux-ttc
3. I applied changes to one header file (added 2 lines at the end of the file)
and run git add . and git commit -m “some message”
4. Run devtool finish linux-ttc ../repo/meta-fusion-bsp
5. Command passes and it added my new patch file and updated .bb file, but old
patches are deleted and removed from .bb file

Same behaviour is when I used devtool update-recipe linux-ttc

Can you reproduce this against something in OE-Core which has a similar set of
patches?

We really need to be able to reproduce the problem.

Cheers,

Richard

Hello,

On 12/04/2022 12:22:06+0100, Richard Purdie wrote:

On Tue, 2022-04-12 at 04:19 -0700, Vanja Žerić wrote:

I think that I am not allowed to publish the code, but I can try to explain
what I have done.
1. There were in total 8 patches before I started to work
2. Run: devtool modify linux-ttc
3. I applied changes to one header file (added 2 lines at the end of the file)
and run git add . and git commit -m “some message”
4. Run devtool finish linux-ttc ../repo/meta-fusion-bsp
5. Command passes and it added my new patch file and updated .bb file, but old
patches are deleted and removed from .bb file

Same behaviour is when I used devtool update-recipe linux-ttc

Can you reproduce this against something in OE-Core which has a similar set of
patches?

We really need to be able to reproduce the problem.

I've already noticed this behaviour on dunfell and I have a reproducer:

ninvaders.inc:

---
DESCRIPTION = "Space invaders clone based on nCurses"
HOMEPAGE = "http://ninvaders.sourceforge.net/"
LICENSE = "GPLv2"

SRC_URI = "${SOURCEFORGE_MIRROR}/ninvaders/${BPN}-${PV}.tar.gz"

LICENSE = "GPLv2"
LIC_FILES_CHKSUM = "file://gpl.txt;md5=393a5ca445f6965873eca0259a17f833"

DEPENDS = "ncurses"

EXTRA_OEMAKE = "-e"

do_install() {
install -d ${D}/${bindir}
install -m 755 nInvaders ${D}/${bindir}/ninvaders
}
---

ninvaders_0.1.1.bb:

---
require ninvaders.inc

SRC_URI += "file://joystick-support.patch"

SRC_URI[md5sum] = "97b2c3fb082241ab5c56ab728522622b"
SRC_URI[sha256sum] = "bfbc5c378704d9cf5e7fed288dac88859149bee5ed0850175759d310b61fd30b"
---

after devtool modify/devtool update-recipe, we get:

---
require ninvaders.inc

SRC_URI += " file://0001-fix.patch"

SRC_URI[md5sum] = "97b2c3fb082241ab5c56ab728522622b"
SRC_URI[sha256sum] = "bfbc5c378704d9cf5e7fed288dac88859149bee5ed0850175759d310b61fd30b"
---



--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com