[error-report-web][PATCH] report-error.bbclass: Add layer and bitbake version info to error report


Milan Shah
 

Instead of just providing local.conf info, add layer names and their
revisions with bitbake version information into error report
makes it easier to understand and reproduce failed build.

[YOCTO #9700]

Signed-off-by: Milan Shah <mshah@mvista.com>
---
meta/classes/report-error.bbclass | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/meta/classes/report-error.bbclass b/meta/classes/report-error.bbclass
index 1a12db1..9cb6b0b 100644
--- a/meta/classes/report-error.bbclass
+++ b/meta/classes/report-error.bbclass
@@ -6,6 +6,8 @@
#
# Licensed under the MIT license, see COPYING.MIT for details

+inherit base
+
ERR_REPORT_DIR ?= "${LOG_DIR}/error-report"

def errorreport_getdata(e):
@@ -64,6 +66,8 @@ python errorreport_handler () {
data['failures'] = []
data['component'] = " ".join(e.getPkgs())
data['branch_commit'] = str(base_detect_branch(e.data)) + ": " + str(base_detect_revision(e.data))
+ data['bitbake_version'] = e.data.getVar("BB_VERSION")
+ data['layer_version'] = get_layers_branch_rev(e.data)
data['local_conf'] = get_conf_data(e, 'local.conf')
data['auto_conf'] = get_conf_data(e, 'auto.conf')
lock = bb.utils.lockfile(datafile + '.lock')
--
2.7.4


Milan Shah
 

Hi All,

This is a Gentle Reminder to review this Patch.

-----------------------
Thanks & Regards,
Milan Shah
MontaVista Software, Bangalore, India


On Wed, Jan 6, 2021 at 7:09 PM Milan Shah <mshah@...> wrote:
Instead of just providing local.conf info, add layer names and their
revisions with bitbake version information into error report
makes it easier to understand and reproduce failed build.

[YOCTO #9700]

Signed-off-by: Milan Shah <mshah@...>
---
 meta/classes/report-error.bbclass | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/meta/classes/report-error.bbclass b/meta/classes/report-error.bbclass
index 1a12db1..9cb6b0b 100644
--- a/meta/classes/report-error.bbclass
+++ b/meta/classes/report-error.bbclass
@@ -6,6 +6,8 @@
 #
 # Licensed under the MIT license, see COPYING.MIT for details

+inherit base
+
 ERR_REPORT_DIR ?= "${LOG_DIR}/error-report"

 def errorreport_getdata(e):
@@ -64,6 +66,8 @@ python errorreport_handler () {
             data['failures'] = []
             data['component'] = " ".join(e.getPkgs())
             data['branch_commit'] = str(base_detect_branch(e.data)) + ": " + str(base_detect_revision(e.data))
+            data['bitbake_version'] = e.data.getVar("BB_VERSION")
+            data['layer_version'] = get_layers_branch_rev(e.data)
             data['local_conf'] = get_conf_data(e, 'local.conf')
             data['auto_conf'] = get_conf_data(e, 'auto.conf')
             lock = bb.utils.lockfile(datafile + '.lock')
--
2.7.4


Milan Shah
 

Hi All,

A gentle reminder to review this patch.

-----------------------
Thanks & Regards,
Milan Shah
MontaVista Software, Bangalore, India


On Mon, Jan 11, 2021 at 6:45 PM Milan Shah <mshah@...> wrote:
Hi All,

This is a Gentle Reminder to review this Patch.

-----------------------
Thanks & Regards,
Milan Shah
MontaVista Software, Bangalore, India


On Wed, Jan 6, 2021 at 7:09 PM Milan Shah <mshah@...> wrote:
Instead of just providing local.conf info, add layer names and their
revisions with bitbake version information into error report
makes it easier to understand and reproduce failed build.

[YOCTO #9700]

Signed-off-by: Milan Shah <mshah@...>
---
 meta/classes/report-error.bbclass | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/meta/classes/report-error.bbclass b/meta/classes/report-error.bbclass
index 1a12db1..9cb6b0b 100644
--- a/meta/classes/report-error.bbclass
+++ b/meta/classes/report-error.bbclass
@@ -6,6 +6,8 @@
 #
 # Licensed under the MIT license, see COPYING.MIT for details

+inherit base
+
 ERR_REPORT_DIR ?= "${LOG_DIR}/error-report"

 def errorreport_getdata(e):
@@ -64,6 +66,8 @@ python errorreport_handler () {
             data['failures'] = []
             data['component'] = " ".join(e.getPkgs())
             data['branch_commit'] = str(base_detect_branch(e.data)) + ": " + str(base_detect_revision(e.data))
+            data['bitbake_version'] = e.data.getVar("BB_VERSION")
+            data['layer_version'] = get_layers_branch_rev(e.data)
             data['local_conf'] = get_conf_data(e, 'local.conf')
             data['auto_conf'] = get_conf_data(e, 'auto.conf')
             lock = bb.utils.lockfile(datafile + '.lock')
--
2.7.4


Milan Shah
 

Hi All,

This has not been reviewed yet and it is given since January 6th.
Please review it and provide review comments if any as soon as possible to resolve this issue.

Thanks & Regards,
Milan Shah

Milan Shah | Software Engineer
a: MontaVista Software, LLC | Bangalore, India
e: info@... | w: www.mvista.com/
p: +91-80-4939-5000


On Mon, Feb 1, 2021 at 10:06 AM Milan Shah <mshah@...> wrote:
Hi All,

A gentle reminder to review this patch.

-----------------------
Thanks & Regards,
Milan Shah
MontaVista Software, Bangalore, India


On Mon, Jan 11, 2021 at 6:45 PM Milan Shah <mshah@...> wrote:
Hi All,

This is a Gentle Reminder to review this Patch.

-----------------------
Thanks & Regards,
Milan Shah
MontaVista Software, Bangalore, India


On Wed, Jan 6, 2021 at 7:09 PM Milan Shah <mshah@...> wrote:
Instead of just providing local.conf info, add layer names and their
revisions with bitbake version information into error report
makes it easier to understand and reproduce failed build.

[YOCTO #9700]

Signed-off-by: Milan Shah <mshah@...>
---
 meta/classes/report-error.bbclass | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/meta/classes/report-error.bbclass b/meta/classes/report-error.bbclass
index 1a12db1..9cb6b0b 100644
--- a/meta/classes/report-error.bbclass
+++ b/meta/classes/report-error.bbclass
@@ -6,6 +6,8 @@
 #
 # Licensed under the MIT license, see COPYING.MIT for details

+inherit base
+
 ERR_REPORT_DIR ?= "${LOG_DIR}/error-report"

 def errorreport_getdata(e):
@@ -64,6 +66,8 @@ python errorreport_handler () {
             data['failures'] = []
             data['component'] = " ".join(e.getPkgs())
             data['branch_commit'] = str(base_detect_branch(e.data)) + ": " + str(base_detect_revision(e.data))
+            data['bitbake_version'] = e.data.getVar("BB_VERSION")
+            data['layer_version'] = get_layers_branch_rev(e.data)
             data['local_conf'] = get_conf_data(e, 'local.conf')
             data['auto_conf'] = get_conf_data(e, 'auto.conf')
             lock = bb.utils.lockfile(datafile + '.lock')
--
2.7.4


Milan Shah
 

Hi,

Review reminder for [YOCTO #9700].


Thanks & Regards,
Milan Shah

Milan Shah | Software Engineer
a: MontaVista Software, LLC | Bangalore, India
e: info@... | w: www.mvista.com/
p: +91-80-4939-5000


On Tue, Feb 23, 2021 at 3:21 PM Milan Shah <mshah@...> wrote:
Hi All,

This has not been reviewed yet and it is given since January 6th.
Please review it and provide review comments if any as soon as possible to resolve this issue.

Thanks & Regards,
Milan Shah

Milan Shah | Software Engineer
a: MontaVista Software, LLC | Bangalore, India
e: info@... | w: www.mvista.com/
p: +91-80-4939-5000


On Mon, Feb 1, 2021 at 10:06 AM Milan Shah <mshah@...> wrote:
Hi All,

A gentle reminder to review this patch.

-----------------------
Thanks & Regards,
Milan Shah
MontaVista Software, Bangalore, India


On Mon, Jan 11, 2021 at 6:45 PM Milan Shah <mshah@...> wrote:
Hi All,

This is a Gentle Reminder to review this Patch.

-----------------------
Thanks & Regards,
Milan Shah
MontaVista Software, Bangalore, India


On Wed, Jan 6, 2021 at 7:09 PM Milan Shah <mshah@...> wrote:
Instead of just providing local.conf info, add layer names and their
revisions with bitbake version information into error report
makes it easier to understand and reproduce failed build.

[YOCTO #9700]

Signed-off-by: Milan Shah <mshah@...>
---
 meta/classes/report-error.bbclass | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/meta/classes/report-error.bbclass b/meta/classes/report-error.bbclass
index 1a12db1..9cb6b0b 100644
--- a/meta/classes/report-error.bbclass
+++ b/meta/classes/report-error.bbclass
@@ -6,6 +6,8 @@
 #
 # Licensed under the MIT license, see COPYING.MIT for details

+inherit base
+
 ERR_REPORT_DIR ?= "${LOG_DIR}/error-report"

 def errorreport_getdata(e):
@@ -64,6 +66,8 @@ python errorreport_handler () {
             data['failures'] = []
             data['component'] = " ".join(e.getPkgs())
             data['branch_commit'] = str(base_detect_branch(e.data)) + ": " + str(base_detect_revision(e.data))
+            data['bitbake_version'] = e.data.getVar("BB_VERSION")
+            data['layer_version'] = get_layers_branch_rev(e.data)
             data['local_conf'] = get_conf_data(e, 'local.conf')
             data['auto_conf'] = get_conf_data(e, 'auto.conf')
             lock = bb.utils.lockfile(datafile + '.lock')
--
2.7.4


Milan Shah
 

Hi Richard,

It seems like patches sent for error-report-web are not much important to the community as this patch has not been reviewed/commented on by anyone since 6th January 2021 (more than 2.5 months).

Still, I'm sending a reminder one last time for [YOCTO #9700].

Please review/comment on it so that things can move further.

Thanks & Regards,
Milan Shah

Milan Shah | Software Engineer
a: MontaVista Software, LLC | Bangalore, India
e: info@... | w: www.mvista.com/
p: +91-80-4939-5000


On Mon, Mar 15, 2021 at 4:36 PM Milan Shah <mshah@...> wrote:
Hi,

Review reminder for [YOCTO #9700].


Thanks & Regards,
Milan Shah

Milan Shah | Software Engineer
a: MontaVista Software, LLC | Bangalore, India
e: info@... | w: www.mvista.com/
p: +91-80-4939-5000


On Tue, Feb 23, 2021 at 3:21 PM Milan Shah <mshah@...> wrote:
Hi All,

This has not been reviewed yet and it is given since January 6th.
Please review it and provide review comments if any as soon as possible to resolve this issue.

Thanks & Regards,
Milan Shah

Milan Shah | Software Engineer
a: MontaVista Software, LLC | Bangalore, India
e: info@... | w: www.mvista.com/
p: +91-80-4939-5000


On Mon, Feb 1, 2021 at 10:06 AM Milan Shah <mshah@...> wrote:
Hi All,

A gentle reminder to review this patch.

-----------------------
Thanks & Regards,
Milan Shah
MontaVista Software, Bangalore, India


On Mon, Jan 11, 2021 at 6:45 PM Milan Shah <mshah@...> wrote:
Hi All,

This is a Gentle Reminder to review this Patch.

-----------------------
Thanks & Regards,
Milan Shah
MontaVista Software, Bangalore, India


On Wed, Jan 6, 2021 at 7:09 PM Milan Shah <mshah@...> wrote:
Instead of just providing local.conf info, add layer names and their
revisions with bitbake version information into error report
makes it easier to understand and reproduce failed build.

[YOCTO #9700]

Signed-off-by: Milan Shah <mshah@...>
---
 meta/classes/report-error.bbclass | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/meta/classes/report-error.bbclass b/meta/classes/report-error.bbclass
index 1a12db1..9cb6b0b 100644
--- a/meta/classes/report-error.bbclass
+++ b/meta/classes/report-error.bbclass
@@ -6,6 +6,8 @@
 #
 # Licensed under the MIT license, see COPYING.MIT for details

+inherit base
+
 ERR_REPORT_DIR ?= "${LOG_DIR}/error-report"

 def errorreport_getdata(e):
@@ -64,6 +66,8 @@ python errorreport_handler () {
             data['failures'] = []
             data['component'] = " ".join(e.getPkgs())
             data['branch_commit'] = str(base_detect_branch(e.data)) + ": " + str(base_detect_revision(e.data))
+            data['bitbake_version'] = e.data.getVar("BB_VERSION")
+            data['layer_version'] = get_layers_branch_rev(e.data)
             data['local_conf'] = get_conf_data(e, 'local.conf')
             data['auto_conf'] = get_conf_data(e, 'auto.conf')
             lock = bb.utils.lockfile(datafile + '.lock')
--
2.7.4


Richard Purdie
 

On Fri, 2021-03-26 at 16:04 +0530, Milan Shah wrote:
It seems like patches sent for error-report-web are not much important to the community as this patch has
not been reviewed/commented on by anyone since 6th January 2021 (more than 2.5 months).

Still, I'm sending a reminder one last time for [YOCTO #9700].
https://lists.yoctoproject.org/g/yocto/message/51891

Please review/comment on it so that things can move further.
Sorry, that isn't true, they are important and appreciated. We're 
just struggling to handle everything.

The challenge/problem has been that there are much older patches which
were half merged and broke things. People have rightly been complaining
about those issues and Khem for example has been carrying a patch for 3
years to work arond that problem. I did figure out a fix for that which
has now been merged.

We also needed to migrate the service from py2 to py3 and deal with a
set of patches that had been applied locally that we had been unaware of
until very recently but which complicate things. The people who wrote 
them are no longer around to help with that.

The original authors of this code are no longer around, the people who
stepped up to try and help also haven't had time so the support/review
has struggled. The service is in daily use however so it is important
and that is why I'm now trying to unravel and fix things.

I do want to get to your patch but you can appreciate that adding it
directly on top of an already failing set of changes wouldn't be good
for anyone.

We are making progress in resolving the issues so I hope to get some
kind of better answer to you soon.

Cheers,

Richard


Milan Shah
 

Thanks, Richard for responding.

I completely understood your point and appreciate the effort you people make to maintain these repositories.

But as a contributor, It encourages me to contribute more when my work gets noticed/criticized/accepted by the community.

Anyways, I hope that the community resolves these issues as soon as possible so that there won't be much delay in updating the patches sent by the contributors.

Thanks & Regards,
Milan Shah

Milan Shah | Software Engineer
a: MontaVista Software, LLC | Bangalore, India
e: info@... | w: www.mvista.com/
p: +91-80-4939-5000


On Fri, Mar 26, 2021 at 4:21 PM Richard Purdie <richard.purdie@...> wrote:
On Fri, 2021-03-26 at 16:04 +0530, Milan Shah wrote:
> It seems like patches sent for error-report-web are not much important to the community as this patch has
> not been reviewed/commented on by anyone since 6th January 2021 (more than 2.5 months).
>
> Still, I'm sending a reminder one last time for [YOCTO #9700].
> https://lists.yoctoproject.org/g/yocto/message/51891
>
> Please review/comment on it so that things can move further.

Sorry, that isn't true, they are important and appreciated. We're 
just struggling to handle everything.

The challenge/problem has been that there are much older patches which
were half merged and broke things. People have rightly been complaining
about those issues and Khem for example has been carrying a patch for 3
years to work arond that problem. I did figure out a fix for that which
has now been merged.

We also needed to migrate the service from py2 to py3 and deal with a
set of patches that had been applied locally that we had been unaware of
until very recently but which complicate things. The people who wrote 
them are no longer around to help with that.

The original authors of this code are no longer around, the people who
stepped up to try and help also haven't had time so the support/review
has struggled. The service is in daily use however so it is important
and that is why I'm now trying to unravel and fix things.

I do want to get to your patch but you can appreciate that adding it
directly on top of an already failing set of changes wouldn't be good
for anyone.

We are making progress in resolving the issues so I hope to get some
kind of better answer to you soon.

Cheers,

Richard



Milan Shah
 

Hello All,

My Patch has not been reviewed for the past 7 months. Looking forward to see some updates on this.

Please find related links below.

Thanks & Regards,
Milan Shah

Milan Shah | Software Engineer
a: MontaVista Software, LLC | Bangalore, India
e: info@... | w: www.mvista.com/
p: +91-80-4939-5000


On Fri, Mar 26, 2021 at 5:16 PM Milan Shah via lists.yoctoproject.org <mshah=mvista.com@...> wrote:
Thanks, Richard for responding.

I completely understood your point and appreciate the effort you people make to maintain these repositories.

But as a contributor, It encourages me to contribute more when my work gets noticed/criticized/accepted by the community.

Anyways, I hope that the community resolves these issues as soon as possible so that there won't be much delay in updating the patches sent by the contributors.

Thanks & Regards,
Milan Shah

Milan Shah | Software Engineer
a: MontaVista Software, LLC | Bangalore, India
e: info@... | w: www.mvista.com/
p: +91-80-4939-5000


On Fri, Mar 26, 2021 at 4:21 PM Richard Purdie <richard.purdie@...> wrote:
On Fri, 2021-03-26 at 16:04 +0530, Milan Shah wrote:
> It seems like patches sent for error-report-web are not much important to the community as this patch has
> not been reviewed/commented on by anyone since 6th January 2021 (more than 2.5 months).
>
> Still, I'm sending a reminder one last time for [YOCTO #9700].
> https://lists.yoctoproject.org/g/yocto/message/51891
>
> Please review/comment on it so that things can move further.

Sorry, that isn't true, they are important and appreciated. We're 
just struggling to handle everything.

The challenge/problem has been that there are much older patches which
were half merged and broke things. People have rightly been complaining
about those issues and Khem for example has been carrying a patch for 3
years to work arond that problem. I did figure out a fix for that which
has now been merged.

We also needed to migrate the service from py2 to py3 and deal with a
set of patches that had been applied locally that we had been unaware of
until very recently but which complicate things. The people who wrote 
them are no longer around to help with that.

The original authors of this code are no longer around, the people who
stepped up to try and help also haven't had time so the support/review
has struggled. The service is in daily use however so it is important
and that is why I'm now trying to unravel and fix things.

I do want to get to your patch but you can appreciate that adding it
directly on top of an already failing set of changes wouldn't be good
for anyone.

We are making progress in resolving the issues so I hope to get some
kind of better answer to you soon.

Cheers,

Richard






Richard Purdie
 

On Fri, 2021-07-09 at 10:51 +0530, Milan Shah wrote:
Hello All,

My Patch has not been reviewed for the past 7 months. Looking forward 
to see some updates on this.

Please find related links below.
https://lists.yoctoproject.org/g/yocto/message/51891
https://bugzilla.yoctoproject.org/show_bug.cgi?id=9700
http://git.yoctoproject.org/cgit.cgi/poky/commit/meta/classes/report-error.bbclass?id=8b299a62c55aa8d1583aff4b8428f16def7231b7

It appears to have merged 5 months ago?

Also, looking at the patch that inherit base should not be there and needs
to be removed since everything always inherits base.

In the future please send OE-Core changes to the openembedded-core mailing
list as that will speed up review and patch handling (as per the repo's README).

Cheers,

Richard


Milan Shah
 

Well, there was no update on the bug as well as on the patch so I was not aware of it.

Thanks, Richard for responding. I'll definitely follow your suggestion next time.

Thanks & Regards,
Milan Shah

Milan Shah | Software Engineer
a: MontaVista Software, LLC | Bangalore, India
e: info@... | w: www.mvista.com/
p: +91-80-4939-5000


On Fri, Jul 9, 2021 at 2:03 PM Richard Purdie <richard.purdie@...> wrote:
On Fri, 2021-07-09 at 10:51 +0530, Milan Shah wrote:
> Hello All,
>
> My Patch has not been reviewed for the past 7 months. Looking forward 
> to see some updates on this.
>
> Please find related links below.
> https://lists.yoctoproject.org/g/yocto/message/51891
> https://bugzilla.yoctoproject.org/show_bug.cgi?id=9700
>

http://git.yoctoproject.org/cgit.cgi/poky/commit/meta/classes/report-error.bbclass?id=8b299a62c55aa8d1583aff4b8428f16def7231b7

It appears to have merged 5 months ago?

Also, looking at the patch that inherit base should not be there and needs
to be removed since everything always inherits base.

In the future please send OE-Core changes to the openembedded-core mailing
list as that will speed up review and patch handling (as per the repo's README).

Cheers,

Richard


Richard Purdie
 

On Fri, 2021-07-09 at 14:07 +0530, Milan Shah wrote:
Well, there was no update on the bug as well as on the patch so I was 
not aware of it.

Thanks, Richard for responding. I'll definitely follow your suggestion 
next time.
We'd normally expect the bug owner to update the status of the bug since it
isn't really possible for me or the triage team to track and update them all.
We can close this one with a link to the commit:

http://git.yoctoproject.org/cgit.cgi/poky/commit/meta/classes/report-error.bbclass?id=8b299a62c55aa8d1583aff4b8428f16def7231b7

Happy for you to, or I can...

Cheers,

Richard


Milan Shah
 

Thanks, Richard

Closed the Bug as Resolved Fixed Status and commit link as a Comment.

Thanks & Regards,
Milan Shah

Milan Shah | Software Engineer
a: MontaVista Software, LLC | Bangalore, India
e: info@... | w: www.mvista.com/
p: +91-80-4939-5000


On Fri, Jul 9, 2021 at 2:23 PM Richard Purdie <richard.purdie@...> wrote:
On Fri, 2021-07-09 at 14:07 +0530, Milan Shah wrote:
> Well, there was no update on the bug as well as on the patch so I was 
> not aware of it.
>
> Thanks, Richard for responding. I'll definitely follow your suggestion 
> next time.

We'd normally expect the bug owner to update the status of the bug since it
isn't really possible for me or the triage team to track and update them all.
We can close this one with a link to the commit:

http://git.yoctoproject.org/cgit.cgi/poky/commit/meta/classes/report-error.bbclass?id=8b299a62c55aa8d1583aff4b8428f16def7231b7

Happy for you to, or I can...

Cheers,

Richard