Yoctoproject.org cgit tags CSS


Anders Montonen
 

Hi,

Since some time, the tags in the log view of yoctoproject.org’s cgit have not been highlighted correctly. The problem seems to be that in the HTML, tags are given the class “tag-annotated-deco”, which doesn’t exist in the CSS. The CSS does have a “tag-deco” style which is probably what’s intended.

Regards,
Anders Montonen


Michael Halstead
 

I've copied the style into the new class name. Please let me know if this looks correct to you.


On Mon, Nov 9, 2020 at 12:29 PM Anders Montonen <Anders.Montonen@...> wrote:
Hi,

Since some time, the tags in the log view of yoctoproject.org’s cgit have not been highlighted correctly. The problem seems to be that in the HTML, tags are given the class “tag-annotated-deco”, which doesn’t exist in the CSS. The CSS does have a “tag-deco” style which is probably what’s intended.

Regards,
Anders Montonen




--
Michael Halstead
Linux Foundation / Yocto Project
Systems Operations Engineer


Alexander Kanavin
 

I am not seeing a change - the tags are still not highlighted (e.g. commit on top):

This file still contains only the old name:

Alex


On Tue, 10 Nov 2020 at 08:24, Michael Halstead <mhalstead@...> wrote:
I've copied the style into the new class name. Please let me know if this looks correct to you.

On Mon, Nov 9, 2020 at 12:29 PM Anders Montonen <Anders.Montonen@...> wrote:
Hi,

Since some time, the tags in the log view of yoctoproject.org’s cgit have not been highlighted correctly. The problem seems to be that in the HTML, tags are given the class “tag-annotated-deco”, which doesn’t exist in the CSS. The CSS does have a “tag-deco” style which is probably what’s intended.

Regards,
Anders Montonen




--
Michael Halstead
Linux Foundation / Yocto Project
Systems Operations Engineer




Anders Montonen
 

Hi,

The tags now show as white text on yellow background, which is unreadable. I think you must copy "table.list td a.tag-deco” too, to set the text color.
Btw, this is probably the same as <https://bugzilla.yoctoproject.org/show_bug.cgi?id=13668>.

Regards,
Anders Montonen

On 10 Nov 2020, at 9:24, Michael Halstead <mhalstead@...> wrote:

I've copied the style into the new class name. Please let me know if this looks correct to you.

On Mon, Nov 9, 2020 at 12:29 PM Anders Montonen <Anders.Montonen@...> wrote:
Hi,

Since some time, the tags in the log view of yoctoproject.org’s cgit have not been highlighted correctly. The problem seems to be that in the HTML, tags are given the class “tag-annotated-deco”, which doesn’t exist in the CSS. The CSS does have a “tag-deco” style which is probably what’s intended.

Regards,
Anders Montonen




--
Michael Halstead
Linux Foundation / Yocto Project
Systems Operations Engineer





Anders Montonen
 

Hi,

The previous change also seems to have broken the tag highlighting for the light theme.

Regards,
Anders Montonen

On 10 Nov 2020, at 10:52, Anders Montonen <Anders.Montonen@...> wrote:

Hi,

The tags now show as white text on yellow background, which is unreadable. I think you must copy "table.list td a.tag-deco” too, to set the text color.
Btw, this is probably the same as <https://bugzilla.yoctoproject.org/show_bug.cgi?id=13668>.

Regards,
Anders Montonen

On 10 Nov 2020, at 9:24, Michael Halstead <mhalstead@...> wrote:

I've copied the style into the new class name. Please let me know if this looks correct to you.

On Mon, Nov 9, 2020 at 12:29 PM Anders Montonen <Anders.Montonen@...> wrote:
Hi,

Since some time, the tags in the log view of yoctoproject.org’s cgit have not been highlighted correctly. The problem seems to be that in the HTML, tags are given the class “tag-annotated-deco”, which doesn’t exist in the CSS. The CSS does have a “tag-deco” style which is probably what’s intended.

Regards,
Anders Montonen




-- 
Michael Halstead
Linux Foundation / Yocto Project
Systems Operations Engineer