Date
1 - 4 of 4
[PULL] at: Non root install patch is not necessary (Bug 246)
|
Mei, Lei <lei.mei@...>
meta/recipes-extended/at/at_3.1.12.bb | 1
meta/recipes-extended/at/files/nonrootinstall.patch | 75 -------------------- 2 files changed, 76 deletions(-) Mei Lei (1): at: Non root install patch is not necessary (Bug 246) Pull URL: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=lmei3/distro commit 22a1491482bdd0b8fe1bac3f89a2b4dad0a94a8c Author: Mei Lei <lei.mei@...> Date: Tue Oct 19 14:23:51 2010 +0800 at: Non root install patch is not necessary (Bug 246) Removed nonrootinstall patch and modified the file which used this patch Fix [BUGID #246] Signed-off-by: Mei Lei <lei.mei@...> --- Mei, Lei Email: lei.mei@... |
|
|
|
Richard Purdie <rpurdie@...>
On Tue, 2010-10-19 at 17:07 +0800, Mei, Lei wrote:
meta/recipes-extended/at/at_3.1.12.bb | 1This change illustrates a problem we need to be very careful to watch for when doing this. The patch you've removed not only handles root install but also handles stripping of the binaries. Note this bit: -+ifeq ($(IROOT),) - chown $(DAEMON_USERNAME):$(DAEMON_GROUPNAME) $(IROOT)$(LFILE) -- test -f $(IROOT)$(etcdir)/at.allow || test -f $(IROOT)$(etcdir)/at.deny || $(INSTALL) -o root -g $(DAEMON_GROUPNAME) -m 640 at.deny $(IROOT)$(etcdir)/ -- $(INSTALL) -g $(DAEMON_GROUPNAME) -o $(DAEMON_USERNAME) -m 6755 -s at $(IROOT)$(bindir) -+endif -+ test -f $(IROOT)$(etcdir)/at.allow || test -f $(IROOT)$(etcdir)/at.deny || $(INSTALL) $(INSTALLOWN) -m 600 at.deny $(IROOT)$(etcdir)/ -+ $(INSTALL) $(INSTALLOWN) -m 4755 at $(IROOT)$(bindir) The -s option is removed from the install command. Whilst we can remove the user ownership part of the patch, the -s option needs to remain present as we expect unstripped binaries to be installed. Regards, Richard |
|
|
|
Mei, Lei <lei.mei@...>
Hi Richard,
toggle quoted message
Show quoted text
I have re-fixed this bug, please check it, thank you~ meta/recipes-extended/at/at_3.1.12.bb | 2 meta/recipes-extended/at/files/nonrootinstall.patch | 75 ------------------ meta/recipes-extended/at/files/nonstripbinaries.patch | 21 +++++ 3 files changed, 22 insertions(+), 76 deletions(-) Mei Lei (1): at: remove nonrootinstall patch and modify relevant files Pull URL: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=lmei3/distro commit 4cc54ea87c5167af0da207e5cea856d16e2b88f6 Author: Mei Lei <lei.mei@...> Date: Wed Oct 20 16:20:36 2010 +0800 at: remove nonrootinstall patch and modify relevant files remove nonrootinstall patch, and use a patch named nonstripbinaries to modify the /at-3.1.10.2/Makefile.in, so it can also handles stripping of the binaries. Fix [BUGID #246] Signed-off-by: Mei Lei <lei.mei@...> Thanks Lei -----Original Message-----
From: Richard Purdie [mailto:rpurdie@...] Sent: Tuesday, October 19, 2010 8:03 PM To: Mei, Lei Cc: yocto@... Subject: Re: [yocto] [PULL] at: Non root install patch is not necessary (Bug 246) On Tue, 2010-10-19 at 17:07 +0800, Mei, Lei wrote: meta/recipes-extended/at/at_3.1.12.bb | 1This change illustrates a problem we need to be very careful to watch for when doing this. The patch you've removed not only handles root install but also handles stripping of the binaries. Note this bit: -+ifeq ($(IROOT),) - chown $(DAEMON_USERNAME):$(DAEMON_GROUPNAME) $(IROOT)$(LFILE) -- test -f $(IROOT)$(etcdir)/at.allow || test -f $(IROOT)$(etcdir)/at.deny || $(INSTALL) -o root -g $(DAEMON_GROUPNAME) -m 640 at.deny $(IROOT)$(etcdir)/ -- $(INSTALL) -g $(DAEMON_GROUPNAME) -o $(DAEMON_USERNAME) -m 6755 -s at $(IROOT)$(bindir) -+endif -+ test -f $(IROOT)$(etcdir)/at.allow || test -f $(IROOT)$(etcdir)/at.deny || $(INSTALL) $(INSTALLOWN) -m 600 at.deny $(IROOT)$(etcdir)/ -+ $(INSTALL) $(INSTALLOWN) -m 4755 at $(IROOT)$(bindir) The -s option is removed from the install command. Whilst we can remove the user ownership part of the patch, the -s option needs to remain present as we expect unstripped binaries to be installed. Regards, Richard |
|
|
|
Richard Purdie <rpurdie@...>
On Wed, 2010-10-20 at 17:05 +0800, Mei, Lei wrote:
Hi Richard,Thanks, much better. One more small thing though - could you add a header to the patch with a description of what it does, why and who made the change. In this case its fairly obvious but its a good idea in general as when you come back to a patch six months later you can remember why its there! Also, poky pull requests like this should be going to the Poky mailing list. Cheers, Richard |
|
|