|
Re: [PATCH 1/1] RTC: Ensure msecure is mux'd to be able to set RTC
Koen Kooi
Op 16 jun 2011, om 08:07 heeft Jingdong Lu het volgende geschreven:
From: Jingdong Lu <jingdong.lu@...>When I do 'git show e2a346a2a054f702fd76f328ff747b9ad9264a4' I get: commit e2a346a2a054f702fd76f328ff747b9ad9264a4c Author: Alexander Holler <holler@...> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Date: Tue Apr 5 15:40:08 2011 +0200 arm: omap3: beagle: Ensure msecure is mux'd to be able to set the RTC Without msecure beeing high it isn't possible to set (or start) the RTC. Tested with a BeagleBoard C4. Signed-off-by: Alexander Holler <holler@...> Signed-off-by: Tony Lindgren <tony@...> diff --git a/arch/arm/mach-omap2/board-omap3beagle.c b/arch/arm/mach-omap2/board-omap3beagle.c index be71426..d64ed97 100644 --- a/arch/arm/mach-omap2/board-omap3beagle.c +++ b/arch/arm/mach-omap2/board-omap3beagle.c @@ -579,6 +579,9 @@ static void __init omap3_beagle_init(void) omap_nand_flash_init(NAND_BUSWIDTH_16, omap3beagle_nand_partitions, ARRAY_SIZE(omap3beagle_nand_partitions)); + /* Ensure msecure is mux'd to be able to set the RTC. */ + omap_mux_init_signal("sys_drm_msecure", OMAP_PIN_OFF_OUTPUT_HIGH); + /* Ensure SDRC pins are mux'd for self-refresh */ omap_mux_init_signal("sdrc_cke0", OMAP_PIN_OUTPUT); omap_mux_init_signal("sdrc_cke1", OMAP_PIN_OUTPUT); So if you're going to change the author, you'd also need to remove the SOBs.
|
|
|
|
Re: [PATCH 1/1] RTC: Ensure msecure is mux'd to be able to set RTC
Liming Wang <liming.wang@...>
On 2011-6-16 14:07, Jingdong Lu wrote:
From: Jingdong Lu<jingdong.lu@...>It's fine if you break this line into two lines. arm: omap3: beagle: Ensure msecure is mux'd to be able to set the RTC.I think it's best to put your comment in the top line. Liming Wang Signed-off-by: Alexander Holler<holler@...>
|
|
|
|
[PATCH 1/1] RTC: Ensure msecure is mux'd to be able to set RTC
Jingdong Lu <jingdong.lu@...>
From: Jingdong Lu <jingdong.lu@...>
commit e2a346a2a054f702fd76f328ff747b9ad9264a4c from git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-2.6.git arm: omap3: beagle: Ensure msecure is mux'd to be able to set the RTC. "Msecure" signal provides for protection of the RTC register in TPS65950 be disabling that function via a control signal from the OMAP3530. So ensure msecure is mux'd to be able to set the RTC. Tested with a BeagleBoard C4. Fixes bug [YOCTO #767] Signed-off-by: Alexander Holler <holler@...> Signed-off-by: Tony Lindgren <tony@...> Integrated-by: Jingdong Lu <jingdong.lu@...> --- arch/arm/mach-omap2/board-omap3beagle.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-omap2/board-omap3beagle.c b/arch/arm/mach-omap2/board-omap3beagle.c index af1166b..925c0b3 100644 --- a/arch/arm/mach-omap2/board-omap3beagle.c +++ b/arch/arm/mach-omap2/board-omap3beagle.c @@ -580,6 +580,9 @@ static void __init omap3_beagle_init(void) usb_ehci_init(&ehci_pdata); omap3beagle_flash_init(); + /* Ensure msecure is mux'd to be able to set the RTC. */ + omap_mux_init_signal("sys_drm_msecure", OMAP_PIN_OFF_OUTPUT_HIGH); + /* Ensure SDRC pins are mux'd for self-refresh */ omap_mux_init_signal("sdrc_cke0", OMAP_PIN_OUTPUT); omap_mux_init_signal("sdrc_cke1", OMAP_PIN_OUTPUT); -- 1.7.0.4
|
|
|
|
[PATCH 0/1] RTC: Ensure msecure is mux'd to be able to set RTC for beagleboard
Jingdong Lu <jingdong.lu@...>
From: Jingdong Lu <jingdong.lu@...>
Ensure msecure is mux'd to be able to set the RTC for beagleboard. Fixes bug [YOCTO #767] Jingdong Lu (1): RTC: Ensure msecure is mux'd to be able to set RTC arch/arm/mach-omap2/board-omap3beagle.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)
|
|
|
|
Re: configure optimization feature update
Xu, Dongxiao <dongxiao.xu@...>
toggle quoted messageShow quoted text
-----Original Message-----I diff the source files before and after autoreconf and using the generated patch as our autoreconf cache. For a certain source code, for example connman, such diff file will be as large as 3M, and for a sato build, we have about 300 recipes need autoreconf. Thanks, Dongxiao Therefore my opinion is we may give up this feature. What's your commentsand suggestions?
|
|
|
|
Re: [PATCH 0/1] Enable to set RTC for beagleboard
Bruce Ashfield <bruce.ashfield@...>
On 11-06-15 10:23 PM, Lu Jingdong wrote:
On 06/16/2011 01:33 AM, Darren Hart wrote:Ack'd. For me, this is reasonable. Having a working RTC evenThe signal "msecure" on TPS65950 connects to "msecure" on OMAP3530 and if it doesn't survive power cycle is worth having. In particular, since the patch is simple. perfect.This patch can be found on linux-omap tree.I want to hear back from Jingdong regarding this patch first. Is thisI'm ok with that resolution .. for the bug. But if the patchThanks Koen,I'll wait to hear upstream status on this. Given the requirements for This is key. We must have this in our patch commits. I can provide examples if you aren't familiar and Mark Hatle just sent out some oe-core examples of the same thing. In this case you'd put something like: commit e2a346a2a054f7 from git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-2.6.git after the shortlog, and before the long log. Add your Integrated-by: to the sign off section of the patch. Cheers, Bruce
|
|
|
|
Re: [PATCH 0/1] Enable to set RTC for beagleboard
Lu Jingdong <jingdong.lu@...>
On 06/16/2011 01:33 AM, Darren Hart wrote:
The signal "msecure" on TPS65950 connects to "msecure" on OMAP3530 and setting/writing RTC register is controlled by OMAP3530 "msecure". So we should pull the "msecure" high on OMAP3530 so that we can set/write RTC register on TPS65950. We test RTC on beagleboard by adding this patch. RTC can be set a correct date and it works well when power on. Because there is no backup battery on beagleboard C4, RTC can not be saved whenYou need to remove some resistors and add a battery, or add an power off. If we want to keep RTC without power, we should remove R66 and install a battery on board. This patch can be found on linux-omap tree.I want to hear back from Jingdong regarding this patch first. Is thisI'm ok with that resolution .. for the bug. But if the patchThanks Koen,I'll wait to hear upstream status on this. Given the requirements for http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-2.6.git;a=commit;h=e2a346a2a054f702fd76f328ff747b9ad9264a4c arm: omap3: beagle: Ensure msecure is mux'd to be able to set the RTC Without msecure beeing high it isn't possible to set (or start) the RTC. Tested with a BeagleBoard C4. Signed-off-by: Alexander Holler <holler@...> Signed-off-by: Tony Lindgren <tony@...> So maybe I should recommit it by adding some upstream status and author. regards, Jingdong --Cheers, Lu Jingdong jingdong.lu@... China, Wind River
|
|
|
|
Re: configure optimization feature update
On Wed, Jun 15, 2011 at 5:57 PM, Xu, Dongxiao <dongxiao.xu@...> wrote:
Hi Richard,The autoconf'ing is sort of arbitrary at the moment. Depending on what is staged the results may vary. So some way of creating a cache is nice since it can be used to verify if package rebuild happens with same configure variables or not. Sometimes we have seen some packages are build differently first time since many packages are not staged. I did some testings for sato build, the result is not as good as we expected:Yeah thats definite pain. 3. How to distribute the caches will be a problem. The total size of such cache is about 900M (before compression) and 200M (after compression). Since the size is not small, distributing it with Poky source code doesn't make sense. On another aspect, we can use something like "sstate". But since we already have caches of sstate, I think it is not necessary for us to enable another similar cache mechanism with little improvement.hmm this is a real problem and probably the perf killer. I wonder why the sizes are so big. Therefore my opinion is we may give up this feature. What's your comments and suggestions?
|
|
|
|
configure optimization feature update
Xu, Dongxiao <dongxiao.xu@...>
Hi Richard,
Recently I was doing the "configure optimization" feature and collecting data for it. The main logic of this feature is straight forward: 1. Use the diff file as autoreconf cache. (I use command: "diff -ruN SOURCE-ORIG SOURCE", here "SOURCE-ORIG" is the source directory before running autoreconf, while "SOURCE" is the directory after running autoreconf). 2. Add SRC_URI checksum for all patches of the source code. 3. Tag each autoreconf cache file with ${PN} and the SRC_URI checksum of source code and all patches. 4. If the currently SRC_URI checksum matches the cached checksum, then we can patch the cache instead of running "autoreconf" stage. I did some testings for sato build, the result is not as good as we expected: On a server build machine (Genuine Intel(R) CPU @ 2.40GHz, 2 sockets with 6 core each and hyperthreading, thus 24 logical CPUs in all, 66G memory): w/o the optimization: real 83m40.963s user 496m58.550s sys 329m1.590s w/ the optimization: real 79m1.062s user 460m58.600s sys 347m42.120s It has about 5% performance gain. I also tested the patch on a desktop core-i7 machine (Intel(R) Core(TM) i7 CPU 870 @ 2.93GHz, 4 core 8 logical CPU, 4G memory): w/o the optimization: real 105m25.436s user 372m48.040s sys 51m23.950s w/ the optimization: real 103m38.314s user 332m35.770s sys 49m4.520s It only has about 2% performance gain. The result is not encouraging. There are also some other things we need to take into consideration for this feature: 1. If add this feature, the first build time should be longer than current since it needs to build the autoreconf cache. 2. Maintainers needs to maintain the SRC_URI checksums not only for source code, but also all its patches. For some recipes, it has more than 20 patches, which needs assignable maintenance effort. 3. How to distribute the caches will be a problem. The total size of such cache is about 900M (before compression) and 200M (after compression). Since the size is not small, distributing it with Poky source code doesn't make sense. On another aspect, we can use something like "sstate". But since we already have caches of sstate, I think it is not necessary for us to enable another similar cache mechanism with little improvement. Therefore my opinion is we may give up this feature. What's your comments and suggestions? Thanks, Dongxiao
|
|
|
|
Re: [PATCH 0/1] Enable to set RTC for beagleboard
Darren Hart <dvhart@...>
On 06/15/2011 09:52 AM, Bruce Ashfield wrote:
On 06/15/11 12:48, Darren Hart wrote:I'm ok with that resolution .. for the bug. But if the patch I want to hear back from Jingdong regarding this patch first. Is this new code? If so, then yes, let's get it to mainline as Bruce suggested. -- Darren Hart Intel Open Source Technology Center Yocto Project - Linux Kernel
|
|
|
|
Re: [PATCH 0/1] Enable to set RTC for beagleboard
Bruce Ashfield <bruce.ashfield@...>
On 06/15/11 12:48, Darren Hart wrote:
I'm ok with that resolution .. for the bug. But if the patch isn't already in another upstream tree, it's worth having (if benign to the rest of the variants) and then we can get it sent upstream from there. I can change the bug's status if you like. Cheers, Bruce
|
|
|
|
Re: [PATCH 0/1] Enable to set RTC for beagleboard
Darren Hart <dvhart@...>
On 06/15/2011 06:31 AM, Bruce Ashfield wrote:
On 06/15/11 09:25, Koen Kooi wrote: I do not have something similar queued. Thanks Koen,What tests did you run to ensure that the RTC worked on theYou need to remove some resistors and add a battery, or add an I'll wait to hear upstream status on this. Given the requirements for use, I wouldn't mind just closing 767 as will not fix as it can't work with the beagleboard out of the box anyway. -- Darren Cheers,-- Darren Hart Intel Open Source Technology Center Yocto Project - Linux Kernel
|
|
|
|
Re: [PATCH 0/1] Enable to set RTC for beagleboard
Bruce Ashfield <bruce.ashfield@...>
On 06/15/11 09:25, Koen Kooi wrote:
Thanks Koen, This confirms what I thought (zippy*), so clearly this is either a board with that setup, or runtime testing was .. unique. Either way, more details and research is needed for this one. Cheers, Bruce
|
|
|
|
Re: [PATCH 0/1] Enable to set RTC for beagleboard
Koen Kooi
Op 15 jun 2011, om 15:21 heeft Bruce Ashfield het volgende geschreven:
On 06/15/11 06:41, Jingdong Lu wrote:You need to remove some resistors and add a battery, or add an expansionboard like the zippy or zippy2, which have a DS1307 RTC with battery.From: Jingdong Lu<jingdong.lu@...>Jingdong, regards, Koen
|
|
|
|
Re: [PATCH 0/1] Enable to set RTC for beagleboard
Bruce Ashfield <bruce.ashfield@...>
On 06/15/11 06:41, Jingdong Lu wrote:
From: Jingdong Lu<jingdong.lu@...>Jingdong, The fix looks reasonable to me, Darren has been refreshing the beagleboard support as well, so I've cc'd him here to see if we have this change present in the work in progress trees. What tests did you run to ensure that the RTC worked on the beagleboard ? There was some debate around whether or not you needed an add-on card to get this functionality available ? Also for for any beagleboard changes, we should: - check the various upstream trees and use their commits if possible. Or if you've checked and couldn't find anything. State that in the patch submission. - reference the test platform details. Rev of the board, the model, etc. Thanks for the patch, we just need to do a bit more checking on it before we can get it into the tree. Cheers, Bruce
|
|
|
|
[PATCH 1/1] RTC: Enable to set RTC
Jingdong Lu <jingdong.lu@...>
From: Jingdong Lu <jingdong.lu@...>
"Msecure" signal provides for protection of the RTC register in TPS65950 be disabling that function via a control signal from the OMAP3530. So ensure msecure is mux'd to be able to set the RTC. Fixes bug [YOCTO #767] Signed-off-by: Jingdong Lu <jingdong.lu@...> --- arch/arm/mach-omap2/board-omap3beagle.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-omap2/board-omap3beagle.c b/arch/arm/mach-omap2/board-omap3beagle.c index af1166b..925c0b3 100644 --- a/arch/arm/mach-omap2/board-omap3beagle.c +++ b/arch/arm/mach-omap2/board-omap3beagle.c @@ -580,6 +580,9 @@ static void __init omap3_beagle_init(void) usb_ehci_init(&ehci_pdata); omap3beagle_flash_init(); + /* Ensure msecure is mux'd to be able to set the RTC. */ + omap_mux_init_signal("sys_drm_msecure", OMAP_PIN_OFF_OUTPUT_HIGH); + /* Ensure SDRC pins are mux'd for self-refresh */ omap_mux_init_signal("sdrc_cke0", OMAP_PIN_OUTPUT); omap_mux_init_signal("sdrc_cke1", OMAP_PIN_OUTPUT); -- 1.7.0.4
|
|
|
|
[PATCH 0/1] Enable to set RTC for beagleboard
Jingdong Lu <jingdong.lu@...>
From: Jingdong Lu <jingdong.lu@...>
Ensure msecure is mux'd to be able to set the RTC for beagleboard. Fixes bug [YOCTO #767] Jingdong Lu (1): RTC: Enable to set RTC arch/arm/mach-omap2/board-omap3beagle.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)
|
|
|
|
Re: [PATCH] meta-intel/linux-yocto: update to match the renamed linux-yocto recipes
Bruce Ashfield <bruce.ashfield@...>
On 11-06-14 8:04 PM, Darren Hart wrote:
On 06/14/2011 01:47 PM, Bruce Ashfield wrote:Drop this. I was on the way out, and had made this change toThe linux-yocto recipes have been renamed to include explicit... speed up my builds. Thanks! Bruce
|
|
|
|
Re: [PATCH] meta-intel/linux-yocto: update to match the renamed linux-yocto recipes
Darren Hart <dvhart@...>
On 06/14/2011 01:47 PM, Bruce Ashfield wrote:
The linux-yocto recipes have been renamed to include explicit... diff --git a/meta-crownbay/conf/machine/crownbay.conf b/meta-crownbay/conf/machine/crownbay.conf I assume this was an accident? If I don't hear from you shortly I'll commit without this change and we can add it back if it was intentional. It wasn't in the commit message, so I'm assuming not. -- Darren Hart Intel Open Source Technology Center Yocto Project - Linux Kernel
|
|
|
|
[PATCH 1/1] meta-intel: add systemtap bbappends
tom.zanussi@...
From: Tom Zanussi <tom.zanussi@...>
Add systemtap to task-core-tools-profile for crownbay, crownbay-noemgd, fishriver, jasperforest, n450, and sugarbay. Signed-off-by: Tom Zanussi <tom.zanussi@...> --- .../recipes-core/tasks/task-core-tools.bbappend | 3 +++ .../recipes-core/tasks/task-core-tools.bbappend | 2 +- .../recipes-core/tasks/task-core-tools.bbappend | 2 ++ .../recipes-core/tasks/task-core-tools.bbappend | 2 ++ .../recipes-core/tasks/task-core-tools.bbappend | 2 ++ .../recipes-core/tasks/task-core-tools.bbappend | 2 ++ 6 files changed, 12 insertions(+), 1 deletions(-) create mode 100644 meta-crownbay/recipes-core/tasks/task-core-tools.bbappend create mode 100644 meta-fishriver/recipes-core/tasks/task-core-tools.bbappend create mode 100644 meta-jasperforest/recipes-core/tasks/task-core-tools.bbappend create mode 100644 meta-n450/recipes-core/tasks/task-core-tools.bbappend create mode 100644 meta-sugarbay/recipes-core/tasks/task-core-tools.bbappend diff --git a/meta-crownbay/recipes-core/tasks/task-core-tools.bbappend b/meta-crownbay/recipes-core/tasks/task-core-tools.bbappend new file mode 100644 index 0000000..2181151 --- /dev/null +++ b/meta-crownbay/recipes-core/tasks/task-core-tools.bbappend @@ -0,0 +1,3 @@ +RRECOMMENDS_task-core-tools-profile_append_crownbay = " systemtap" +RRECOMMENDS_task-core-tools-profile_append_crownbay-noemgd = " systemtap" + diff --git a/meta-emenlow/recipes-core/tasks/task-core-tools.bbappend b/meta-emenlow/recipes-core/tasks/task-core-tools.bbappend index 9743e2c..890d103 100644 --- a/meta-emenlow/recipes-core/tasks/task-core-tools.bbappend +++ b/meta-emenlow/recipes-core/tasks/task-core-tools.bbappend @@ -1,2 +1,2 @@ -RDEPENDS_task-core-tools-profile_append_emenlow = " lttng-ust systemtap" +RRECOMMENDS_task-core-tools-profile_append_emenlow = " lttng-ust systemtap" diff --git a/meta-fishriver/recipes-core/tasks/task-core-tools.bbappend b/meta-fishriver/recipes-core/tasks/task-core-tools.bbappend new file mode 100644 index 0000000..128531b --- /dev/null +++ b/meta-fishriver/recipes-core/tasks/task-core-tools.bbappend @@ -0,0 +1,2 @@ +RRECOMMENDS_task-core-tools-profile_append_fishriver = " systemtap" + diff --git a/meta-jasperforest/recipes-core/tasks/task-core-tools.bbappend b/meta-jasperforest/recipes-core/tasks/task-core-tools.bbappend new file mode 100644 index 0000000..6561773 --- /dev/null +++ b/meta-jasperforest/recipes-core/tasks/task-core-tools.bbappend @@ -0,0 +1,2 @@ +RRECOMMENDS_task-core-tools-profile_append_jasperforest = " systemtap" + diff --git a/meta-n450/recipes-core/tasks/task-core-tools.bbappend b/meta-n450/recipes-core/tasks/task-core-tools.bbappend new file mode 100644 index 0000000..3098950 --- /dev/null +++ b/meta-n450/recipes-core/tasks/task-core-tools.bbappend @@ -0,0 +1,2 @@ +RRECOMMENDS_task-core-tools-profile_append_n450 = " systemtap" + diff --git a/meta-sugarbay/recipes-core/tasks/task-core-tools.bbappend b/meta-sugarbay/recipes-core/tasks/task-core-tools.bbappend new file mode 100644 index 0000000..6cd24d0 --- /dev/null +++ b/meta-sugarbay/recipes-core/tasks/task-core-tools.bbappend @@ -0,0 +1,2 @@ +RRECOMMENDS_task-core-tools-profile_append_sugarbay = " systemtap" + -- 1.7.0.4
|
|
|