Date   

Re: How to set IMAGE_ROOTFS_SIZE ?

Michael Opdenacker
 

Hello Simone,

On 10/29/21 10:21 AM, Simone Azzalin wrote:
Hello,

I am trying to set a default size for the rootfs.jffs2 generated by
Yocto.
For this purpose, if I am not wrong, this can be done using the
IMAGE_ROOTFS_SIZE option.

But where  I have to configure this option ? So, in which
configuration file ?

You can define it either in your image recipe (if you have a custom
one), or in conf/local.conf.

It seems that this detail has not been specified in the reference manual.

True, but this is a more generic mechanism that we chose not to repeat
for each variable. Essentially, the documentation at
https://docs.yoctoproject.org/dev-manual/common-tasks.html#customizing-images-using-local-conf
explains that your image can be customized through conf/local.conf or by
writing your own image recipe.

I agree the manual is so big that this may not be clear.

Cheers
Michael.


Thanks,
Simon



--
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


[yocto-autobuilder2][PATCH] builders.py: subtract builder weight instead of add

Trevor Gamblin
 

Signed-off-by: Trevor Gamblin <trevor.gamblin@...>
---
builders.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/builders.py b/builders.py
index f94d1dd..fc92e36 100644
--- a/builders.py
+++ b/builders.py
@@ -168,7 +168,7 @@ def prioritizeBuilders(master, builders):
time = max_time
else:
if bldr.name in builder_bonuses:
- time = time + builder_bonuses[bldr.name]
+ time = time - builder_bonuses[bldr.name]
defer.returnValue((time, bldr))

transformed = yield defer.gatherResults(
--
2.31.1


Re: Minutes: Yocto Project Weekly Triage Meeting 10/28/2021

Richard Purdie
 

On Thu, 2021-10-28 at 11:32 -0400, Trevor Gamblin wrote:
Wiki: https://wiki.yoctoproject.org/wiki/Bug_Triage
Attendees: Alexandre, Anuj, Armin, Joshua, Kiran, Randy, Richard, Saul,
Stephen, Steve, Tim, Trevor
ARs:
- Everyone to review Old Milestone bugs and move to 3.5 milestones as
necessary
- Richard to add guidance to Bug # 14613
I added some comments.

Cheers,

Richard


[yocto-autobuilder2][PATCH] builders.py: fix bonus time calculation

Trevor Gamblin
 

Modify the builder_bonuses calculation so that it provides variable
bonus time based on the builder, rather than a constant value.

Signed-off-by: Trevor Gamblin <trevor.gamblin@...>
---
builders.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/builders.py b/builders.py
index 5773950..f94d1dd 100644
--- a/builders.py
+++ b/builders.py
@@ -145,7 +145,7 @@ for builder in config.subbuilders:
# Add 2 seconds * length as the weight so tightly constrained builders go first
builder_bonuses = {}
for builder in config.builder_to_workers:
- bonus = (len(config.workers) - len(config.builder_to_workers)) * 2
+ bonus = (len(config.workers) - len(config.builder_to_workers[builder])) * 2
builder_bonuses[builder] = timedelta(seconds=bonus)

# Modified default algothirm from buildbot with a bonus mechanism (thanks tardyp!)
--
2.31.1


Looking for advices on bug 14375 #systemd

Marc Ferland
 

Hi,

I'm looking for advice on https://bugzilla.yoctoproject.org/show_bug.cgi?id=14375

Seems like an easy fix but not sure how I should handle it. I'm willing to put in the effort, just need some pointers first.

Any tips/ideas are welcomed!

Marc


[yocto-autobuilder2][PATCH] builders.py: Add canStartBuild disk space check

Trevor Gamblin
 

We need a way to limit the builds for when a given worker has less than
a certain amount of disk space available. This implements a
canStartBuild method based on the example in the Buildbot docs and
blocks a build if the worker has less than 60GB of disk space available.
Unlike the example code, we want the stdout of the command so that we
can calculate the amount of disk space, rather than just relying on the
remote command's return code.

Docs: https://docs.buildbot.net/latest/manual/customization.html#canstartbuild-functions

[YOCTO #14591]

Signed-off-by: Trevor Gamblin <trevor.gamblin@...>
---
builders.py | 44 ++++++++++++++++++++++++++++++++++++++++----
1 file changed, 40 insertions(+), 4 deletions(-)

diff --git a/builders.py b/builders.py
index 5773950..0d1facc 100644
--- a/builders.py
+++ b/builders.py
@@ -8,6 +8,7 @@ from yoctoabb import config
from yoctoabb.steps.writelayerinfo import WriteLayerInfo
from yoctoabb.steps.runconfig import get_publish_dest, get_publish_resultdir, get_publish_name, RunConfigCheckSteps, TargetPresent
from buildbot.process.results import Results, SUCCESS, FAILURE, CANCELLED, WARNINGS, SKIPPED, EXCEPTION, RETRY
+from buildbot.process.remotecommand import RemoteCommand

from twisted.python import log
from twisted.internet import defer
@@ -45,6 +46,41 @@ def ensure_props_set(props):
"publish_destination": props.getProperty("publish_destination", "")
}

+@...
+def shell(command, worker, builder):
+ args = {
+ 'command': command,
+ 'workdir': worker.worker_basedir,
+ 'logEnviron': False,
+ 'want_stdout': True,
+ 'want_stderr': False,
+ }
+
+ cmd = RemoteCommand('shell', args, collectStdout=True, stdioLogName="stdio")
+ cmd.worker = worker
+ yield cmd.run(None, worker.conn, builder.name)
+ return cmd
+
+@...
+def canStartBuild(builder, wfb, request):
+ log.msg("Checking available disk space...")
+
+ cmd = yield shell("df -BG | grep $(findmnt -T . | awk '{print $2}' | sed -n 2p) | awk '{print $4}' | sed 's/[^0-9]*//g'", wfb.worker, builder)
+ threshold = 60 # GB of space
+ if int(cmd.stdout) < threshold:
+ log.msg("Detected {0} GB of space available, less than threshold of {1} GB. Can't start build".format(cmd.stdout, threshold))
+ wfb.worker.putInQuarantine()
+ return False
+ else:
+ log.msg("Detected {0} GB of space available, more than threshold of {1} GB. OK to build".format(cmd.stdout, threshold))
+
+ wfb.worker.quarantine_timeout = 120
+ wfb.worker.putInQuarantine()
+
+ wfb.worker.resetQuarantine()
+
+ return True
+
def create_builder_factory():
f = util.BuildFactory()

@@ -136,7 +172,7 @@ for builder in config.subbuilders:
if not workers:
workers = config.builder_to_workers['default']
builders.append(util.BuilderConfig(name=builder,
- workernames=workers, nextWorker=nextWorker, nextBuild=nextBuild,
+ workernames=workers, canStartBuild=canStartBuild, nextWorker=nextWorker, nextBuild=nextBuild,
factory=f, env=extra_env))

# Prioritize assigning builders to available workers based on the length
@@ -300,8 +336,8 @@ def create_parent_builder_factory(buildername, waitname):

return factory

-builders.append(util.BuilderConfig(name="a-quick", workernames=config.workers, factory=create_parent_builder_factory("a-quick", "wait-quick"), nextWorker=nextWorker, nextBuild=nextBuild, env=extra_env))
-builders.append(util.BuilderConfig(name="a-full", workernames=config.workers, factory=create_parent_builder_factory("a-full", "wait-full"), nextWorker=nextWorker, nextBuild=nextBuild, env=extra_env))
+builders.append(util.BuilderConfig(name="a-quick", workernames=config.workers, factory=create_parent_builder_factory("a-quick", "wait-quick"), canStartBuild=canStartBuild, nextWorker=nextWorker, nextBuild=nextBuild, env=extra_env))
+builders.append(util.BuilderConfig(name="a-full", workernames=config.workers, factory=create_parent_builder_factory("a-full", "wait-full"), canStartBuild=canStartBuild,nextWorker=nextWorker, nextBuild=nextBuild, env=extra_env))

def create_doc_builder_factory():
f = util.BuildFactory()
@@ -345,4 +381,4 @@ def create_doc_builder_factory():

# Only run one docs build at a time
docs_lock = util.MasterLock("docs_lock")
-builders.append(util.BuilderConfig(name="docs", workernames=config.workers, factory=create_doc_builder_factory(), nextWorker=nextWorker, nextBuild=nextBuild, env=extra_env, locks=[docs_lock.access('exclusive')]))
+builders.append(util.BuilderConfig(name="docs", workernames=config.workers, factory=create_doc_builder_factory(), canStartBuild=canStartBuild, nextWorker=nextWorker, nextBuild=nextBuild, env=extra_env, locks=[docs_lock.access('exclusive')]))
--
2.31.1


How to set IMAGE_ROOTFS_SIZE ?

sazzalin@...
 

Hello,

I am trying to set a default size for the rootfs.jffs2 generated by Yocto.
For this purpose, if I am not wrong, this can be done using the IMAGE_ROOTFS_SIZE option.

But where  I have to configure this option ? So, in which configuration file ?
It seems that this detail has not been specified in the reference manual.

Thanks,
Simon


[yocto-autobuilder2][dunfell 1/1] config.py: debian 11 should have been enabled in dunfell, not warrior, fix it

Steve Sakoman
 

Signed-off-by: Steve Sakoman <steve@...>
---
config.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/config.py b/config.py
index 3874f04..58418a7 100644
--- a/config.py
+++ b/config.py
@@ -149,9 +149,9 @@ all_workers = workers + workers_bringup + workers_buildperf + workers_arm
workers_prev_releases = {
"hardknott" : ("centos7", "centos8", "debian8", "debian9", "debian10", "fedora31", "fedora32", "fedora33", "opensuse152", "ubuntu1604", "ubuntu1804", "ubuntu2004", "perf-"),
"gatesgarth" : ("centos7", "centos8", "debian8", "debian9", "debian10", "fedora30", "fedora31", "fedora32", "opensuse150", "opensuse151", "opensuse152", "ubuntu1604", "ubuntu1804", "ubuntu1904", "ubuntu2004", "perf-"),
- "dunfell" : ("centos7", "centos8", "debian8", "debian9", "debian10", "fedora29", "fedora30", "fedora31", "fedora32", "fedora33", "fedora34", "opensuse150", "opensuse151", "opensuse152", "ubuntu1604", "ubuntu1804", "ubuntu1904", "ubuntu2004", "perf-"),
+ "dunfell" : ("centos7", "centos8", "debian8", "debian9", "debian10", "debian11", "fedora29", "fedora30", "fedora31", "fedora32", "fedora33", "fedora34", "opensuse150", "opensuse151", "opensuse152", "ubuntu1604", "ubuntu1804", "ubuntu1904", "ubuntu2004", "perf-"),
"zeus" : ("centos7", "debian8", "debian9", "debian10", "fedora28", "fedora29", "fedora30", "opensuse150", "opensuse151", "ubuntu1604", "ubuntu1804", "ubuntu1904", "perf-"),
- "warrior" : ("centos7", "debian8", "debian9", "debian10", "debian11", "fedora28", "fedora29", "fedora30", "opensuse150", "opensuse151", "ubuntu1604", "ubuntu1804", "ubuntu1904", "perf-"),
+ "warrior" : ("centos7", "debian8", "debian9", "debian10", "fedora28", "fedora29", "fedora30", "opensuse150", "opensuse151", "ubuntu1604", "ubuntu1804", "ubuntu1904", "perf-"),
"thud" : ("centos7", "debian8", "debian9", "debian10", "fedora28", "fedora29", "fedora30", "opensuse150", "opensuse151", "ubuntu1604", "ubuntu1804", "ubuntu1904", "perf-"),
"sumo" : ("centos7", "debian8", "debian9", "fedora28", "ubuntu1604", "ubuntu1804", "perf-")
}
--
2.25.1


Re: Dunfell: problem with kernel-module install and libkmod.so

Patrick Boettcher
 

On Fri, 15 Oct 2021 20:03:52 +0000
"Patrick Boettcher" <patrick.boettcher@...> wrote:

Hi list,

I'm facing an issue with a BSP I created using dunfell (up-to-date on
poky and oe). I'm using a stable kernel and u-boot 2021.07 from denx's
mainline-stable-layer.
It was a problem of DDR memory configuration and calibration.

Hard to track, but once you know it, easy to find and fix.

--
Patrick.


Minutes: Yocto Project Weekly Triage Meeting 10/28/2021

Trevor Gamblin
 

Wiki: https://wiki.yoctoproject.org/wiki/Bug_Triage

Attendees: Alexandre, Anuj, Armin, Joshua, Kiran, Randy, Richard, Saul, Stephen, Steve, Tim, Trevor

ARs:

- Everyone to review Old Milestone bugs and move to 3.5 milestones as necessary

- Richard to add guidance to Bug # 14613

Notes:

N/A

Medium+ 3.5 Unassigned Enhancements/Bugs: 81 (Last week 13; 3.4 bugs merged to this list)

Medium+ 3.99 Unassigned Enhancements/Bugs: 39 (No change)

AB Bugs: 62 (Last week 63)


Re: [Automated-testing] BusyBox pTest failure

Khem Raj
 



On Wed, Oct 27, 2021 at 1:40 PM Richard Purdie <richard.purdie@...> wrote:
On Wed, 2021-10-27 at 16:22 +0530, rpaluri@... wrote:
> Hi,
>     We are executing busybox pTests and we see that the test case execution
> stops at md5sum test case.
> We analyzed and see that the execution gets stuck here at Line no 29.
>  
> Below are the relevant code lines:
> Line no. 28: text="The quick brown fox jumps over the lazy dog"
> Line no. 29: text=`yes "$text" | head -c 9999`
>  
> I executed above two lines on my host machine and the I get the shell prompt
> back but when executed on target machine, I’m not getting the shell prompt, it
> gets stuck.
> /usr/lib/busybox/ptest # text="The quick brown fox jumps over the lazy dog"
> /usr/lib/busybox/ptest # text=`yes “$text” | head -c 9999`
> <<get stuck here indefinitely and I don’t get the shell prompt>>
>  
> I modified Line no. 29 as below (removed “ around $text) and the test case
> execution proceeds further with “yes: Broken Pipe” error. With the same
> modification, I don’t see this error on my host machine though.
> Line no. 29: text=`yes $text | head -c 9999`
>  
> /usr/lib/busybox/ptest # text="The quick brown fox jumps over the lazy dog"
> /usr/lib/busybox/ptest # text=`yes $text | head -c 9999`
> yes: Broken pipe
>  
> My host machine uses Bash as my default shell where as my target uses busybox
> sh as my default shell. Does this make any difference?
> Any pointers on this will be appreciated.
>

The shell the test is run under could make a difference, it is probably supposed
to be running under busybox's own sh. I think we put the busybox utils into PATH
in the ptest to try and ensure this is the case but you'd have to double check
that.

It seems odd you're hitting that as I'd assume we run the busybox ptests
ourselves and don't see a hang...

It’s also good to post your build configuration that bitbake prints at the beginning of build this could also be other policies like default libc being musl vs glibc is in play etc 


Cheers,

Richard






Re: [Automated-testing] BusyBox pTest failure

Richard Purdie
 

On Wed, 2021-10-27 at 16:22 +0530, rpaluri@... wrote:
Hi,
    We are executing busybox pTests and we see that the test case execution
stops at md5sum test case.
We analyzed and see that the execution gets stuck here at Line no 29.
 
Below are the relevant code lines:
Line no. 28: text="The quick brown fox jumps over the lazy dog"
Line no. 29: text=`yes "$text" | head -c 9999`
 
I executed above two lines on my host machine and the I get the shell prompt
back but when executed on target machine, I’m not getting the shell prompt, it
gets stuck.
/usr/lib/busybox/ptest # text="The quick brown fox jumps over the lazy dog"
/usr/lib/busybox/ptest # text=`yes “$text” | head -c 9999`
<<get stuck here indefinitely and I don’t get the shell prompt>>
 
I modified Line no. 29 as below (removed “ around $text) and the test case
execution proceeds further with “yes: Broken Pipe” error. With the same
modification, I don’t see this error on my host machine though.
Line no. 29: text=`yes $text | head -c 9999`
 
/usr/lib/busybox/ptest # text="The quick brown fox jumps over the lazy dog"
/usr/lib/busybox/ptest # text=`yes $text | head -c 9999`
yes: Broken pipe
 
My host machine uses Bash as my default shell where as my target uses busybox
sh as my default shell. Does this make any difference?
Any pointers on this will be appreciated.
The shell the test is run under could make a difference, it is probably supposed
to be running under busybox's own sh. I think we put the busybox utils into PATH
in the ptest to try and ensure this is the case but you'd have to double check
that.

It seems odd you're hitting that as I'd assume we run the busybox ptests
ourselves and don't see a hang...

Cheers,

Richard


[meta-selinux][dunfell][PATCH 3/3] libselinux: Fix restorecon_set_sehandle.patch context

Jason Andryuk
 

0001-Fix-NULL-pointer-use-in-selinux_restorecon_set_sehandle.patch added
in commit d6ff5a0e67af "libselinux: Backport NULL pointer fix from 3.1"
fails to apply because there is a extra level in the patch context.
The patch cannot apply and do_patch fails. Fix the context so it builds
again.

Signed-off-by: Jason Andryuk <jandryuk@...>
---
...-NULL-pointer-use-in-selinux_restorecon_set_sehandle.patch | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/recipes-security/selinux/libselinux/0001-Fix-NULL-pointer-use-in-selinux_restorecon_set_sehandle.patch b/recipes-security/selinux/libselinux/0001-Fix-NULL-pointer-use-in-selinux_restorecon_set_sehandle.patch
index 8a9fb7c..f392f68 100644
--- a/recipes-security/selinux/libselinux/0001-Fix-NULL-pointer-use-in-selinux_restorecon_set_sehandle.patch
+++ b/recipes-security/selinux/libselinux/0001-Fix-NULL-pointer-use-in-selinux_restorecon_set_sehandle.patch
@@ -17,8 +17,8 @@ Acked-by: Stephen Smalley <stephen.smalley.work@...>

diff --git a/libselinux/src/selinux_restorecon.c b/libselinux/src/selinux_restorecon.c
index d1ce830c5..6993be6fd 100644
---- a/libselinux/src/selinux_restorecon.c
-+++ b/libselinux/src/selinux_restorecon.c
+--- libselinux/src/selinux_restorecon.c
++++ libselinux/src/selinux_restorecon.c
@@ -1154,6 +1154,8 @@ void selinux_restorecon_set_sehandle(struct selabel_handle *hndl)
size_t num_specfiles, fc_digest_len;

--
2.31.1


[meta-selinux][dunfell][PATCH 2/3] Remove e2fsprogs override

Jason Andryuk
 

commit b2b3ea27e3e3 "e2fsprogs: Superseded by upstream." removed
lib-ext2fs-ext2_ext_attr.h-add-xattr-index.patch from SRC_URI. It was
no longer applied, but the file was not deleted. Do that now.

e2fsprogs_%.bbappend/e2fsprogs_selinux.inc now do nothing, so remove
them as well.

Signed-off-by: Jason Andryuk <jandryuk@...>
---
.../e2fsprogs/e2fsprogs_%.bbappend | 1 -
.../e2fsprogs/e2fsprogs_selinux.inc | 1 -
...t2fs-ext2_ext_attr.h-add-xattr-index.patch | 20 -------------------
3 files changed, 22 deletions(-)
delete mode 100644 recipes-devtools/e2fsprogs/e2fsprogs_%.bbappend
delete mode 100644 recipes-devtools/e2fsprogs/e2fsprogs_selinux.inc
delete mode 100644 recipes-devtools/e2fsprogs/files/lib-ext2fs-ext2_ext_attr.h-add-xattr-index.patch

diff --git a/recipes-devtools/e2fsprogs/e2fsprogs_%.bbappend b/recipes-devtools/e2fsprogs/e2fsprogs_%.bbappend
deleted file mode 100644
index 7719d3b..0000000
--- a/recipes-devtools/e2fsprogs/e2fsprogs_%.bbappend
+++ /dev/null
@@ -1 +0,0 @@
-require ${@bb.utils.contains('DISTRO_FEATURES', 'selinux', '${BPN}_selinux.inc', '', d)}
diff --git a/recipes-devtools/e2fsprogs/e2fsprogs_selinux.inc b/recipes-devtools/e2fsprogs/e2fsprogs_selinux.inc
deleted file mode 100644
index 81fe7b7..0000000
--- a/recipes-devtools/e2fsprogs/e2fsprogs_selinux.inc
+++ /dev/null
@@ -1 +0,0 @@
-FILESEXTRAPATHS_prepend := "${THISDIR}/files:"
diff --git a/recipes-devtools/e2fsprogs/files/lib-ext2fs-ext2_ext_attr.h-add-xattr-index.patch b/recipes-devtools/e2fsprogs/files/lib-ext2fs-ext2_ext_attr.h-add-xattr-index.patch
deleted file mode 100644
index b87c414..0000000
--- a/recipes-devtools/e2fsprogs/files/lib-ext2fs-ext2_ext_attr.h-add-xattr-index.patch
+++ /dev/null
@@ -1,20 +0,0 @@
-Add xattr name index for xattrs with the 'security' prefix. These are defined
-in the ext(2|3|4)/xattr.h in the kernel. We use the EXT2 prefix for consistency
-with e2fslibs naming.
-
-Signed-off-by: Philip Tricca <flihp@...>
-
-Index: e2fsprogs-1.42.9/lib/ext2fs/ext2_ext_attr.h
-===================================================================
---- e2fsprogs-1.42.9.orig/lib/ext2fs/ext2_ext_attr.h
-+++ e2fsprogs-1.42.9/lib/ext2fs/ext2_ext_attr.h
-@@ -15,6 +15,9 @@
- /* Maximum number of references to one attribute block */
- #define EXT2_EXT_ATTR_REFCOUNT_MAX 1024
-
-+/* Name indexes */
-+#define EXT2_XATTR_INDEX_SECURITY 6
-+
- struct ext2_ext_attr_header {
- __u32 h_magic; /* magic number for identification */
- __u32 h_refcount; /* reference count */
--
2.31.1


[meta-selinux][dunfell][PATCH 1/3] e2fsprogs: Remove misc_create_inode.c-label_rootfs.patch

Jason Andryuk
 

An equivalent patch was merged into 1.45.7: commit 7616fd6a599e
"create_inode: set xattrs to the root directory as well". The existing
one still applies and actualy breaks building because of duplicate
lables. Remove it.

Signed-off-by: Jason Andryuk <jandryuk@...>
---
.../e2fsprogs/e2fsprogs_selinux.inc | 2 -
.../misc_create_inode.c-label_rootfs.patch | 45 -------------------
2 files changed, 47 deletions(-)
delete mode 100644 recipes-devtools/e2fsprogs/files/misc_create_inode.c-label_rootfs.patch

diff --git a/recipes-devtools/e2fsprogs/e2fsprogs_selinux.inc b/recipes-devtools/e2fsprogs/e2fsprogs_selinux.inc
index 9cbb7fe..81fe7b7 100644
--- a/recipes-devtools/e2fsprogs/e2fsprogs_selinux.inc
+++ b/recipes-devtools/e2fsprogs/e2fsprogs_selinux.inc
@@ -1,3 +1 @@
FILESEXTRAPATHS_prepend := "${THISDIR}/files:"
-
-SRC_URI += "file://misc_create_inode.c-label_rootfs.patch"
diff --git a/recipes-devtools/e2fsprogs/files/misc_create_inode.c-label_rootfs.patch b/recipes-devtools/e2fsprogs/files/misc_create_inode.c-label_rootfs.patch
deleted file mode 100644
index 046e521..0000000
--- a/recipes-devtools/e2fsprogs/files/misc_create_inode.c-label_rootfs.patch
+++ /dev/null
@@ -1,45 +0,0 @@
-From: Philip Tricca <flihp@...>
-To: tytso@...
-Cc: liezhi.yang@...
-Date: Sat, 20 Feb 2016 18:58:58 +0000
-Subject: [PATCH] misc/create_inode.c: Copy xattrs from root directory when populating fs.
-
-When copying a file system using the -d option the xattrs from the root
-directory need to be copied before the populate_fs recusion starts.
-
-Signed-off-by: Philip Tricca <flihp@...>
-Signed-off-by: Jeremy Puhlman <jpuhlman@...>
-
----
- misc/create_inode.c | 8 ++++++++
- 1 file changed, 8 insertions(+)
-
-diff --git a/misc/create_inode.c b/misc/create_inode.c
-index a7b6d348..cfd15922 100644
---- a/misc/create_inode.c
-+++ b/misc/create_inode.c
-@@ -979,6 +979,13 @@ errcode_t populate_fs2(ext2_filsys fs, ext2_ino_t parent_ino,
- return retval;
- }
-
-+ retval = set_inode_xattr(fs, root, source_dir);
-+ if (retval) {
-+ com_err(__func__, retval,
-+ _("while setting xattrs for \"%s\""), source_dir);
-+ goto out;
-+ }
-+
- file_info.path_len = 0;
- file_info.path_max_len = 255;
- file_info.path = calloc(file_info.path_max_len, 1);
-@@ -987,6 +994,7 @@ errcode_t populate_fs2(ext2_filsys fs, ext2_ino_t parent_ino,
- &file_info, fs_callbacks);
-
- free(file_info.path);
-+out:
- free(hdlinks.hdl);
- return retval;
- }
---
-2.11.1
-
--
2.31.1


[meta-selinux][dunfell][PATCH 0/3] Fix dunfell build

Jason Andryuk
 

meta-selinux fails to build libselinux and e2fsprogs. These patches
fix that and then removes the unused e2fsprogs overrides.

Jason Andryuk (3):
e2fsprogs: Remove misc_create_inode.c-label_rootfs.patch
Remove e2fsprogs override
libselinux: Fix restorecon_set_sehandle.patch context

.../e2fsprogs/e2fsprogs_%.bbappend | 1 -
.../e2fsprogs/e2fsprogs_selinux.inc | 3 --
...t2fs-ext2_ext_attr.h-add-xattr-index.patch | 20 ---------
.../misc_create_inode.c-label_rootfs.patch | 45 -------------------
...e-in-selinux_restorecon_set_sehandle.patch | 4 +-
5 files changed, 2 insertions(+), 71 deletions(-)
delete mode 100644 recipes-devtools/e2fsprogs/e2fsprogs_%.bbappend
delete mode 100644 recipes-devtools/e2fsprogs/e2fsprogs_selinux.inc
delete mode 100644 recipes-devtools/e2fsprogs/files/lib-ext2fs-ext2_ext_attr.h-add-xattr-index.patch
delete mode 100644 recipes-devtools/e2fsprogs/files/misc_create_inode.c-label_rootfs.patch

--
2.31.1


[PATCH yocto-autobuilder-helper] scripts: run-docs-build: patch yocto-3.3 and 3.4 releases

Quentin Schulz
 

Both releases are missing an important patch that changes the displayed
version from dev to the appropriate release number.

This is confusing to the user and probably breaks some assumptions in
some scripts.

Ideally, the tags should have been moved with those patches applied to
their respective branch but that is not a git best practice so we're
stuck with this "hack" instead.

3.3.x releases aren't impacted as they got the patch applied.

Signed-off-by: Quentin Schulz <quentin.schulz@...>
---

Not tested.

scripts/run-docs-build | 8 +++
.../0001-conf-update-for-release.patch | 48 +++++++++++++++++
.../0001-conf-update-for-release.patch | 54 +++++++++++++++++++
3 files changed, 110 insertions(+)
create mode 100644 scripts/yocto-3.3/0001-conf-update-for-release.patch
create mode 100644 scripts/yocto-3.4/0001-conf-update-for-release.patch

diff --git a/scripts/run-docs-build b/scripts/run-docs-build
index b2828e3..76693a7 100755
--- a/scripts/run-docs-build
+++ b/scripts/run-docs-build
@@ -7,6 +7,7 @@ ypdocs=$2/documentation/
bbdocs=$3/doc/
docs_buildtools=/srv/autobuilder/autobuilder.yoctoproject.org/pub/buildtools/x86_64-buildtools-docs-nativesdk-standalone-3.2+snapshot-20201105.sh
outputdir=$builddir/output
+scriptdir="$(dirname "$(readlink -f "${BASH_SOURCE[0]}")")"


cd $builddir
@@ -84,6 +85,13 @@ for tag in $(git tag --list 'yocto-*'); do
if [ "$first" = "$v_sphinx" ]; then
cd $ypdocs
git checkout $tag
+ # yocto-3.3 and yocto-3.4 were tagged before the current_version in
+ # conf.py was changed resulting in sphinx believing these are
+ # development branches which breaks all sorts of assumptions. Moving a
+ # tag isn't best practice so we just patch the releases here instead.
+ if [ "$tag" = "yocto-3.3" ] || [ "$tag" = "yocto-3.4" ]; then
+ git am "${scriptdir}/${tag}/0001-conf-update-for-release.patch"
+ fi
make clean
make publish
version=$(echo $tag | cut -c7-)
diff --git a/scripts/yocto-3.3/0001-conf-update-for-release.patch b/scripts/yocto-3.3/0001-conf-update-for-release.patch
new file mode 100644
index 0000000..79b4cde
--- /dev/null
+++ b/scripts/yocto-3.3/0001-conf-update-for-release.patch
@@ -0,0 +1,48 @@
+From 02f6e97894aa768ca1a7546646c35a175aca9a33 Mon Sep 17 00:00:00 2001
+From: Quentin Schulz <quentin.schulz@...>
+Date: Fri, 1 Oct 2021 17:21:48 +0200
+Subject: [PATCH] conf: update for release 3.3
+
+conf.py:
+* set version to 3.3
+
+switchers.js:
+* add 3.3 release
+* update 'dev' to 3.4
+
+Signed-off-by: Quentin Schulz <quentin.schulz@...>
+---
+ documentation/conf.py | 2 +-
+ documentation/sphinx-static/switchers.js | 3 ++-
+ 2 files changed, 3 insertions(+), 2 deletions(-)
+
+diff --git a/documentation/conf.py b/documentation/conf.py
+index 5a2e25f7b..ab1b2b14c 100644
+--- a/documentation/conf.py
++++ b/documentation/conf.py
+@@ -16,7 +16,7 @@ import os
+ import sys
+ import datetime
+
+-current_version = "dev"
++current_version = "3.3"
+
+ # String used in sidebar
+ version = 'Version: ' + current_version
+diff --git a/documentation/sphinx-static/switchers.js b/documentation/sphinx-static/switchers.js
+index 7a4edc9e7..96efab2e8 100644
+--- a/documentation/sphinx-static/switchers.js
++++ b/documentation/sphinx-static/switchers.js
+@@ -2,7 +2,8 @@
+ 'use strict';
+
+ var all_versions = {
+- 'dev': 'dev (3.3)',
++ 'dev': 'dev (3.4)',
++ '3.3': '3.3',
+ '3.2.3': '3.2.3',
+ '3.1.6': '3.1.6',
+ '3.0.4': '3.0.4',
+--
+2.31.1
+
diff --git a/scripts/yocto-3.4/0001-conf-update-for-release.patch b/scripts/yocto-3.4/0001-conf-update-for-release.patch
new file mode 100644
index 0000000..a940eb0
--- /dev/null
+++ b/scripts/yocto-3.4/0001-conf-update-for-release.patch
@@ -0,0 +1,54 @@
+From f6dcef2532c741c8b3ad251152b45e4079062ee3 Mon Sep 17 00:00:00 2001
+From: Quentin Schulz <quentin.schulz@...>
+Date: Thu, 21 Oct 2021 10:36:37 +0200
+Subject: [PATCH] [honister] conf: update for release 3.4
+
+conf.py:
+* set version to 3.4
+
+switchers.js:
+* add 3.4 release
+* update 'dev' to 3.5
+
+Signed-off-by: Quentin Schulz <quentin.schulz@...>
+---
+
+Not tested + Assumed to be enough
+No need to wait for the new release as the honister branch will be
+integrated in the docs only when tagged but let's make sure we don't
+forget to do this change before tagging a release.
+
+ documentation/conf.py | 2 +-
+ documentation/sphinx-static/switchers.js | 3 ++-
+ 2 files changed, 3 insertions(+), 2 deletions(-)
+
+diff --git a/documentation/conf.py b/documentation/conf.py
+index 8e0847938..104b49ea0 100644
+--- a/documentation/conf.py
++++ b/documentation/conf.py
+@@ -16,7 +16,7 @@ import os
+ import sys
+ import datetime
+
+-current_version = "dev"
++current_version = "3.4"
+
+ # String used in sidebar
+ version = 'Version: ' + current_version
+diff --git a/documentation/sphinx-static/switchers.js b/documentation/sphinx-static/switchers.js
+index 1e37b625a..6038dbb5a 100644
+--- a/documentation/sphinx-static/switchers.js
++++ b/documentation/sphinx-static/switchers.js
+@@ -2,7 +2,8 @@
+ 'use strict';
+
+ var all_versions = {
+- 'dev': 'dev (3.4)',
++ 'dev': 'dev (3.5)',
++ '3.4': '3.4',
+ '3.3.3': '3.3.3',
+ '3.2.4': '3.2.4',
+ '3.1.11': '3.1.11',
+--
+2.31.1
+
--
2.31.1


[PATCH yocto-autobuilder-helper] scripts: run-docs-build: build latest BB and YP releases

Quentin Schulz
 

honister and 1.52 Bitbake branch were recently released, so let's build
those too.

Signed-off-by: Quentin Schulz <quentin.schulz@...>
---
scripts/run-docs-build | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/scripts/run-docs-build b/scripts/run-docs-build
index 76693a7..3db4a97 100755
--- a/scripts/run-docs-build
+++ b/scripts/run-docs-build
@@ -35,7 +35,7 @@ mkdir $outputdir/bitbake/next
cp -r ./_build/final/* $outputdir/bitbake/next

# stable branches
-for branch in 1.46 1.48 1.50; do
+for branch in 1.46 1.48 1.50 1.52; do
git checkout $branch
make clean
make publish
@@ -68,7 +68,7 @@ mkdir $outputdir/next
cp -r ./_build/final/* $outputdir/next

# stable branches
-for branch in dunfell gatesgarth hardknott; do
+for branch in dunfell gatesgarth hardknott honister; do
cd $ypdocs
git checkout $branch
make clean
--
2.31.1


BusyBox pTest failure

rpaluri@...
 

Hi,

    We are executing busybox pTests and we see that the test case execution stops at md5sum test case.

We analyzed and see that the execution gets stuck here at Line no 29.

 

Below are the relevant code lines:

Line no. 28: text="The quick brown fox jumps over the lazy dog"

Line no. 29: text=`yes "$text" | head -c 9999`

 

I executed above two lines on my host machine and the I get the shell prompt back but when executed on target machine, I’m not getting the shell prompt, it gets stuck.

/usr/lib/busybox/ptest # text="The quick brown fox jumps over the lazy dog"

/usr/lib/busybox/ptest # text=`yes “$text” | head -c 9999`

<<get stuck here indefinitely and I don’t get the shell prompt>>

 

I modified Line no. 29 as below (removed “ around $text) and the test case execution proceeds further with “yes: Broken Pipe” error. With the same modification, I don’t see this error on my host machine though.

Line no. 29: text=`yes $text | head -c 9999`

 

/usr/lib/busybox/ptest # text="The quick brown fox jumps over the lazy dog"

/usr/lib/busybox/ptest # text=`yes $text | head -c 9999`

yes: Broken pipe

 

My host machine uses Bash as my default shell where as my target uses busybox sh as my default shell. Does this make any difference?

Any pointers on this will be appreciated.

 

Thanks,

Ravi

 


Re: [meta-cgl][PATCH 1/2] crmsh: fix deprecation on collections.MutableSet

Jeremy Puhlman
 

Series merged. Thanks.

On 10/26/2021 12:45 AM, Yi Zhao wrote:
Python 3.10 removes the deprecated aliases to collections abstract base
clases [1]. Using 'collections.abc.MutableSet' instead of
'collections.MutableSet'

[1]: https://bugs.python.org/issue37324

Fixes:
$ crm
Traceback (most recent call last):
File "/usr/bin/crm", line 29, in <module>
from crmsh import main
File "/usr/lib64/python3.10/site-packages/crmsh/main.py", line 18, in <module>
from . import ui_root
File "/usr/lib64/python3.10/site-packages/crmsh/ui_root.py", line 23, in <module>
from . import ui_cib
File "/usr/lib64/python3.10/site-packages/crmsh/ui_cib.py", line 16, in <module>
from .cibconfig import cib_factory
File "/usr/lib64/python3.10/site-packages/crmsh/cibconfig.py", line 23, in <module>
from . import orderedset
File "/usr/lib64/python3.10/site-packages/crmsh/orderedset.py", line 29, in <module>
class OrderedSet(collections.MutableSet):
AttributeError: module 'collections' has no attribute 'MutableSet'

Signed-off-by: Yi Zhao <yi.zhao@...>
---
...x-deprecation-on-collections.Mutable.patch | 52 +++++++++++++++++++
.../recipes-cgl/crmsh/crmsh_4.3.1.bb | 1 +
2 files changed, 53 insertions(+)
create mode 100644 meta-cgl-common/recipes-cgl/crmsh/crmsh/0001-orderedset.py-fix-deprecation-on-collections.Mutable.patch

diff --git a/meta-cgl-common/recipes-cgl/crmsh/crmsh/0001-orderedset.py-fix-deprecation-on-collections.Mutable.patch b/meta-cgl-common/recipes-cgl/crmsh/crmsh/0001-orderedset.py-fix-deprecation-on-collections.Mutable.patch
new file mode 100644
index 0000000..62db8e8
--- /dev/null
+++ b/meta-cgl-common/recipes-cgl/crmsh/crmsh/0001-orderedset.py-fix-deprecation-on-collections.Mutable.patch
@@ -0,0 +1,52 @@
+From c1356d64086d2e3f9d113f346a14e6dff1c2acb0 Mon Sep 17 00:00:00 2001
+From: Yi Zhao <yi.zhao@...>
+Date: Tue, 26 Oct 2021 14:01:09 +0800
+Subject: [PATCH] orderedset.py: fix deprecation on collections.MutableSet
+
+Python 3.10 removes the deprecated aliases to collections abstract
+base clases [1]. Using 'collections.abc.MutableSet' instead of
+'collections.MutableSet'
+
+[1]: https://bugs.python.org/issue37324
+
+Fixes:
+$ crm
+Traceback (most recent call last):
+ File "/usr/bin/crm", line 29, in <module>
+ from crmsh import main
+ File "/usr/lib64/python3.10/site-packages/crmsh/main.py", line 18, in <module>
+ from . import ui_root
+ File "/usr/lib64/python3.10/site-packages/crmsh/ui_root.py", line 23, in <module>
+ from . import ui_cib
+ File "/usr/lib64/python3.10/site-packages/crmsh/ui_cib.py", line 16, in <module>
+ from .cibconfig import cib_factory
+ File "/usr/lib64/python3.10/site-packages/crmsh/cibconfig.py", line 23, in <module>
+ from . import orderedset
+ File "/usr/lib64/python3.10/site-packages/crmsh/orderedset.py", line 29, in <module>
+ class OrderedSet(collections.MutableSet):
+AttributeError: module 'collections' has no attribute 'MutableSet'
+
+Upstream-Status: Submitted
+[https://github.com/ClusterLabs/crmsh/pull/882]
+
+Signed-off-by: Yi Zhao <yi.zhao@...>
+---
+ crmsh/orderedset.py | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/crmsh/orderedset.py b/crmsh/orderedset.py
+index 21ec480c..27233289 100644
+--- a/crmsh/orderedset.py
++++ b/crmsh/orderedset.py
+@@ -26,7 +26,7 @@ import collections
+ KEY, PREV, NEXT = list(range(3))
+
+
+-class OrderedSet(collections.MutableSet):
++class OrderedSet(collections.abc.MutableSet):
+
+ def __init__(self, iterable=None):
+ self.end = end = []
+--
+2.25.1
+
diff --git a/meta-cgl-common/recipes-cgl/crmsh/crmsh_4.3.1.bb b/meta-cgl-common/recipes-cgl/crmsh/crmsh_4.3.1.bb
index 75e720b..0b6ecd3 100644
--- a/meta-cgl-common/recipes-cgl/crmsh/crmsh_4.3.1.bb
+++ b/meta-cgl-common/recipes-cgl/crmsh/crmsh_4.3.1.bb
@@ -15,6 +15,7 @@ RDEPENDS:${PN} = "pacemaker python3-lxml python3-parallax gawk bash python3-doct
S = "${WORKDIR}/git"
SRC_URI = "git://github.com/ClusterLabs/${BPN}.git \
file://tweaks_for_build.patch \
+ file://0001-orderedset.py-fix-deprecation-on-collections.Mutable.patch \
"
SRCREV = "00ec69054edecd068deda54c6184c0385d90ebd2"

2621 - 2640 of 57773