Hi Amahnui,

On April 26, 2022 5:49:38 PM GMT+02:00, Abongwa Amahnui Bonalais <abongwabonalais@...> wrote:

Hi Quentin,
Thanks for the review.

I tried using regex to look for all the folders prefixed by 3.1. but it is currently not working, But I am still working on a fix for it.

No need for a regex, just check the root string starts with "./3.1", that's enough.

I noticed that the banner was already on the dunfell excluding 3.1.15, so should I hardcode from 3.1 to 3.1.14 while looking for way to make the regex method work?

Your script will only run on the old docs which stops at 3.1.4. There are no other directories. You can check by yourself in the docbook tarball and/or by exiting the run-docs-build script right after calling your script. Therefore, there's really nothing fancy in handling 3.1 except having a different message than for <3.1 releases.

Cheers,
Quentin