Re: [meta-rockchip][PATCH] kernel: linux-yocto: fix broken Ethernet MAC controller on RK3399 on 5.14 >= version <= 5.14.11


Khem Raj
 



On Tue, Nov 16, 2021 at 9:12 AM Quentin Schulz <quentin.schulz@...> wrote:
On Tue, Nov 16, 2021 at 09:08:41AM -0800, Khem Raj wrote:
> On Tue, Nov 16, 2021 at 9:04 AM Quentin Schulz
> <quentin.schulz@...> wrote:
> >
> > On Tue, Nov 16, 2021 at 09:00:42AM -0800, Khem Raj wrote:
> > > On Tue, Nov 16, 2021 at 7:52 AM Quentin Schulz
> > > <quentin.schulz@...> wrote:
> > > >
> > > > From Linux kernel v5.14 to v5.14.11 (both included), the Ethernet MAC
> > > > controller found on RK3399 is not working.
> > > >
> > > > A fix is available in v5.14.12 and later (available also in v5.15)
> > > > which is provided here and applied to linux-yocto source tree if
> > > > linux-yocto version is of the impacted ones.
> > > >
> > > > The conditional patching is unfortunately required because Honister 3.4
> > > > has linux-yocto v5.14.9 and Honister 3.4.1 will have at least
> > > > linux-yocto v5.14.14.
> > >
> > > Patching piece below looks quite a bit.
> > > lets just fix v5.14.14 and dont worry about 3.4
> > >
> >
> > v5.14.14 is already fixed. The only release currently is 3.4 and I hit
> > that issue, hence the patch.
> > I assume not everybody is updating to 3.4.1 when it's out, I've seen
> > people running behind dot releases.
> > What's bothering you?
>
> once dot release is out then thats whats maintained not the original
> release since they are incremental.
> the anon python to apply a patch. Can you explain why we want to patch
> applied this way ?
>

I could define a python function and use it like this:
SRC_URI:append:rk3399 = "${@rk3399_fix_mac(d)}"

Would that work better for you?

I am not yet convinced why should we have such version specific patch 


Cheers,
Quentin

Join yocto@lists.yoctoproject.org to automatically receive all group messages.