Re: [YOCTO#13529][prelink-cross v3] Add SPDX license headers to all source files


Meh Mbeh Ida Delphine
 

Got it, thanks! 

On Fri, Oct 9, 2020 at 3:59 AM Tim Orling <ticotimo@...> wrote:
Thank you so much for the revision.

I was not clear enough in what I said earlier and we had not captured it in the wiki either. Richard and I have updated the wiki.

What I was thinking, but did not clearly say is:

You should use "Add SPDX license headers to all source files" as the git shortlog (the first line of the text you type in when you do git commit -s). I believe you did this already.

Second, the [YOCTO #13529] tag goes into the git commit message itself, not the subject line of  send-email. I did not explain that well.

So here is explicitly what is the best practice:

$ git commit -s (or at this point $ git commit --amend)
In the editor enter:

Add SPDX license headers to all source files

Added SPDX headers in all source files except src/makecrc.c since it is not copyrighted.
Skipped Makefile.am as well.
Also cleared redundant license text.

Fixes: [YOCTO #13529]

Signed-off-by: Meh Mbeh Ida Delphine <idadelm@...>


Then send the patch:

$ git send-email --to=yocto@... --subject-prefix="prelink-cross][PATCH v4" --cc mark.hatle@... -M -1 --annotate

NOTE: the repository has two errors in the README (which you could optionally fix in v4).
(1) Mark Hatle is no longer at Wind River so the email needs to change
(2) The Yocto Project mailing list URL has changed to "yocto@..."

The -M part makes the email be formatted properly with regard to whitespace so it can be merged cleanly. The -1 part means "one commit". So if your contribution is 3 patches, it would be -3. The --annotate part of that command line will drop you into an editor. Since this is a revision of a prior patch, we want to add the changes underneath the --- This makes it easy to review, but does not put transient, ephemeral text into the permanent git history:

Add SPDX license headers to all source files

Added SPDX headers in all source files except src/makecrc.c since it is not copyrighted.
Skipped Makefile.am as well.
Also cleared redundant license text.

Fixes: [YOCTO #13529]

Signed-off-by: Meh Mbeh Ida Delphine <idadelm@...>
---
Changes in V4:
  * Add [YOCTO #13529] tag to git commit log instead of subject line

Changes in V3:
  * Address review comments
  * Change subject line to reflect what the patch is trying to do

Changes in V2:

 src/arch-alpha.c   | 15 ++-------------

<snip>



On Thu, Oct 8, 2020 at 11:23 AM Meh Mbeh Ida Delphine <idadelm@...> wrote:
Fixed bug #13529
Added SPDX headers in all source files except src/makecrc.c since it is not copyrighted.
Skipped Makefile.am as well.
Also cleared redundant license text.

Signed-off-by: Meh Mbeh Ida Delphine <idadelm@...>
---

Join yocto@lists.yoctoproject.org to automatically receive all group messages.