On 6/24/20 10:44 PM, Trevor Woerner wrote:On Wed 2020-06-24 @ 11:30:57 PM, Trevor Woerner wrote:On Fri 2020-06-12 @ 12:38:23 PM, Joshua Watt wrote:diff --git a/recipes-bsp/u-boot/u-boot%.bbappend b/recipes-bsp/u-boot/u-boot%.bbappendindex 401d649..042507d 100644--- a/recipes-bsp/u-boot/u-boot%.bbappend+++ b/recipes-bsp/u-boot/u-boot%.bbappend@@ -7,8 +7,8 @@ do_compile_append_rock2-square () { ATF_DEPENDS ??= ""-EXTRA_OEMAKE_append_rk3399 = " BL31=${DEPLOY_DIR_IMAGE}/bl31.elf"-ATF_DEPENDS_rk3399 = "virtual/atf:do_deploy"+EXTRA_OEMAKE_append_rk3399 = " BL31=${DEPLOY_DIR_IMAGE}/bl31-rk3399.elf"The space you've included at the start of the following string makes me stopand double-check... did you mean to add an "_append" in the following symbol?+ATF_DEPENDS_rk3399 = " virtual/trusted-firmware-a:do_deploy"Ah… I should have read the next line before replying. I see you switched from+= to .= and hence the space. A bit curious, though?It prevents the recipe adding in an extra space to the task depends when themachine is not an rk3399, which helps the layer by YP 2.0 compatible
On Wed 2020-06-24 @ 11:30:57 PM, Trevor Woerner wrote:On Fri 2020-06-12 @ 12:38:23 PM, Joshua Watt wrote:diff --git a/recipes-bsp/u-boot/u-boot%.bbappend b/recipes-bsp/u-boot/u-boot%.bbappendindex 401d649..042507d 100644--- a/recipes-bsp/u-boot/u-boot%.bbappend+++ b/recipes-bsp/u-boot/u-boot%.bbappend@@ -7,8 +7,8 @@ do_compile_append_rock2-square () { ATF_DEPENDS ??= ""-EXTRA_OEMAKE_append_rk3399 = " BL31=${DEPLOY_DIR_IMAGE}/bl31.elf"-ATF_DEPENDS_rk3399 = "virtual/atf:do_deploy"+EXTRA_OEMAKE_append_rk3399 = " BL31=${DEPLOY_DIR_IMAGE}/bl31-rk3399.elf"The space you've included at the start of the following string makes me stopand double-check... did you mean to add an "_append" in the following symbol?+ATF_DEPENDS_rk3399 = " virtual/trusted-firmware-a:do_deploy"Ah… I should have read the next line before replying. I see you switched from+= to .= and hence the space. A bit curious, though?
On Fri 2020-06-12 @ 12:38:23 PM, Joshua Watt wrote:diff --git a/recipes-bsp/u-boot/u-boot%.bbappend b/recipes-bsp/u-boot/u-boot%.bbappendindex 401d649..042507d 100644--- a/recipes-bsp/u-boot/u-boot%.bbappend+++ b/recipes-bsp/u-boot/u-boot%.bbappend@@ -7,8 +7,8 @@ do_compile_append_rock2-square () { ATF_DEPENDS ??= ""-EXTRA_OEMAKE_append_rk3399 = " BL31=${DEPLOY_DIR_IMAGE}/bl31.elf"-ATF_DEPENDS_rk3399 = "virtual/atf:do_deploy"+EXTRA_OEMAKE_append_rk3399 = " BL31=${DEPLOY_DIR_IMAGE}/bl31-rk3399.elf"The space you've included at the start of the following string makes me stopand double-check... did you mean to add an "_append" in the following symbol?+ATF_DEPENDS_rk3399 = " virtual/trusted-firmware-a:do_deploy"
diff --git a/recipes-bsp/u-boot/u-boot%.bbappend b/recipes-bsp/u-boot/u-boot%.bbappendindex 401d649..042507d 100644--- a/recipes-bsp/u-boot/u-boot%.bbappend+++ b/recipes-bsp/u-boot/u-boot%.bbappend@@ -7,8 +7,8 @@ do_compile_append_rock2-square () { ATF_DEPENDS ??= ""-EXTRA_OEMAKE_append_rk3399 = " BL31=${DEPLOY_DIR_IMAGE}/bl31.elf"-ATF_DEPENDS_rk3399 = "virtual/atf:do_deploy"+EXTRA_OEMAKE_append_rk3399 = " BL31=${DEPLOY_DIR_IMAGE}/bl31-rk3399.elf"
+ATF_DEPENDS_rk3399 = " virtual/trusted-firmware-a:do_deploy"
© 2021 Groups.io