On Fri, Apr 05, 2019 at 07:59:41AM +0100, email@example.com wrote:
On Fri, 2019-04-05 at 06:54 +0000, Mikko.Rapeli@bmw.de wrote:
On Fri, Apr 05, 2019 at 07:46:00AM +0100, The original patch in this thread from Alex needs stdbuf which would
On Fri, 2019-04-05 at 06:16 +0000, Mikko.Rapeli@bmw.de wrote:GNU sed does not come from coreutils but from sed recipe.
On Thu, Apr 04, 2019 at 10:48:17PM +0100, Richard Purdie wrote:The other alternative option being proposed is for ptest-runner to
On Thu, 2019-04-04 at 18:00 +0200, Alexander Kanavin wrote:Please no. I'm running images without sed and using busybox sed
As ptest-runner communicates with child processes viaI'm a little torn on this. I noticed some of the run-ptest
the corresponding channels are not attached to a pty. In that
situation stdio facilities like printf() or fwrite() are
buffered. If a ptest would use them, without bothering
to fflush() the output, ptest-runner will only receive what
was written by the child ptest process after a buffer gets
If the unit tests are proceeding slowly, this may mean that
ptest-runner will erroneously timeout due to an apparent lack
'signs of life' from the child process.
stdbuf utility from coreutils adjusts the buffering to a
one, and so ptest-runner will get the lines as soon as they
Signed-off-by: Alexander Kanavin <firstname.lastname@example.org>
utils.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
"| sed -u" whilst the one you were seeing problems with uses "|
We may want to consider strongly recommending -u. I'm testing a
with some tweaks like that in it...
instead, and that
doesn't support -u. I'd rather be compatible with sed from
to images minimal (e.g. install of additional packages) before
depend on coreutils which is worse?
Your call in the end. I just provided my point of view.
add a coreutils depends to ptest-runner for everything as I understand
Ok, that too then. Then all hope is lost so lets include sed there as well :)
Patches would be welcome to help clean up some of these scripts. I feel
I did test the -u option to sed in the openssh ptest runner and itUnderstood. I hope you could also add 'set -eux' to all ptest shell
fix the problems we've been seeing.
I'm open to other alternatives but the -u option to sed is looking
the best one we have right now. These bugs are making our testing
ptests effectively useless and unpredictable so this is a serious
scripts. Many of them seem to be missing shell script error handling
and failures like providing -u to busybox sed may go unnoticed.
like I'm fighting a lonely battle trying to get any of this to work at
We're ramping up with ptests and will provide fixes back to upstream.
The good news is the automated monitoring of the ptest results should
catch problems like that as if a chunk of ptests "disappear", the new
testing should quickly highlight that.
(We should improve the scripts, we just also have another way to spot
All this work is very much appreciated here in downstream! Thanks you very much!