On Wed, 2011-08-24 at 14:33 -0400, Bruce Ashfield wrote:
On 11-08-24 04:48 AM, Liming Wang wrote:
This patch is just a workaround to speed up boot time of qemuppc, because qemuppc has no framebuffer support, no need to start X server for qemuppc.
Richard suggested to fix the X scripts so that if an fbdev X server is in use and the framebuffer device node does not exist, it just exits cleanly with a suitable message and doesn't timeout on boot.
But I think it needs more time to implement and test.
X scripts serve for all the boards. And we also can't assume all the boards use the same framebuffer device. So how to detect whether the framebuffer device exists is board dependent. Maybe we can see whether the device /dev/fb0 exists(it could be created manually, so we should try to open it to verify) or the file /proc/fb exists to confirm the framebuffer device. Anyway, any modification should be tested on all boards to see whether it works. I prefer to mark it as todo task in 1.1
We need to cc Richard/Saul on this, so they can re-consider and merge this as appropriate. But for me, I'm acking this change.
I've reluctantly merged this but I consider this a bit of a cop-out :(