Re: [PATCH 1/1] RTC: Ensure msecure is mux'd to be able to set RTC


Liming Wang <liming.wang@...>
 

On 2011-6-16 21:20, Bruce Ashfield wrote:
On 06/16/11 02:13, Liming Wang wrote:
On 2011-6-16 14:07, Jingdong Lu wrote:
From: Jingdong Lu<jingdong.lu@...>

commit e2a346a2a054f702fd76f328ff747b9ad9264a4c from
git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-2.6.git
It's fine if you break this line into two lines.
arm: omap3: beagle: Ensure msecure is mux'd to be able to set the RTC.
"Msecure" signal provides for protection of the RTC register in
TPS65950 be
disabling that function via a control signal from the OMAP3530. So ensure
msecure is mux'd to be able to set the RTC.

Tested with a BeagleBoard C4.
Fixes bug [YOCTO #767]
I think it's best to put your comment in the top line.
And we don't want the bug tracking information directly
in the kernel commits, it just ends up cluttering things.

It's fine to include this in the 0/N email, but not in
the commit message itself.
Yes, I agree.
Jingdong should generate a new patch by cherry-pick or format-patch.

Liming Wang

Cheers,

Bruce


Liming Wang
Signed-off-by: Alexander Holler<holler@...>
Signed-off-by: Tony Lindgren<tony@...>
Integrated-by: Jingdong Lu<jingdong.lu@...>
---
arch/arm/mach-omap2/board-omap3beagle.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-omap2/board-omap3beagle.c
b/arch/arm/mach-omap2/board-omap3beagle.c
index af1166b..925c0b3 100644
--- a/arch/arm/mach-omap2/board-omap3beagle.c
+++ b/arch/arm/mach-omap2/board-omap3beagle.c
@@ -580,6 +580,9 @@ static void __init omap3_beagle_init(void)
usb_ehci_init(&ehci_pdata);
omap3beagle_flash_init();

+ /* Ensure msecure is mux'd to be able to set the RTC. */
+ omap_mux_init_signal("sys_drm_msecure", OMAP_PIN_OFF_OUTPUT_HIGH);
+
/* Ensure SDRC pins are mux'd for self-refresh */
omap_mux_init_signal("sdrc_cke0", OMAP_PIN_OUTPUT);
omap_mux_init_signal("sdrc_cke1", OMAP_PIN_OUTPUT);
_______________________________________________
yocto mailing list
yocto@...
https://lists.yoctoproject.org/listinfo/yocto

Join yocto@lists.yoctoproject.org to automatically receive all group messages.