Re: Last minute changes - Review Request
Saul G. Wold <sgw@...>
On 10/22/2010 09:32 AM, Stewart, David C wrote:
For the Future: Besides doing a basic build, we need to have some real unit tests for bitbake and the poky infrastructure, I guess I need to turn this into a Testing feature request for 1.0 (look for it soon).From: yocto-bounces@... [mailto:yocto-
After reviewing the changes I agree, don't get me wrong, I am still very nervous about these changes.b) They fix important bugs that the user can easily run into
Some times we over look the obvious changes, been caught by that myself too many time.c) The changes are small, well documented and are obviously correct
<SNIP>d) The don't change the generated images.
If there was 1 or 2 changes, I would be much happier, but there are almost a dozen changes, yes mostly individually they are OK, I am still reviewing them all, and have not started any testing with them yet.I'm not happy about being in this position and I know Dave will be veryI'm so predictable... :-) Yes, I'm nervous. I looked at all of the patches and with the exception of one or two, they mostly seem like good ones. I will accept these if Josh/Mark/Saul give us a +1 on their review& testing.
I agree with Dave that there are a couple that I am more nervous about the pseudo/fakeroot as we have had so much trouble in the past, yes I know this will make things better, but what else will crop up?