Re: [OE-core] [PATCH 01/17] connman-conf: ignore eth0 in qemu in a way that is not sysvinit-specific


Richard Purdie
 

On Fri, 2022-04-08 at 12:55 +0200, Jan-Simon Moeller wrote:
If that fixes a lot of intermittent issues - of course.

Just thinking loud:
What about making main.conf's 'Blacklist' changeable by a config
variable we can set ?
Autobuilder could have this as 'eth0' , we could ignore a different
interface easily then (or none).
Not sure if eth0 should be in the list by default for everyone ?

E.g. we set
meta-agl/meta-agl-core/recipes-connectivity/connman/files/main.conf:NetworkInterfaceBlacklist=vmnet,vboxnet,virbr,ifb,meth

In one case we grep or sed ...
meta-agl-demo/recipes-config/cluster-demo-network-config/files/cluster-demo-network-conf.sh:if
! grep '^NetworkInterfaceBlacklist=' ${CONNMAN_CONF} | grep -q $1;
then
meta-agl-demo/recipes-config/cluster-demo-network-config/files/cluster-demo-network-conf.sh:
sed -i "s/^\(NetworkInterfaceBlacklist=.*\)/\1,$1/" ${CONNMAN_CONF}
meta-agl-demo/recipes-connectivity/connman/connman_agldemo.inc:
sed -i 's/^\(NetworkInterfaceBlacklist=.*\)/\1,eth1/'
${D}${sysconfdir}/connman/main.conf

@Scott, whats your take ?
The AGL file[1] appears to have another entry in it for FallbackTimeservers. It
is also complicated by oe-core only doing this for qemu* machines. I'm not sure
a single variable is going to work well.

It may be easier for AGL to change to tweaking connman-conf and then you can
just override the OE-Core file?

[1]
https://git.automotivelinux.org/AGL/meta-agl/tree/meta-agl-core/recipes-connectivity/connman/files/main.conf?h=next

Cheers,

Richard

Join swat@lists.yoctoproject.org to automatically receive all group messages.