[PATCH] xen: Add missing space in append to IMAGE_INSTALL


Bertrand Marquis
 

Add a space before doing an append in IMAGE_INSTALL on x86.
This is solving issues happening if someone is using IMAGE_INSTALL in
local.conf to add things to the generated image.

Signed-off-by: Bertrand Marquis <bertrand.marquis@...>
---
recipes-extended/images/xen-image-minimal.bb | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/recipes-extended/images/xen-image-minimal.bb b/recipes-exten=
ded/images/xen-image-minimal.bb
index f6fa5ed..3cf4230 100644
--- a/recipes-extended/images/xen-image-minimal.bb
+++ b/recipes-extended/images/xen-image-minimal.bb
@@ -21,8 +21,8 @@ IMAGE_INSTALL +=3D " \
do_build[depends] +=3D "xen:do_deploy"
=20
# Networking for HVM-mode guests (x86/64 only) requires the tun kernel m=
odule
-IMAGE_INSTALL:append:x86 =3D "kernel-module-tun"
-IMAGE_INSTALL:append:x86-64 =3D "kernel-module-tun"
+IMAGE_INSTALL:append:x86 =3D " kernel-module-tun"
+IMAGE_INSTALL:append:x86-64 =3D " kernel-module-tun"
=20
# Linux kernel option CONFIG_XEN_PCIDEV_BACKEND depends on X86
XEN_PCIBACK_MODULE =3D ""
--=20
2.25.1


Christopher Clark
 

On Fri, Apr 22, 2022 at 9:19 AM Bertrand Marquis
<bertrand.marquis@...> wrote:

Add a space before doing an append in IMAGE_INSTALL on x86.
This is solving issues happening if someone is using IMAGE_INSTALL in
local.conf to add things to the generated image.
Thanks, Bertrand.

Signed-off-by: Bertrand Marquis <bertrand.marquis@...>
Reviewed-by: Christopher Clark <christopher.w.clark@...>

Christopher

---
recipes-extended/images/xen-image-minimal.bb | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/recipes-extended/images/xen-image-minimal.bb b/recipes-extended/images/xen-image-minimal.bb
index f6fa5ed..3cf4230 100644
--- a/recipes-extended/images/xen-image-minimal.bb
+++ b/recipes-extended/images/xen-image-minimal.bb
@@ -21,8 +21,8 @@ IMAGE_INSTALL += " \
do_build[depends] += "xen:do_deploy"

# Networking for HVM-mode guests (x86/64 only) requires the tun kernel module
-IMAGE_INSTALL:append:x86 = "kernel-module-tun"
-IMAGE_INSTALL:append:x86-64 = "kernel-module-tun"
+IMAGE_INSTALL:append:x86 = " kernel-module-tun"
+IMAGE_INSTALL:append:x86-64 = " kernel-module-tun"

# Linux kernel option CONFIG_XEN_PCIDEV_BACKEND depends on X86
XEN_PCIBACK_MODULE = ""
--
2.25.1




Bruce Ashfield
 

merged.

Bruce

In message: [meta-virtualization] [PATCH] xen: Add missing space in append to IMAGE_INSTALL
on 22/04/2022 Bertrand Marquis wrote:

Add a space before doing an append in IMAGE_INSTALL on x86.
This is solving issues happening if someone is using IMAGE_INSTALL in
local.conf to add things to the generated image.

Signed-off-by: Bertrand Marquis <bertrand.marquis@...>
---
recipes-extended/images/xen-image-minimal.bb | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/recipes-extended/images/xen-image-minimal.bb b/recipes-extended/images/xen-image-minimal.bb
index f6fa5ed..3cf4230 100644
--- a/recipes-extended/images/xen-image-minimal.bb
+++ b/recipes-extended/images/xen-image-minimal.bb
@@ -21,8 +21,8 @@ IMAGE_INSTALL += " \
do_build[depends] += "xen:do_deploy"

# Networking for HVM-mode guests (x86/64 only) requires the tun kernel module
-IMAGE_INSTALL:append:x86 = "kernel-module-tun"
-IMAGE_INSTALL:append:x86-64 = "kernel-module-tun"
+IMAGE_INSTALL:append:x86 = " kernel-module-tun"
+IMAGE_INSTALL:append:x86-64 = " kernel-module-tun"

# Linux kernel option CONFIG_XEN_PCIDEV_BACKEND depends on X86
XEN_PCIBACK_MODULE = ""
--
2.25.1