[PATCH v2 0/3] Xen: improve Qemu integration


Christopher Clark
 

A series of improvements to Qemu integration with the Xen recipes:

- update the Qemu package dependency for the x86 Xen tools
- add support for testing Arm 32-bit images with Qemu and testimage
- configure a standard Xen bridged network xenbr0 for Xen images in qemu
to improve support for configuring guest virtual machine networking

v2 coalesces these patches into a series and addresses feedback on v1

Christopher Clark (3):
xen, xen-tools: add recommendation for Qemu for non-hvm x86
qemuboot, xen-image-minimal: enable runqemu for qemuarm Xen images
xen images, qemuboot: configure xenbr0 bridge for runqemu, testimage

classes/qemuboot-testimage-network.bbclass | 36 +++++-
classes/qemuboot-xen-defaults.bbclass | 26 +++-
classes/qemuboot-xen-u-boot.bbclass | 128 +++++++++++++++++++
conf/distro/include/meta-virt-xen.inc | 1 +
recipes-extended/images/xen-image-minimal.bb | 8 +-
recipes-extended/xen/xen-tools.inc | 9 +-
recipes-extended/xen/xen.inc | 6 +-
7 files changed, 197 insertions(+), 17 deletions(-)
create mode 100644 classes/qemuboot-xen-u-boot.bbclass

--
2.25.1


Bertrand Marquis
 

Hi Christopher,

On 28 Apr 2022, at 01:06, Christopher Clark via lists.yoctoproject.org <christopher.w.clark=gmail.com@...> wrote:

A series of improvements to Qemu integration with the Xen recipes:

- update the Qemu package dependency for the x86 Xen tools
- add support for testing Arm 32-bit images with Qemu and testimage
- configure a standard Xen bridged network xenbr0 for Xen images in qemu
to improve support for configuring guest virtual machine networking

v2 coalesces these patches into a series and addresses feedback on v1
Thanks a lot for that.
I will test and review those in the next days :-)

Cheers
Bertrand


Christopher Clark (3):
xen, xen-tools: add recommendation for Qemu for non-hvm x86
qemuboot, xen-image-minimal: enable runqemu for qemuarm Xen images
xen images, qemuboot: configure xenbr0 bridge for runqemu, testimage

classes/qemuboot-testimage-network.bbclass | 36 +++++-
classes/qemuboot-xen-defaults.bbclass | 26 +++-
classes/qemuboot-xen-u-boot.bbclass | 128 +++++++++++++++++++
conf/distro/include/meta-virt-xen.inc | 1 +
recipes-extended/images/xen-image-minimal.bb | 8 +-
recipes-extended/xen/xen-tools.inc | 9 +-
recipes-extended/xen/xen.inc | 6 +-
7 files changed, 197 insertions(+), 17 deletions(-)
create mode 100644 classes/qemuboot-xen-u-boot.bbclass

--
2.25.1



IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.


Bruce Ashfield
 

On Wed, Apr 27, 2022 at 8:06 PM Christopher Clark
<christopher.w.clark@...> wrote:

A series of improvements to Qemu integration with the Xen recipes:

- update the Qemu package dependency for the x86 Xen tools
- add support for testing Arm 32-bit images with Qemu and testimage
- configure a standard Xen bridged network xenbr0 for Xen images in qemu
to improve support for configuring guest virtual machine networking

v2 coalesces these patches into a series and addresses feedback on v1
I've gone ahead and merged all three patches of the v2 series.

As for the qemuarm boot (with uboot or not), we can address that in
follow up patches, since I see that Betrand did send what he's been
using to the list. And I'm interested to hear if that also works for
Christopher.

Bruce



Christopher Clark (3):
xen, xen-tools: add recommendation for Qemu for non-hvm x86
qemuboot, xen-image-minimal: enable runqemu for qemuarm Xen images
xen images, qemuboot: configure xenbr0 bridge for runqemu, testimage

classes/qemuboot-testimage-network.bbclass | 36 +++++-
classes/qemuboot-xen-defaults.bbclass | 26 +++-
classes/qemuboot-xen-u-boot.bbclass | 128 +++++++++++++++++++
conf/distro/include/meta-virt-xen.inc | 1 +
recipes-extended/images/xen-image-minimal.bb | 8 +-
recipes-extended/xen/xen-tools.inc | 9 +-
recipes-extended/xen/xen.inc | 6 +-
7 files changed, 197 insertions(+), 17 deletions(-)
create mode 100644 classes/qemuboot-xen-u-boot.bbclass

--
2.25.1

--
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II


Bertrand Marquis
 

Hi Bruce,

On 9 May 2022, at 13:47, Bruce Ashfield via lists.yoctoproject.org <bruce.ashfield=gmail.com@...> wrote:

On Wed, Apr 27, 2022 at 8:06 PM Christopher Clark
<christopher.w.clark@...> wrote:

A series of improvements to Qemu integration with the Xen recipes:

- update the Qemu package dependency for the x86 Xen tools
- add support for testing Arm 32-bit images with Qemu and testimage
- configure a standard Xen bridged network xenbr0 for Xen images in qemu
to improve support for configuring guest virtual machine networking

v2 coalesces these patches into a series and addresses feedback on v1
I've gone ahead and merged all three patches of the v2 series.

As for the qemuarm boot (with uboot or not), we can address that in
follow up patches, since I see that Betrand did send what he's been
using to the list. And I'm interested to hear if that also works for
Christopher.
My review on the second patches was mentioning that it does not work on my side so why merging that one ?

I will try to test this to check if init issues are solved and come back to you

Cheers
Bertrand



Bruce



Christopher Clark (3):
xen, xen-tools: add recommendation for Qemu for non-hvm x86
qemuboot, xen-image-minimal: enable runqemu for qemuarm Xen images
xen images, qemuboot: configure xenbr0 bridge for runqemu, testimage

classes/qemuboot-testimage-network.bbclass | 36 +++++-
classes/qemuboot-xen-defaults.bbclass | 26 +++-
classes/qemuboot-xen-u-boot.bbclass | 128 +++++++++++++++++++
conf/distro/include/meta-virt-xen.inc | 1 +
recipes-extended/images/xen-image-minimal.bb | 8 +-
recipes-extended/xen/xen-tools.inc | 9 +-
recipes-extended/xen/xen.inc | 6 +-
7 files changed, 197 insertions(+), 17 deletions(-)
create mode 100644 classes/qemuboot-xen-u-boot.bbclass

--
2.25.1

--
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.


Bruce Ashfield
 

On Mon, May 9, 2022 at 9:01 AM Bertrand Marquis
<Bertrand.Marquis@...> wrote:

Hi Bruce,

On 9 May 2022, at 13:47, Bruce Ashfield via lists.yoctoproject.org <bruce.ashfield=gmail.com@...> wrote:

On Wed, Apr 27, 2022 at 8:06 PM Christopher Clark
<christopher.w.clark@...> wrote:

A series of improvements to Qemu integration with the Xen recipes:

- update the Qemu package dependency for the x86 Xen tools
- add support for testing Arm 32-bit images with Qemu and testimage
- configure a standard Xen bridged network xenbr0 for Xen images in qemu
to improve support for configuring guest virtual machine networking

v2 coalesces these patches into a series and addresses feedback on v1
I've gone ahead and merged all three patches of the v2 series.

As for the qemuarm boot (with uboot or not), we can address that in
follow up patches, since I see that Betrand did send what he's been
using to the list. And I'm interested to hear if that also works for
Christopher.
My review on the second patches was mentioning that it does not work on my side so why merging that one ?
It worked here, and obviously it works for Christopher. So at that
point, I wouldn't hold it out of the tree.

Bruce

I will try to test this to check if init issues are solved and come back to you

Cheers
Bertrand



Bruce



Christopher Clark (3):
xen, xen-tools: add recommendation for Qemu for non-hvm x86
qemuboot, xen-image-minimal: enable runqemu for qemuarm Xen images
xen images, qemuboot: configure xenbr0 bridge for runqemu, testimage

classes/qemuboot-testimage-network.bbclass | 36 +++++-
classes/qemuboot-xen-defaults.bbclass | 26 +++-
classes/qemuboot-xen-u-boot.bbclass | 128 +++++++++++++++++++
conf/distro/include/meta-virt-xen.inc | 1 +
recipes-extended/images/xen-image-minimal.bb | 8 +-
recipes-extended/xen/xen-tools.inc | 9 +-
recipes-extended/xen/xen.inc | 6 +-
7 files changed, 197 insertions(+), 17 deletions(-)
create mode 100644 classes/qemuboot-xen-u-boot.bbclass

--
2.25.1

--
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.


--
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II


Bertrand Marquis
 

On 9 May 2022, at 14:30, Bruce Ashfield via lists.yoctoproject.org <bruce.ashfield=gmail.com@...> wrote:

On Mon, May 9, 2022 at 9:01 AM Bertrand Marquis
<Bertrand.Marquis@...> wrote:

Hi Bruce,

On 9 May 2022, at 13:47, Bruce Ashfield via lists.yoctoproject.org <bruce.ashfield=gmail.com@...> wrote:

On Wed, Apr 27, 2022 at 8:06 PM Christopher Clark
<christopher.w.clark@...> wrote:

A series of improvements to Qemu integration with the Xen recipes:

- update the Qemu package dependency for the x86 Xen tools
- add support for testing Arm 32-bit images with Qemu and testimage
- configure a standard Xen bridged network xenbr0 for Xen images in qemu
to improve support for configuring guest virtual machine networking

v2 coalesces these patches into a series and addresses feedback on v1
I've gone ahead and merged all three patches of the v2 series.

As for the qemuarm boot (with uboot or not), we can address that in
follow up patches, since I see that Betrand did send what he's been
using to the list. And I'm interested to hear if that also works for
Christopher.
My review on the second patches was mentioning that it does not work on my side so why merging that one ?
It worked here, and obviously it works for Christopher. So at that
point, I wouldn't hold it out of the tree.
Could you at least explain me what I did wrong.

As said qemu is blocked waiting for a dhcp/tftp to answer in uboot.
Why do you guys have something starting a tftp server and I do not ?
Is it something that might happen to somebody else ?

Cheers
Bertrand


Bruce

I will try to test this to check if init issues are solved and come back to you

Cheers
Bertrand



Bruce



Christopher Clark (3):
xen, xen-tools: add recommendation for Qemu for non-hvm x86
qemuboot, xen-image-minimal: enable runqemu for qemuarm Xen images
xen images, qemuboot: configure xenbr0 bridge for runqemu, testimage

classes/qemuboot-testimage-network.bbclass | 36 +++++-
classes/qemuboot-xen-defaults.bbclass | 26 +++-
classes/qemuboot-xen-u-boot.bbclass | 128 +++++++++++++++++++
conf/distro/include/meta-virt-xen.inc | 1 +
recipes-extended/images/xen-image-minimal.bb | 8 +-
recipes-extended/xen/xen-tools.inc | 9 +-
recipes-extended/xen/xen.inc | 6 +-
7 files changed, 197 insertions(+), 17 deletions(-)
create mode 100644 classes/qemuboot-xen-u-boot.bbclass

--
2.25.1

--
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.


--
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.


Bertrand Marquis
 

Hi Bruce,

On 9 May 2022, at 13:47, Bruce Ashfield via lists.yoctoproject.org <bruce.ashfield=gmail.com@...> wrote:

On Wed, Apr 27, 2022 at 8:06 PM Christopher Clark
<christopher.w.clark@...> wrote:

A series of improvements to Qemu integration with the Xen recipes:

- update the Qemu package dependency for the x86 Xen tools
- add support for testing Arm 32-bit images with Qemu and testimage
- configure a standard Xen bridged network xenbr0 for Xen images in qemu
to improve support for configuring guest virtual machine networking

v2 coalesces these patches into a series and addresses feedback on v1
I've gone ahead and merged all three patches of the v2 series.

As for the qemuarm boot (with uboot or not), we can address that in
follow up patches, since I see that Betrand did send what he's been
using to the list. And I'm interested to hear if that also works for
Christopher.
Using current master status I can confirm that I have now dom0 booting properly on arm64.

I now have issues with the generated DTB (command line of dom0 is wrong so I have no kernel logs, just the prompt).
I am digging into this and will come back to you.

Cheers
Bertrand


Bruce



Christopher Clark (3):
xen, xen-tools: add recommendation for Qemu for non-hvm x86
qemuboot, xen-image-minimal: enable runqemu for qemuarm Xen images
xen images, qemuboot: configure xenbr0 bridge for runqemu, testimage

classes/qemuboot-testimage-network.bbclass | 36 +++++-
classes/qemuboot-xen-defaults.bbclass | 26 +++-
classes/qemuboot-xen-u-boot.bbclass | 128 +++++++++++++++++++
conf/distro/include/meta-virt-xen.inc | 1 +
recipes-extended/images/xen-image-minimal.bb | 8 +-
recipes-extended/xen/xen-tools.inc | 9 +-
recipes-extended/xen/xen.inc | 6 +-
7 files changed, 197 insertions(+), 17 deletions(-)
create mode 100644 classes/qemuboot-xen-u-boot.bbclass

--
2.25.1

--
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.


Bruce Ashfield
 

On Mon, May 9, 2022 at 9:58 AM Bertrand Marquis
<Bertrand.Marquis@...> wrote:



On 9 May 2022, at 14:30, Bruce Ashfield via lists.yoctoproject.org <bruce.ashfield=gmail.com@...> wrote:

On Mon, May 9, 2022 at 9:01 AM Bertrand Marquis
<Bertrand.Marquis@...> wrote:

Hi Bruce,

On 9 May 2022, at 13:47, Bruce Ashfield via lists.yoctoproject.org <bruce.ashfield=gmail.com@...> wrote:

On Wed, Apr 27, 2022 at 8:06 PM Christopher Clark
<christopher.w.clark@...> wrote:

A series of improvements to Qemu integration with the Xen recipes:

- update the Qemu package dependency for the x86 Xen tools
- add support for testing Arm 32-bit images with Qemu and testimage
- configure a standard Xen bridged network xenbr0 for Xen images in qemu
to improve support for configuring guest virtual machine networking

v2 coalesces these patches into a series and addresses feedback on v1
I've gone ahead and merged all three patches of the v2 series.

As for the qemuarm boot (with uboot or not), we can address that in
follow up patches, since I see that Betrand did send what he's been
using to the list. And I'm interested to hear if that also works for
Christopher.
My review on the second patches was mentioning that it does not work on my side so why merging that one ?
It worked here, and obviously it works for Christopher. So at that
point, I wouldn't hold it out of the tree.
Could you at least explain me what I did wrong.

As said qemu is blocked waiting for a dhcp/tftp to answer in uboot.
Why do you guys have something starting a tftp server and I do not ?
Is it something that might happen to somebody else ?
I used a setup that I have for kubernetes testing that does have a
bootp/dhcp server available, so that could be the difference. But it
is best to get Christopher's setup, as that is the reference he's
using in his maintainer cycles.

Note: I only merged this to master, not kirkstone. But without this
patch only patch 1/3 from Christopher went to kirkstone, so there is
possibly more work required there as well.

So we can debug the setup in master, and not worry about it hurting
the release, but if we don't get an answer from Christopher, or
otherwise get it working in the next few days, I'll revert in master
as well.

I didn't see any replies to your qemuarm patch, but I'm doing a rebase
to master, and will test to see if it can co-exist or just be the
default behaviour.

Bruce


Bruce



Cheers
Bertrand


Bruce

I will try to test this to check if init issues are solved and come back to you

Cheers
Bertrand



Bruce



Christopher Clark (3):
xen, xen-tools: add recommendation for Qemu for non-hvm x86
qemuboot, xen-image-minimal: enable runqemu for qemuarm Xen images
xen images, qemuboot: configure xenbr0 bridge for runqemu, testimage

classes/qemuboot-testimage-network.bbclass | 36 +++++-
classes/qemuboot-xen-defaults.bbclass | 26 +++-
classes/qemuboot-xen-u-boot.bbclass | 128 +++++++++++++++++++
conf/distro/include/meta-virt-xen.inc | 1 +
recipes-extended/images/xen-image-minimal.bb | 8 +-
recipes-extended/xen/xen-tools.inc | 9 +-
recipes-extended/xen/xen.inc | 6 +-
7 files changed, 197 insertions(+), 17 deletions(-)
create mode 100644 classes/qemuboot-xen-u-boot.bbclass

--
2.25.1

--
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.


--
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.


--
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II


Bertrand Marquis
 

Hi Bruce

On 9 May 2022, at 16:53, Bruce Ashfield <bruce.ashfield@...> wrote:

On Mon, May 9, 2022 at 9:58 AM Bertrand Marquis
<Bertrand.Marquis@...> wrote:



On 9 May 2022, at 14:30, Bruce Ashfield via lists.yoctoproject.org <bruce.ashfield=gmail.com@...> wrote:

On Mon, May 9, 2022 at 9:01 AM Bertrand Marquis
<Bertrand.Marquis@...> wrote:

Hi Bruce,

On 9 May 2022, at 13:47, Bruce Ashfield via lists.yoctoproject.org <bruce.ashfield=gmail.com@...> wrote:

On Wed, Apr 27, 2022 at 8:06 PM Christopher Clark
<christopher.w.clark@...> wrote:

A series of improvements to Qemu integration with the Xen recipes:

- update the Qemu package dependency for the x86 Xen tools
- add support for testing Arm 32-bit images with Qemu and testimage
- configure a standard Xen bridged network xenbr0 for Xen images in qemu
to improve support for configuring guest virtual machine networking

v2 coalesces these patches into a series and addresses feedback on v1
I've gone ahead and merged all three patches of the v2 series.

As for the qemuarm boot (with uboot or not), we can address that in
follow up patches, since I see that Betrand did send what he's been
using to the list. And I'm interested to hear if that also works for
Christopher.
My review on the second patches was mentioning that it does not work on my side so why merging that one ?
It worked here, and obviously it works for Christopher. So at that
point, I wouldn't hold it out of the tree.
Could you at least explain me what I did wrong.

As said qemu is blocked waiting for a dhcp/tftp to answer in uboot.
Why do you guys have something starting a tftp server and I do not ?
Is it something that might happen to somebody else ?
I used a setup that I have for kubernetes testing that does have a
bootp/dhcp server available, so that could be the difference. But it
is best to get Christopher's setup, as that is the reference he's
using in his maintainer cycles.
If there are some external dependencies, this would kind of odd to
have this as default if we can have something working out of the box.


Note: I only merged this to master, not kirkstone. But without this
patch only patch 1/3 from Christopher went to kirkstone, so there is
possibly more work required there as well.
Ok


So we can debug the setup in master, and not worry about it hurting
the release, but if we don't get an answer from Christopher, or
otherwise get it working in the next few days, I'll revert in master
as well.
I am debugging while kernel log and init log are not seen for dom0.
Dom0 bootargs are wrong and I am digging to find out why.


I didn't see any replies to your qemuarm patch, but I'm doing a rebase
to master, and will test to see if it can co-exist or just be the
default behaviour.
Yep it needs a proper review.

Cheers
Bertrand


Bruce


Bruce



Cheers
Bertrand


Bruce

I will try to test this to check if init issues are solved and come back to you

Cheers
Bertrand



Bruce



Christopher Clark (3):
xen, xen-tools: add recommendation for Qemu for non-hvm x86
qemuboot, xen-image-minimal: enable runqemu for qemuarm Xen images
xen images, qemuboot: configure xenbr0 bridge for runqemu, testimage

classes/qemuboot-testimage-network.bbclass | 36 +++++-
classes/qemuboot-xen-defaults.bbclass | 26 +++-
classes/qemuboot-xen-u-boot.bbclass | 128 +++++++++++++++++++
conf/distro/include/meta-virt-xen.inc | 1 +
recipes-extended/images/xen-image-minimal.bb | 8 +-
recipes-extended/xen/xen-tools.inc | 9 +-
recipes-extended/xen/xen.inc | 6 +-
7 files changed, 197 insertions(+), 17 deletions(-)
create mode 100644 classes/qemuboot-xen-u-boot.bbclass

--
2.25.1

--
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.


--
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.


--
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.


Christopher Clark
 

On Mon, May 9, 2022 at 8:53 AM Bruce Ashfield <bruce.ashfield@...> wrote:

On Mon, May 9, 2022 at 9:58 AM Bertrand Marquis
<Bertrand.Marquis@...> wrote:



On 9 May 2022, at 14:30, Bruce Ashfield via lists.yoctoproject.org <bruce.ashfield=gmail.com@...> wrote:

On Mon, May 9, 2022 at 9:01 AM Bertrand Marquis
<Bertrand.Marquis@...> wrote:

Hi Bruce,

On 9 May 2022, at 13:47, Bruce Ashfield via lists.yoctoproject.org <bruce.ashfield=gmail.com@...> wrote:

On Wed, Apr 27, 2022 at 8:06 PM Christopher Clark
<christopher.w.clark@...> wrote:

A series of improvements to Qemu integration with the Xen recipes:

- update the Qemu package dependency for the x86 Xen tools
- add support for testing Arm 32-bit images with Qemu and testimage
- configure a standard Xen bridged network xenbr0 for Xen images in qemu
to improve support for configuring guest virtual machine networking

v2 coalesces these patches into a series and addresses feedback on v1
I've gone ahead and merged all three patches of the v2 series.

As for the qemuarm boot (with uboot or not), we can address that in
follow up patches, since I see that Betrand did send what he's been
using to the list. And I'm interested to hear if that also works for
Christopher.
My review on the second patches was mentioning that it does not work on my side so why merging that one ?
It worked here, and obviously it works for Christopher. So at that
point, I wouldn't hold it out of the tree.
Could you at least explain me what I did wrong.

As said qemu is blocked waiting for a dhcp/tftp to answer in uboot.
Why do you guys have something starting a tftp server and I do not ?
Is it something that might happen to somebody else ?
I used a setup that I have for kubernetes testing that does have a
bootp/dhcp server available, so that could be the difference. But it
is best to get Christopher's setup, as that is the reference he's
using in his maintainer cycles.

Note: I only merged this to master, not kirkstone. But without this
patch only patch 1/3 from Christopher went to kirkstone, so there is
possibly more work required there as well.

So we can debug the setup in master, and not worry about it hurting
the release, but if we don't get an answer from Christopher, or
otherwise get it working in the next few days, I'll revert in master
as well.

I didn't see any replies to your qemuarm patch, but I'm doing a rebase
to master, and will test to see if it can co-exist or just be the
default behaviour.
Hello

Just to let you know that I am following this and making my way
through some testing. I am not sure what is causing the issues that
Bertrand is encountering but I would like to ensure that they are
resolved.

Christopher



Bruce


Bruce



Cheers
Bertrand


Bruce

I will try to test this to check if init issues are solved and come back to you

Cheers
Bertrand



Bruce



Christopher Clark (3):
xen, xen-tools: add recommendation for Qemu for non-hvm x86
qemuboot, xen-image-minimal: enable runqemu for qemuarm Xen images
xen images, qemuboot: configure xenbr0 bridge for runqemu, testimage

classes/qemuboot-testimage-network.bbclass | 36 +++++-
classes/qemuboot-xen-defaults.bbclass | 26 +++-
classes/qemuboot-xen-u-boot.bbclass | 128 +++++++++++++++++++
conf/distro/include/meta-virt-xen.inc | 1 +
recipes-extended/images/xen-image-minimal.bb | 8 +-
recipes-extended/xen/xen-tools.inc | 9 +-
recipes-extended/xen/xen.inc | 6 +-
7 files changed, 197 insertions(+), 17 deletions(-)
create mode 100644 classes/qemuboot-xen-u-boot.bbclass

--
2.25.1

--
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.


--
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.


--
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II


Bruce Ashfield
 

On Mon, May 9, 2022 at 11:57 AM Bertrand Marquis
<Bertrand.Marquis@...> wrote:

Hi Bruce

On 9 May 2022, at 16:53, Bruce Ashfield <bruce.ashfield@...> wrote:

On Mon, May 9, 2022 at 9:58 AM Bertrand Marquis
<Bertrand.Marquis@...> wrote:



On 9 May 2022, at 14:30, Bruce Ashfield via lists.yoctoproject.org <bruce.ashfield=gmail.com@...> wrote:

On Mon, May 9, 2022 at 9:01 AM Bertrand Marquis
<Bertrand.Marquis@...> wrote:

Hi Bruce,

On 9 May 2022, at 13:47, Bruce Ashfield via lists.yoctoproject.org <bruce.ashfield=gmail.com@...> wrote:

On Wed, Apr 27, 2022 at 8:06 PM Christopher Clark
<christopher.w.clark@...> wrote:

A series of improvements to Qemu integration with the Xen recipes:

- update the Qemu package dependency for the x86 Xen tools
- add support for testing Arm 32-bit images with Qemu and testimage
- configure a standard Xen bridged network xenbr0 for Xen images in qemu
to improve support for configuring guest virtual machine networking

v2 coalesces these patches into a series and addresses feedback on v1
I've gone ahead and merged all three patches of the v2 series.

As for the qemuarm boot (with uboot or not), we can address that in
follow up patches, since I see that Betrand did send what he's been
using to the list. And I'm interested to hear if that also works for
Christopher.
My review on the second patches was mentioning that it does not work on my side so why merging that one ?
It worked here, and obviously it works for Christopher. So at that
point, I wouldn't hold it out of the tree.
Could you at least explain me what I did wrong.

As said qemu is blocked waiting for a dhcp/tftp to answer in uboot.
Why do you guys have something starting a tftp server and I do not ?
Is it something that might happen to somebody else ?
I used a setup that I have for kubernetes testing that does have a
bootp/dhcp server available, so that could be the difference. But it
is best to get Christopher's setup, as that is the reference he's
using in his maintainer cycles.
If there are some external dependencies, this would kind of odd to
have this as default if we can have something working out of the box.


Note: I only merged this to master, not kirkstone. But without this
patch only patch 1/3 from Christopher went to kirkstone, so there is
possibly more work required there as well.
Ok


So we can debug the setup in master, and not worry about it hurting
the release, but if we don't get an answer from Christopher, or
otherwise get it working in the next few days, I'll revert in master
as well.
I am debugging while kernel log and init log are not seen for dom0.
Dom0 bootargs are wrong and I am digging to find out why.


I didn't see any replies to your qemuarm patch, but I'm doing a rebase
to master, and will test to see if it can co-exist or just be the
default behaviour.
Yep it needs a proper review.
And of course, I just tried a boot on a different builder and it failed.

So I went ahead and reverted the change, and left it as the old status
(which does boot for me).

We can revisit the two approaches from a clean slate.

Bruce


Cheers
Bertrand


Bruce


Bruce



Cheers
Bertrand


Bruce

I will try to test this to check if init issues are solved and come back to you

Cheers
Bertrand



Bruce



Christopher Clark (3):
xen, xen-tools: add recommendation for Qemu for non-hvm x86
qemuboot, xen-image-minimal: enable runqemu for qemuarm Xen images
xen images, qemuboot: configure xenbr0 bridge for runqemu, testimage

classes/qemuboot-testimage-network.bbclass | 36 +++++-
classes/qemuboot-xen-defaults.bbclass | 26 +++-
classes/qemuboot-xen-u-boot.bbclass | 128 +++++++++++++++++++
conf/distro/include/meta-virt-xen.inc | 1 +
recipes-extended/images/xen-image-minimal.bb | 8 +-
recipes-extended/xen/xen-tools.inc | 9 +-
recipes-extended/xen/xen.inc | 6 +-
7 files changed, 197 insertions(+), 17 deletions(-)
create mode 100644 classes/qemuboot-xen-u-boot.bbclass

--
2.25.1

--
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.


--
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.


--
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.


--
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II