[m-c-s][PATCH] concurrent-ruby: add explicit branch


kai
 

From: Kai Kang <kai.kang@...>

Add explicit branch master for concurrent-ruby as the same for other
recipes.

Signed-off-by: Kai Kang <kai.kang@...>
---
meta-openstack/recipes-devtools/ruby/concurrent-ruby_1.1.6.bb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta-openstack/recipes-devtools/ruby/concurrent-ruby_1.1.6.bb b/meta-openstack/recipes-devtools/ruby/concurrent-ruby_1.1.6.bb
index a328203e..61a2c598 100644
--- a/meta-openstack/recipes-devtools/ruby/concurrent-ruby_1.1.6.bb
+++ b/meta-openstack/recipes-devtools/ruby/concurrent-ruby_1.1.6.bb
@@ -4,7 +4,7 @@ HOMEPAGE = "http://www.concurrent-ruby.com"
LICENSE = "MIT"
LIC_FILES_CHKSUM = "file://LICENSE.md;md5=fde65ae93d18826f70c6fe125aa04297"

-SRC_URI = "git://github.com/ruby-concurrency/concurrent-ruby.git;protocol=https;tag=v1.1.6\
+SRC_URI = "git://github.com/ruby-concurrency/concurrent-ruby.git;protocol=https;tag=v1.1.6;branch=master \
file://0001-Removed-check-for-concurrent_ruby.jar.patch"

S = "${WORKDIR}/git"
--
2.17.1


Peter Kjellerstedt
 

-----Original Message-----
From: meta-virtualization@... <meta-
virtualization@...> On Behalf Of kai
Sent: den 11 november 2021 11:07
To: meta-virtualization@...
Subject: [meta-virtualization][m-c-s][PATCH] concurrent-ruby: add explicit
branch

From: Kai Kang <kai.kang@...>

Add explicit branch master for concurrent-ruby as the same for other
recipes.

Signed-off-by: Kai Kang <kai.kang@...>
---
meta-openstack/recipes-devtools/ruby/concurrent-ruby_1.1.6.bb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta-openstack/recipes-devtools/ruby/concurrent-ruby_1.1.6.bb
b/meta-openstack/recipes-devtools/ruby/concurrent-ruby_1.1.6.bb
index a328203e..61a2c598 100644
--- a/meta-openstack/recipes-devtools/ruby/concurrent-ruby_1.1.6.bb
+++ b/meta-openstack/recipes-devtools/ruby/concurrent-ruby_1.1.6.bb
@@ -4,7 +4,7 @@ HOMEPAGE = "http://www.concurrent-ruby.com"
LICENSE = "MIT"
LIC_FILES_CHKSUM =
"file://LICENSE.md;md5=fde65ae93d18826f70c6fe125aa04297"

-SRC_URI = "git://github.com/ruby-concurrency/concurrent-ruby.git;protocol=https;tag=v1.1.6\
+SRC_URI = "git://github.com/ruby-concurrency/concurrent-ruby.git;protocol=https;tag=v1.1.6;branch=master \
While at it, why not remove the tag= and replace it with a proper
SRCREV = "<sha1>"?

file://0001-Removed-check-for-concurrent_ruby.jar.patch"

S = "${WORKDIR}/git"
--
2.17.1
//Peter


kai
 

On 11/11/21 7:05 PM, Peter Kjellerstedt wrote:
-----Original Message-----
From: meta-virtualization@... <meta-
virtualization@...> On Behalf Of kai
Sent: den 11 november 2021 11:07
To: meta-virtualization@...
Subject: [meta-virtualization][m-c-s][PATCH] concurrent-ruby: add explicit
branch

From: Kai Kang <kai.kang@...>

Add explicit branch master for concurrent-ruby as the same for other
recipes.

Signed-off-by: Kai Kang <kai.kang@...>
---
meta-openstack/recipes-devtools/ruby/concurrent-ruby_1.1.6.bb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta-openstack/recipes-devtools/ruby/concurrent-ruby_1.1.6.bb
b/meta-openstack/recipes-devtools/ruby/concurrent-ruby_1.1.6.bb
index a328203e..61a2c598 100644
--- a/meta-openstack/recipes-devtools/ruby/concurrent-ruby_1.1.6.bb
+++ b/meta-openstack/recipes-devtools/ruby/concurrent-ruby_1.1.6.bb
@@ -4,7 +4,7 @@ HOMEPAGE = "http://www.concurrent-ruby.com"
LICENSE = "MIT"
LIC_FILES_CHKSUM =
"file://LICENSE.md;md5=fde65ae93d18826f70c6fe125aa04297"

-SRC_URI = "git://github.com/ruby-concurrency/concurrent-ruby.git;protocol=https;tag=v1.1.6\
+SRC_URI = "git://github.com/ruby-concurrency/concurrent-ruby.git;protocol=https;tag=v1.1.6;branch=master \
While at it, why not remove the tag= and replace it with a proper
SRCREV = "<sha1>"?
Sorry for late reply.

I am not sure which is better because there is a tag with branch in SRC_URI in meta-oe. If you insist remove tag is better, I'll send it with v2.

Thanks,

Kai


file://0001-Removed-check-for-concurrent_ruby.jar.patch"

S = "${WORKDIR}/git"
--
2.17.1
//Peter
--
Kai Kang
Wind River Linux


Bruce Ashfield
 

On Fri, Nov 19, 2021 at 8:43 AM kai <kai.kang@...> wrote:

On 11/11/21 7:05 PM, Peter Kjellerstedt wrote:
-----Original Message-----
From: meta-virtualization@... <meta-
virtualization@...> On Behalf Of kai
Sent: den 11 november 2021 11:07
To: meta-virtualization@...
Subject: [meta-virtualization][m-c-s][PATCH] concurrent-ruby: add explicit
branch

From: Kai Kang <kai.kang@...>

Add explicit branch master for concurrent-ruby as the same for other
recipes.

Signed-off-by: Kai Kang <kai.kang@...>
---
meta-openstack/recipes-devtools/ruby/concurrent-ruby_1.1.6.bb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta-openstack/recipes-devtools/ruby/concurrent-ruby_1.1.6.bb
b/meta-openstack/recipes-devtools/ruby/concurrent-ruby_1.1.6.bb
index a328203e..61a2c598 100644
--- a/meta-openstack/recipes-devtools/ruby/concurrent-ruby_1.1.6.bb
+++ b/meta-openstack/recipes-devtools/ruby/concurrent-ruby_1.1.6.bb
@@ -4,7 +4,7 @@ HOMEPAGE = "http://www.concurrent-ruby.com"
LICENSE = "MIT"
LIC_FILES_CHKSUM =
"file://LICENSE.md;md5=fde65ae93d18826f70c6fe125aa04297"

-SRC_URI = "git://github.com/ruby-concurrency/concurrent-ruby.git;protocol=https;tag=v1.1.6\
+SRC_URI = "git://github.com/ruby-concurrency/concurrent-ruby.git;protocol=https;tag=v1.1.6;branch=master \
While at it, why not remove the tag= and replace it with a proper
SRCREV = "<sha1>"?
Sorry for late reply.

I am not sure which is better because there is a tag with branch in
SRC_URI in meta-oe. If you insist remove tag is better, I'll send it
with v2.
The default is to use SRCREVs instead of tags, since tags can change
(although they shouldn't), and it used to be that tags did trigger
some network access with some configurations.

So if it isn't too much trouble, I do think switching to a SRCREV is better.

Bruce


Thanks,

Kai


file://0001-Removed-check-for-concurrent_ruby.jar.patch"

S = "${WORKDIR}/git"
--
2.17.1
//Peter
--
Kai Kang
Wind River Linux




--
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II