[PATCH v2] qemu: Remove duplicated xen PACKAGECONFIG


Diego Sueiro
 

The "meta/recipes-devtools/qemu/qemu.inc" already sets the PACKAGECONFIG[xen].

Signed-off-by: Diego Sueiro <diego.sueiro@...>
---
recipes-devtools/qemu/qemu_%.bbappend | 2 --
1 file changed, 2 deletions(-)

diff --git a/recipes-devtools/qemu/qemu_%.bbappend b/recipes-devtools/qemu/qemu_%.bbappend
index 998a401..5cca9e1 100644
--- a/recipes-devtools/qemu/qemu_%.bbappend
+++ b/recipes-devtools/qemu/qemu_%.bbappend
@@ -1,3 +1 @@
-PACKAGECONFIG[xen] = "--enable-xen,--disable-xen,xen-tools,xen-tools-libxenstore xen-tools-libxenctrl xen-tools-libxenguest"
-
require ${@bb.utils.contains('DISTRO_FEATURES', 'vmsep', '${BPN}-package-split.inc', '', d)}
--
2.7.4


Christopher Clark
 

On Thu, Jul 23, 2020 at 7:47 AM Diego Sueiro <diego.sueiro@...> wrote:

The "meta/recipes-devtools/qemu/qemu.inc" already sets the PACKAGECONFIG[xen].
This is correct and this section of the qemu append here can be
removed now, since both openembedded-core and poky have been updated
and contain this version of the logic in their qemu recipes.

Thanks, Diego.

Signed-off-by: Diego Sueiro <diego.sueiro@...>
Reviewed-by: Christopher Clark <christopher.clark6@...>

Christopher

---
recipes-devtools/qemu/qemu_%.bbappend | 2 --
1 file changed, 2 deletions(-)

diff --git a/recipes-devtools/qemu/qemu_%.bbappend b/recipes-devtools/qemu/qemu_%.bbappend
index 998a401..5cca9e1 100644
--- a/recipes-devtools/qemu/qemu_%.bbappend
+++ b/recipes-devtools/qemu/qemu_%.bbappend
@@ -1,3 +1 @@
-PACKAGECONFIG[xen] = "--enable-xen,--disable-xen,xen-tools,xen-tools-libxenstore xen-tools-libxenctrl xen-tools-libxenguest"
-
require ${@bb.utils.contains('DISTRO_FEATURES', 'vmsep', '${BPN}-package-split.inc', '', d)}
--
2.7.4


Bruce Ashfield
 

On Thu, Jul 23, 2020 at 2:42 PM Christopher Clark
<christopher.w.clark@...> wrote:

On Thu, Jul 23, 2020 at 7:47 AM Diego Sueiro <diego.sueiro@...> wrote:

The "meta/recipes-devtools/qemu/qemu.inc" already sets the PACKAGECONFIG[xen].
This is correct and this section of the qemu append here can be
removed now, since both openembedded-core and poky have been updated
and contain this version of the logic in their qemu recipes.

Thanks, Diego.

Signed-off-by: Diego Sueiro <diego.sueiro@...>
Reviewed-by: Christopher Clark <christopher.clark6@...>
Thanks for the review.

This is now merged.

Bruce

Christopher

---
recipes-devtools/qemu/qemu_%.bbappend | 2 --
1 file changed, 2 deletions(-)

diff --git a/recipes-devtools/qemu/qemu_%.bbappend b/recipes-devtools/qemu/qemu_%.bbappend
index 998a401..5cca9e1 100644
--- a/recipes-devtools/qemu/qemu_%.bbappend
+++ b/recipes-devtools/qemu/qemu_%.bbappend
@@ -1,3 +1 @@
-PACKAGECONFIG[xen] = "--enable-xen,--disable-xen,xen-tools,xen-tools-libxenstore xen-tools-libxenctrl xen-tools-libxenguest"
-
require ${@bb.utils.contains('DISTRO_FEATURES', 'vmsep', '${BPN}-package-split.inc', '', d)}
--
2.7.4



--
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II