|
Re: [PATCH] libvirt: fix do_package issue
preeti.sachan@...
Hi Qi
You are right. My build configuration is also using multilib and this issue appeared.
|
|
|
|
Re: [PATCH] libvirt: fix do_package issue
Bruce Ashfield
On Mon, Apr 11, 2022 at 9:45 AM Chen, Qi <Qi.Chen@...> wrote:
Hmm. Indeed. In that case, I'll go with a variant of the original patch, with a tweaked commit log. I'll take care of that now. Bruce
- Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end - "Use the force Harry" - Gandalf, Star Trek II
|
|
|
|
Re: [PATCH] libvirt: fix do_package issue
Chen Qi
The only package I found which uses /usr/lib/sysctl.d is systemd. It packages ${exec_prefix}/lib/sysctl.d. And it has its reason. It treats /usr/lib as an arch-independent vendor dir, and $libdir is treated as the dir to hold libs. file-hierarchy (www.freedesktop.org)
Regards, Qi
From: Bruce Ashfield <bruce.ashfield@...>
On Mon, Apr 11, 2022 at 9:32 AM Chen, Qi <Qi.Chen@...> wrote:
That's a larger issue, and it breaks other parts of the system. We shouldn't have anything with hard coded /usr/lib.
How are other packages dealing with this ?
In that case, I'll do individual scripts in the packaging, since I don't want a global /usr/lib/ as part of the packaging.
Bruce
-- - Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end
|
|
|
|
Re: [PATCH] k3s: do not use a go file as patch
Bruce Ashfield
On Fri, Apr 8, 2022 at 1:42 PM Bruce Ashfield via lists.yoctoproject.org <bruce.ashfield=gmail.com@...> wrote:
I've done multiple executions of that exact set of steps, and I've never seen the error you are encountering. Clearly there's something different in the various build environments. We are also getting reports of k3s working in other CI setups and runtime success, so it also isn't happening everywhere. That being said, the patch is simple enough, and as long as it doesn't break my tests (re-running with it queued now), I'll merge it and just keep an eye out for other similar behaviour popping up. Bruce
- Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end - "Use the force Harry" - Gandalf, Star Trek II
|
|
|
|
Re: [PATCH] libvirt: fix do_package issue
Bruce Ashfield
On Mon, Apr 11, 2022 at 9:32 AM Chen, Qi <Qi.Chen@...> wrote:
That's a larger issue, and it breaks other parts of the system. We shouldn't have anything with hard coded /usr/lib. How are other packages dealing with this ? In that case, I'll do individual scripts in the packaging, since I don't want a global /usr/lib/ as part of the packaging. Bruce
- Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end - "Use the force Harry" - Gandalf, Star Trek II
|
|
|
|
Re: [PATCH] libvirt: package all sysctl conf files for libvirtd
Bruce Ashfield
On Mon, Apr 11, 2022 at 9:29 AM Chen Qi <Qi.Chen@...> wrote: The libvirtd package has already packaged ${sysconfdir}/sysctl.d, See the patch that I sent as well. There's no reason to have /usr/lib anywhere in the packaging at all. We should just rely on ${libdir}, if libvirt is installing outside of the definition of ${libdir}, then we can patch ilbvirt, versus hardcoding /usr/lib in the FILES variables. Bruce
- Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end - "Use the force Harry" - Gandalf, Star Trek II
|
|
|
|
Re: [PATCH] libvirt: fix do_package issue
Chen Qi
Hi Bruce,
Looking at the issue a little further, I found we need to use the hardcoded ‘/usr/lib’. This is because sysctl is hardcoding that.
Some codes in sysctl.c from procps: static int PreloadSystem(void) { unsigned di, i; const char *dirs[] = { "/etc/sysctl.d", "/run/sysctl.d", "/usr/local/lib/sysctl.d", "/usr/lib/sysctl.d", "/lib/sysctl.d", };
I’ve sent out a patch to fix the issue. Please help review it.
Regards, Qi
From: Bruce Ashfield <bruce.ashfield@...>
On Mon, Apr 11, 2022 at 9:01 AM Chen, Qi <Qi.Chen@...> wrote:
Aha. Right you are.
So we should tweak libvirt to use ${libdir} and not the hardcoded /user/lib (which it never really should have been), and package anything that gets installed into sysctl.d/
It isn't clear that this particular .conf belongs in libvirtd, but it is just as good there, as in the libvirt-python.
I'll do some tests in the non-multiconfig configuration to ensure that everything still packages properly.
Bruce
-- - Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end
|
|
|
|
[PATCH] libvirt: package all sysctl conf files for libvirtd
Chen Qi
The libvirtd package has already packaged ${sysconfdir}/sysctl.d,
and also the /usr/lib/sysctl.d/60-libvirtd.conf, it would be reasonable for it to package other sysctl conf files, otherwise we will meet the following error in case of multilib. QA Issue: libvirt: Files/directories were installed but not shipped in any package: /usr/lib/sysctl.d/60-qemu-postcopy-migration.conf Signed-off-by: Chen Qi <Qi.Chen@...> --- recipes-extended/libvirt/libvirt_8.1.0.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/recipes-extended/libvirt/libvirt_8.1.0.bb b/recipes-extended/libvirt/libvirt_8.1.0.bb index b90fb704..433601c6 100644 --- a/recipes-extended/libvirt/libvirt_8.1.0.bb +++ b/recipes-extended/libvirt/libvirt_8.1.0.bb @@ -62,7 +62,7 @@ FILES:${PN}-libvirtd = " \ ${sysconfdir}/sysctl.d \ ${sysconfdir}/logrotate.d \ ${sysconfdir}/libvirt/libvirtd.conf \ - /usr/lib/sysctl.d/60-libvirtd.conf \ + /usr/lib/sysctl.d/ \ ${sbindir}/libvirtd \ ${systemd_system_unitdir} \ ${@bb.utils.contains('DISTRO_FEATURES', 'sysvinit', '', '${libexecdir}/libvirt-guests.sh', d)} \ -- 2.33.0
|
|
|
|
Re: [PATCH] libvirt: fix do_package issue
Bruce Ashfield
On Mon, Apr 11, 2022 at 9:05 AM Bruce Ashfield via lists.yoctoproject.org <bruce.ashfield=gmail.com@...> wrote:
I've pushed my WIP patch here: Bruce
- Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end - "Use the force Harry" - Gandalf, Star Trek II
|
|
|
|
Re: [PATCH] libvirt: fix do_package issue
Bruce Ashfield
On Mon, Apr 11, 2022 at 9:01 AM Chen, Qi <Qi.Chen@...> wrote:
Aha. Right you are. So we should tweak libvirt to use ${libdir} and not the hardcoded /user/lib (which it never really should have been), and package anything that gets installed into sysctl.d/ It isn't clear that this particular .conf belongs in libvirtd, but it is just as good there, as in the libvirt-python. I'll do some tests in the non-multiconfig configuration to ensure that everything still packages properly. Bruce
- Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end - "Use the force Harry" - Gandalf, Star Trek II
|
|
|
|
Re: [PATCH] libvirt: fix do_package issue
Chen Qi
Hi Bruce & Preeti,
I was trying to fix the same issue when I found this thread. This issue appears when multilib is enabled.
When multilib is disabled, ${libdir} is /usr/lib, thus packaging the file into libvirt-python. When multilib is enabled, ${libdir} is /usr/lib64, and the file is not packaged.
Regards, Qi
From: meta-virtualization@... <meta-virtualization@...>
On Behalf Of Bruce Ashfield
There's definitely something different in your configuration, so that needs to be understood first.
That file is packaged as part of libvirt-python here, and should be the same for others, as I haven't had any reports of failures.
You have a multiconfig in play. Anything else ? What is your init system ? Any bbappends in play ?
Bruce
On Sun, Apr 10, 2022 at 11:49 PM <preeti.sachan@...> wrote:
-- - Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end
|
|
|
|
Re: [PATCH] libvirt: fix do_package issue
preeti.sachan@...
No libvirt bbappend file in build and multiconfig is created to build with particular kernel version.
In recipe https://git.yoctoproject.org/meta-virtualization/tree/recipes-extended/libvirt/libvirt_8.1.0.bb , FILES:${PN}-libvirtd is not including "/usr/lib/sysctl.d/60-qemu-postcopy-migration.conf " neither something "usr/lib/sysctl.d/*". It's strange how it is packaging file "/usr/lib/sysctl.d/60-qemu-postcopy-migration.conf "
|
|
|
|
Re: [PATCH] libvirt: fix do_package issue
Bruce Ashfield
There's definitely something different in your configuration, so that needs to be understood first. That file is packaged as part of libvirt-python here, and should be the same for others, as I haven't had any reports of failures. You have a multiconfig in play. Anything else ? What is your init system ? Any bbappends in play ? Bruce
On Sun, Apr 10, 2022 at 11:49 PM <preeti.sachan@...> wrote:
--
- Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end - "Use the force Harry" - Gandalf, Star Trek II
|
|
|
|
Re: [PATCH] cni: Add ;protocol=https for flannel_plugin SRC_URI
Bruce Ashfield
On Mon, Apr 11, 2022 at 6:45 AM Diego Sueiro <diego.sueiro@...> wrote: Also, fix the indentation for the SRC_URI variable assignment. It had a protocol specification already, I just managed to miss an 'o'. I've fixed that, and pushed the change. Annoying that github didn't break/stop my build immediately with that typo, but at least it is fixed now Bruce Signed-off-by: Diego Sueiro <diego.sueiro@...> - Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end - "Use the force Harry" - Gandalf, Star Trek II
|
|
|
|
[PATCH] cni: Add ;protocol=https for flannel_plugin SRC_URI
Diego Sueiro
Also, fix the indentation for the SRC_URI variable assignment.
Signed-off-by: Diego Sueiro <diego.sueiro@...> --- recipes-networking/cni/cni_git.bb | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/recipes-networking/cni/cni_git.bb b/recipes-networking/cni/c= ni_git.bb index 42eed1b..9248af2 100644 --- a/recipes-networking/cni/cni_git.bb +++ b/recipes-networking/cni/cni_git.bb @@ -15,10 +15,11 @@ SRCREV_plugins =3D "b8a10bbe111e9db72433f357c37077554= ada7ca1" SRCREV_flannel_plugin =3D "076c4462d6c6887614fc881b806b690b9e56ceb2" SRCREV_FORMAT =3D "cni_plugins" SRC_URI =3D "\ - git://github.com/containernetworking/cni.git;nobranch=3D1;name=3Dcni;pr= otocol=3Dhttps \ - git://github.com/containernetworking/plugins.git;nobranch=3D1;de= stsuffix=3D${S}/src/github.com/containernetworking/plugins;name=3Dplugins= ;protocol=3Dhttps \ - git://github.com/flannel-io/cni-plugin;branch=3Dmain;name=3Dflan= nel_plugin;protcol=3Dhttps;destsuffix=3D${S}/src/github.com/containernetw= orking/plugins/plugins/meta/flannel \ - " + git://github.com/containernetworking/cni.git;nobranch=3D1;name=3Dcni= ;protocol=3Dhttps \ + git://github.com/containernetworking/plugins.git;nobranch=3D1;destsu= ffix=3D${S}/src/github.com/containernetworking/plugins;name=3Dplugins;pro= tocol=3Dhttps \ + git://github.com/flannel-io/cni-plugin;branch=3Dmain;name=3Dflannel_= plugin;protcol=3Dhttps;destsuffix=3D${S}/src/github.com/containernetworki= ng/plugins/plugins/meta/flannel;protocol=3Dhttps \ + " + LICENSE =3D "Apache-2.0" LIC_FILES_CHKSUM =3D "file://src/import/LICENSE;md5=3Dfa818a259cbed7ce8b= c2a22d35a464fc" =20 --=20 2.35.1
|
|
|
|
Re: [PATCH 0/3] xen: Update recipes for xen and xen-tools
Bertrand Marquis
Hi Michal,
On 8 Apr 2022, at 09:44, Michal Orzel via lists.yoctoproject.org <michal.orzel=arm.com@...> wrote:Thanks a lot for this. For the whole serie: Reviewed-by: Bertrand Marquis <bertrand.marquis@...> Cheers Bertrand
|
|
|
|
Re: [PATCH] libvirt: fix do_package issue
preeti.sachan@...
ERROR: mc:x86-2020:libvirt-8.1.0-r0 do_package: QA Issue: libvirt: Files/directories were installed but not shipped in any package:
/usr/lib/sysctl.d/60-qemu-postcopy-migration.conf
Please set FILES such that these items are packaged. Alternatively if they are unneeded, avoid installing them or delete them within do_install.
libvirt: 1 installed and not shipped files. [installed-vs-shipped]
ERROR: mc:x86-2020:libvirt-8.1.0-r0 do_package: Fatal QA errors were found, failing task.
|
|
|
|
Re: [PATCH] libvirt: fix do_package issue
Bruce Ashfield
I'm not seeing any packaging issues here. Can you elaborate on what warning/QA/other issue you are seeing ? Bruce
On Sun, Apr 10, 2022 at 8:38 PM <preeti.sachan@...> wrote: From: Preeti Sachan <preeti.sachan@...> --
- Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end - "Use the force Harry" - Gandalf, Star Trek II
|
|
|
|
[PATCH] libvirt: fix do_package issue
preeti.sachan@...
From: Preeti Sachan <preeti.sachan@...>
Signed-off-by: Preeti Sachan <preeti.sachan@...> --- recipes-extended/libvirt/libvirt_8.1.0.bb | 1 + 1 file changed, 1 insertion(+) diff --git a/recipes-extended/libvirt/libvirt_8.1.0.bb b/recipes-extended/libvirt/libvirt_8.1.0.bb index b90fb70..712cea8 100644 --- a/recipes-extended/libvirt/libvirt_8.1.0.bb +++ b/recipes-extended/libvirt/libvirt_8.1.0.bb @@ -63,6 +63,7 @@ FILES:${PN}-libvirtd = " \ ${sysconfdir}/logrotate.d \ ${sysconfdir}/libvirt/libvirtd.conf \ /usr/lib/sysctl.d/60-libvirtd.conf \ + /usr/lib/sysctl.d/60-qemu-postcopy-migration.conf \ ${sbindir}/libvirtd \ ${systemd_system_unitdir} \ ${@bb.utils.contains('DISTRO_FEATURES', 'sysvinit', '', '${libexecdir}/libvirt-guests.sh', d)} \ -- 2.25.1
|
|
|
|
Re: Issues with k3s runtime on master
Bruce Ashfield
On Fri, Apr 8, 2022 at 2:06 PM Diego Sueiro <Diego.Sueiro@...> wrote:
It isn't strictly required. There's so many entries in the SRC_URI for some packages, we can't really list them all, and have the SRCREV format be useful at all. Bruce
- Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end - "Use the force Harry" - Gandalf, Star Trek II
|
|
|