Re: [PATCH] xen/sysvinit: add hvc0 console only if not there already

Christopher Clark

On Tue, Jul 5, 2022 at 1:29 PM Bruce Ashfield <bruce.ashfield@...> wrote:

Looks ok to me. I'll give it another day to hear from Christopher, and then
I'll do the merge.
Ack from me - thanks



In message: [meta-virtualization] [PATCH] xen/sysvinit: add hvc0 console only if not there already
on 28/06/2022 Bertrand Marquis wrote:

The base inittab recipe is creating inittab entries for consoles listed
For qemu, this contains "115200,hvc0" so an entry is created in inittab
for it.
Prevent to create a second entry if hvc0 is present in SERIAL_CONSOLES.

On qemuarm, this solves issues with the console when starting on top of
Xen as dom0.

Signed-off-by: Bertrand Marquis <bertrand.marquis@...>
recipes-core/sysvinit/ | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/recipes-core/sysvinit/ b/recipes-core/sysvinit/
index 7f92bd1..724f47d 100644
--- a/recipes-core/sysvinit/
+++ b/recipes-core/sysvinit/
@@ -1,4 +1,10 @@
do_install:append() {
- echo "" >> ${D}${sysconfdir}/inittab
- echo "X0:12345:respawn:${base_sbindir}/getty-wrapper 115200 hvc0" >> ${D}${sysconfdir}/inittab
+ # if SERIAL_CONSOLES contains hvc0, it is already added in inittab so do
+ # not add it twice
+ if echo "${SERIAL_CONSOLES}" | grep -vq "hvc0"; then
+ echo "" >> ${D}${sysconfdir}/inittab
+ echo "X0:12345:respawn:${base_sbindir}/getty-wrapper 115200 hvc0" >> ${D}${sysconfdir}/inittab
+ fi

Join to automatically receive all group messages.