Re: [PATCH] podman: do not build or install docs


sakib.sajal@...
 

On 2022-05-20 08:55, Bruce Ashfield wrote:
[Please note: This e-mail is from an EXTERNAL e-mail address]

On Fri, May 20, 2022 at 12:06 AM Sakib Sajal <sakib.sajal@...> wrote:

On 2022-05-19 16:34, Bruce Ashfield wrote:
[Please note: This e-mail is from an EXTERNAL e-mail address]

On Thu, May 19, 2022 at 3:39 PM <sakib.sajal@...> wrote:
When using oe-core, podman do_compile fails with the error:
.../podman/4.0.1+gitAUTOINC+717edd7b84-r0/recipe-sysroot-native/usr/bin/go-md2man:
No such file or directory
make: *** [Makefile:482: docs/source/markdown/podman-attach.1] Error 127
Whereas when using poky, the build passes without issues.

Investigating the native go-md2man binaries from both oe-core and poky
builds using ldd, it appears that the issue lies with how go-md2man is linked.
On oe-core it is linked to the loader in recipe sysroot:
tmp-glibc/work/x86_64-linux/go-md2man-native/1.0.10+gitAUTOINC+f79a8a8ca6-r0/recipe-sysroot-native/usr/lib/ld-linux-x86-64.so.2
=> /lib64/ld-linux-x86-64.so.2 (0x00007f4da90f0000)

whereas on poky its linked to sysroot-uninative:
tmp/sysroots-uninative/x86_64-linux/lib/ld-linux-x86-64.so.2
=> /lib64/ld-linux-x86-64.so.2 (0x00007f9c82c71000)

I have confirmed that this issue exists on both Ubuntu 18.04 and
Fedora 35.

Rather have this fail for people using only oe-core, skip generating the
documentation for podman until the problem can be resolved.
I'm building podman nightly without seeing this error.

So your message about "people using only oe-core" doesn't make sense,
can you clarify ?

Bruce
Apologies for being vague.

podman fails to compile, on both Ubuntu 18.04 and Fedora 35, using the
latest master branch of bitbake, openembedded-core, meta-openembedded
and meta-virtualization.
ok, so this is specific to those distros. Since there are quite a few
different CI pipelines, and my own local builds that aren't seeing the
error.

Below are the steps to reproduce and bblayers.conf (default local.conf):

steps to reproduce:

. openembedded-core/oe-init-build-env <build_dir>

bitbake podman


bblayers.conf :

# LAYER_CONF_VERSION is increased each time build/conf/bblayers.conf
# changes incompatibly
LCONF_VERSION = "7"

BBPATH = "${TOPDIR}"
BBFILES ?= ""

BBLAYERS ?= " \
..../repos/openembedded-core/meta \
..../repos/meta-openembedded/meta-oe \
..../repos/meta-openembedded/meta-python \
..../repos/meta-openembedded/meta-networking \
..../repos/meta-openembedded/meta-filesystems \
..../repos/meta-virtualization \
ok, cool. Nothing strange in that configuration.

At this point, I'll suggest you carry that patch locally while you
work through the dependent recipe, since I'd rather not merge the
patch that disables the documentation for all distros.

I'll see if I can get myself a containerized environment and reproduce
the issue.

Bruce
Sounds good, thank you for taking a look!

- Sakib



Signed-off-by: Sakib Sajal <sakib.sajal@...>
---
...efile-do-not-compile-or-install-docs.patch | 35 +++++++++++++++++++
recipes-containers/podman/podman_git.bb | 1 +
2 files changed, 36 insertions(+)
create mode 100644 recipes-containers/podman/files/0001-Makefile-do-not-compile-or-install-docs.patch

diff --git a/recipes-containers/podman/files/0001-Makefile-do-not-compile-or-install-docs.patch b/recipes-containers/podman/files/0001-Makefile-do-not-compile-or-install-docs.patch
new file mode 100644
index 0000000..1363ee8
--- /dev/null
+++ b/recipes-containers/podman/files/0001-Makefile-do-not-compile-or-install-docs.patch
@@ -0,0 +1,35 @@
+From 7913cac21842f56ae9752fb0c253f838bab04ae8 Mon Sep 17 00:00:00 2001
+From: Sakib Sajal <sakib.sajal@...>
+Date: Fri, 13 May 2022 13:06:29 -0400
+Subject: [PATCH] Makefile: do not compile or install docs
+
+Signed-off-by: Sakib Sajal <sakib.sajal@...>
+---
+ Makefile | 4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/src/import/Makefile b/src/import/Makefile
+index cb230d8e9..7e07ab61a 100644
+--- a/src/import/Makefile
++++ b/src/import/Makefile
+@@ -202,7 +202,7 @@ GV_SHA=e943b1806d94d387c4c38d96719432d50a84bbd0
+ default: all
+
+ .PHONY: all
+-all: binaries docs
++all: binaries
+
+ .PHONY: binaries
+ binaries: podman podman-remote rootlessport ## Build podman, podman-remote and rootlessport binaries
+@@ -754,7 +754,7 @@ package-install: package ## Install rpm packages
+ /usr/bin/podman info # will catch a broken conmon
+
+ .PHONY: install
+-install: .gopathok install.bin install.remote install.man install.systemd ## Install binaries to system locations
++install: .gopathok install.bin install.remote install.systemd ## Install binaries to system locations
+
+ .PHONY: install.catatonit
+ install.catatonit:
+--
+2.33.0
+
diff --git a/recipes-containers/podman/podman_git.bb b/recipes-containers/podman/podman_git.bb
index f805cb6..8339a16 100644
--- a/recipes-containers/podman/podman_git.bb
+++ b/recipes-containers/podman/podman_git.bb
@@ -20,6 +20,7 @@ DEPENDS = " \
SRCREV = "717edd7b844dcd66468f5d991991d87e9fc14c12"
SRC_URI = " \
git://github.com/containers/libpod.git;branch=v4.0;protocol=https \
+ file://0001-Makefile-do-not-compile-or-install-docs.patch \
"

LICENSE = "Apache-2.0"
--
2.33.0


--
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II

--
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II

Join {meta-virtualization@lists.yoctoproject.org to automatically receive all group messages.