On Wed, Jul 21, 2021 at 4:49 PM Ruslan Babayev (fib) <fib@...> wrote:
Just do add. I am not sure why the prepend with export LIBRARY_PATH was added to begin with. Perhaps it is no longer required.
It very likely isn't.
The git history shows me wondering that same thing in 2015.
When it was introduced, we needed a patch to make the ncurses DEPENDS
properly cross compile. That patch is gone, so the search path
modification is also probably not required.
If I can ask, what recipe are you building that is showing the error ?
That's really what I want to understand, since we are building many
images on a daily basis with host/target python packages and I've
never seen the issue.
If I can reproduce the breakage here, then I can also confirm that we
can just drop the configure prepend completely.
Bruce
-----Original Message-----
From: meta-virtualization@... <meta-virtualization@...> On Behalf Of Ruslan Babayev (fib) via lists.yoctoproject.org
Sent: Wednesday, July 21, 2021 1:37 PM
To: Bruce Ashfield <bruce.ashfield@...>
Cc: meta-virtualization@...
Subject: Re: [meta-virtualization][PATCH] python3: unbreak python3-native when virtualization is in DISTRO_FEATURES
Basically, python3-native recipe with DISTRO_FEATURES with virtualization is broken due to ${STAGING_DIR_TARGET} being undefined and LIBRARY_PATH ending up as "/lib".
I can put the part about ${STAGING_DIR_TARGET} not defined for native recipes in the body of the commit if you like.
-----Original Message-----
From: Bruce Ashfield <bruce.ashfield@...>
Sent: Wednesday, July 21, 2021 1:32 PM
To: Ruslan Babayev (fib) <fib@...>
Cc: meta-virtualization@...
Subject: Re: [meta-virtualization][PATCH] python3: unbreak python3-native when virtualization is in DISTRO_FEATURES
You need to elaborate much more in this commit message. We need to document what exactly were the symptoms, in what sort of build things weren't working, and how this fixes it.
Cheers,
Bruce
On Wed, Jul 21, 2021 at 4:30 PM Ruslan Babayev <fib@...> wrote:
Signed-off-by: Ruslan Babayev <fib@...>
---
recipes-devtools/python/python3_virtualization.inc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/recipes-devtools/python/python3_virtualization.inc
b/recipes-devtools/python/python3_virtualization.inc
index 55301c7..481db58 100644
--- a/recipes-devtools/python/python3_virtualization.inc
+++ b/recipes-devtools/python/python3_virtualization.inc
@@ -2,7 +2,7 @@ FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
DEPENDS += " ncurses"
-do_compile_prepend() {
+do_compile_prepend_class-target() {
export LIBRARY_PATH=${STAGING_DIR_TARGET}/lib
}
--
2.26.2.Cisco
--
- Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end
- "Use the force Harry" - Gandalf, Star Trek II
--
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II
