Re: [PATCH] python3: unbreak python3-native when virtualization is in DISTRO_FEATURES
Ruslan Babayev (fib)
Basically, python3-native recipe with DISTRO_FEATURES with virtualization is broken due to ${STAGING_DIR_TARGET} being undefined and LIBRARY_PATH ending up as "/lib".
I can put the part about ${STAGING_DIR_TARGET} not defined for native recipes in the body of the commit if you like.
toggle quoted message
Show quoted text
I can put the part about ${STAGING_DIR_TARGET} not defined for native recipes in the body of the commit if you like.
-----Original Message-----
From: Bruce Ashfield <bruce.ashfield@...>
Sent: Wednesday, July 21, 2021 1:32 PM
To: Ruslan Babayev (fib) <fib@...>
Cc: meta-virtualization@...
Subject: Re: [meta-virtualization][PATCH] python3: unbreak python3-native when virtualization is in DISTRO_FEATURES
You need to elaborate much more in this commit message. We need to document what exactly were the symptoms, in what sort of build things weren't working, and how this fixes it.
Cheers,
Bruce
On Wed, Jul 21, 2021 at 4:30 PM Ruslan Babayev <fib@...> wrote:
--
- Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end
- "Use the force Harry" - Gandalf, Star Trek II
From: Bruce Ashfield <bruce.ashfield@...>
Sent: Wednesday, July 21, 2021 1:32 PM
To: Ruslan Babayev (fib) <fib@...>
Cc: meta-virtualization@...
Subject: Re: [meta-virtualization][PATCH] python3: unbreak python3-native when virtualization is in DISTRO_FEATURES
You need to elaborate much more in this commit message. We need to document what exactly were the symptoms, in what sort of build things weren't working, and how this fixes it.
Cheers,
Bruce
On Wed, Jul 21, 2021 at 4:30 PM Ruslan Babayev <fib@...> wrote:
Signed-off-by: Ruslan Babayev <fib@...>
---
recipes-devtools/python/python3_virtualization.inc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/recipes-devtools/python/python3_virtualization.inc
b/recipes-devtools/python/python3_virtualization.inc
index 55301c7..481db58 100644
--- a/recipes-devtools/python/python3_virtualization.inc
+++ b/recipes-devtools/python/python3_virtualization.inc
@@ -2,7 +2,7 @@ FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
DEPENDS += " ncurses"
-do_compile_prepend() {
+do_compile_prepend_class-target() {
export LIBRARY_PATH=${STAGING_DIR_TARGET}/lib
}
--
2.26.2.Cisco
--
- Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end
- "Use the force Harry" - Gandalf, Star Trek II