Re: [PATCH 1/3] podman: Add seccomp as REQUIRED_DISTRO_FEATURES


Richard Purdie
 

On Fri, 2021-06-25 at 08:46 -0400, Bruce Ashfield wrote:
On Fri, Jun 25, 2021 at 4:11 AM Diego Sueiro <Diego.Sueiro@...> wrote:

-----Original Message-----
From: Bruce Ashfield <bruce.ashfield@...>
Sent: 25 June 2021 03:49
To: Martin Jansa <martin.jansa@...>
Cc: Diego Sueiro <Diego.Sueiro@...>; meta-
virtualization@...; nd <nd@...>
Subject: Re: [meta-virtualization][PATCH 1/3] podman: Add seccomp as
REQUIRED_DISTRO_FEATURES

On Thu, Jun 24, 2021 at 5:01 PM Martin Jansa <martin.jansa@...>
wrote:

This change is correct, libseccomp still requires seccomp in
DISTRO_FEATURES, so anything depending on it should have the same
restriction.
Right, I understand how/why it works like this .. but it is super clunky when we
can't just depend on something that is now in core, without needing to
sprinkle distro checks everywhere.

As the list of recipes gets larger with that check, it really isn't an optional distro
feature for using meta virt at all, and it would be nice if we could just do the
check once and be done with it.
Just a side note that these patches fix issues with yocto-check-layer.
I've disagreed with check-layer before (and we've changed how it works)

That being said, the layer is checked on the AB, and Richard hasn't
reported any issues. So clearly there's something wrong with the AB
test or with something else.
https://autobuilder.yoctoproject.org/typhoon/#/builders/121/builds/110

Says green...

Obviously we just tweak the css :)

Cheers,

Richard

Join meta-virtualization@lists.yoctoproject.org to automatically receive all group messages.