PVR or PowerVR name is still used as an overall umbrella for all of Imagination's graphics, vision and AI chips, including SGX and Rogue/RGX: https://en.wikipedia.org/wiki/PowerVR 1. I totally

PVR_SOC is a bit of a legacy name, especially since PVR is now IMG. Thinking on this, the mapping between SoC family and the internal names like "RGX_BVNC" and "TARGET_PRODUCT" are specific to the

From: Nishanth Menon <nm@...> Lets add the basic AM62xx-evm configuration. - Add configurations. - Add firmware overrides. - Add u-boot overrides. Signed-off-by: Nishanth Menon

I'll remove those errant tabs in v4. The formatting has been in there for quite a while, so a more general file clean up might be in order. I'll save that for another commit after we get past all of

Some quotes from the manual for 3 different cases - shell code, python code and multi-line statements: =============================================== Indentation: Use spaces for indentation rather

Overall looks good, please see inline below. I was actually thinking of keeping PVR_SOC variable and moving it to corresponding machine configs. E.g. instead of these 3 overrides in the recipe,

There are also some external docs on this that need updated but I can take a lead on that. Thanks, that would be good, I have to admit my setup is not all the way back together yet so my testing

Heh, I was actually thinking of finally making such change myself lately! :) My main concern was about breaking downstream users of meta-ti who builds on top of j7-evm platform. But it is probably a

There are now three SoCs in the J7 family, but only the j721e variant is currently supported. Be specific here. Signed-off-by: Andrew Davis <afd@...> ---

The AM65xx is the only member of the K3 family with an SGX GPU. Be specific here to avoid confusion. Signed-off-by: Andrew Davis <afd@...> ---

In many places we use "j7" the family when we should be using a specific SoC or EVM and vice-versa. For instance when including graphics drivers we add for all "j7" family, but what we really want is

This allows us to be more specific around what SoCs we support and lets us add features based on the SoC family not just at the EVM or whole J7family level. Signed-off-by: Andrew Davis

^^ Looks like some tabs found there way in here.. Why do we have these indented so far anyway, this whole file has wacky indenting, needs normalized. Andrew

From: Nishanth Menon <nm@...> Lets add the basic AM62xx-evm configuration. Signed-off-by: Nishanth Menon <nm@...> Signed-off-by: Hari Nagalla <hnagalla@...> Signed-off-by: Ryan Eatmon

Enable the GPU for am62xx and j721s2 and use IMG DDK 1.15 Migrate Imagination DDK 1.13 to DDK 1.15 for J721e Signed-off-by: Darren Etheridge <detheridge@...> --- No changes in the content of the

Please lower the similarity threshold to produce a diff of this recipe for review, instead of separate remove/add. -- Regards, Denys Dmytriyenko <denis@...> PGP: 0x420902729A92C964 -

Fixes like this should probably be squashed. -- Regards, Denys Dmytriyenko <denis@...> PGP: 0x420902729A92C964 - https://denix.org/0x420902729A92C964 Fingerprint: 25FC E4A5 8A72 2F69 1186

Ah, I see it's being fixed later here (in patch #5)... I know this patch series has been developed internally over time and comes with a history. I wonder if this needs cleaning up during

NAK to the series. a) patches need to be cleaned up - squashed etc. b) lpm-demo binary should probably belong to meta-arago instead of meta-ti. meta-ti should be a bsp layer, not a distro. --

NAK -> I know I authored these initial patches during silicon bringup, but please do squash and cleanup the patches prior to posting upstream. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) /