Re: a bug of perf


leimaohui
 

Hi,

So, may I backport this patch to linux-qoriq_5.4.bb and send a PR?


Best regards
Lei Maohui

-----Original Message-----
From: Otavio Salvador <otavio.salvador@...>
Sent: Monday, April 27, 2020 9:20 PM
To: Zhenhua Luo <zhenhua.luo@...>
Cc: andrey.z@...; Lei, Maohui/雷 茂慧 <leimaohui@...>;
meta-freescale@...; Ting Liu <ting.liu@...>
Subject: Re: [meta-freescale] a bug of perf

Zhenhua,

June is too late; you need to send the fix soon or we should drop dunfell release
for QorIQ.

On Mon, Apr 27, 2020 at 9:55 AM Zhenhua Luo <zhenhua.luo@...>
wrote:
The new QorIQ SDK based on Zeus is being prepared and plan to be available
in June, we will port the perf patch in this release.


Best Regards,

Zhenhua

-----Original Message-----
From: meta-freescale@... <meta-
freescale@...> On Behalf Of Andrey Zhizhikin via
lists.yoctoproject.org
Sent: Monday, April 27, 2020 3:00 PM
To: leimaohui <leimaohui@...>
Cc: meta-freescale@...
Subject: Re: [meta-freescale] a bug of perf

On Mon, Apr 27, 2020 at 8:54 AM leimaohui <leimaohui@...>
wrote:

Hi,

I met perf bug by meta-freescale as following:
------------------------------------------------------------------
---
tmp/work/armv8-linux/perf/1.0-r9/perf-1.0/perf-in.o: in function
`find_address_in_section':
| /usr/src/debug/perf/1.0-r9/perf-1.0/tools/perf/util/srcline.c:20
| 0: undefined
reference to `bfd_get_section_flags'
perf/1.0-r9/recipe-sysroot-native/usr/bin/aarch64-linux/../../libe
xec/aarch64-
linux/gcc/aarch64-linux/9.3.0/ld: /usr/src/debug/perf/1.0-r9/perf-
1.0/tools/perf/util/srcline.c:204: undefined reference to
`bfd_get_section_vma'

I found that this bug has been fixed in upstream:
------------------------------------------------------------------
--- commit f4d7dbafb103e4f782323017c239c548871c1567
Author: Changbin Du <changbin.du@...>
Date: Tue Jan 28 23:29:38 2020 +0800

perf: Make perf able to build with latest libbfd

libbfd has changed the bfd_section_* macros to inline functions
bfd_section_<field> since 2019-09-18. See below two commits:
o
https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww
.sour
ceware.org%2Fml%2Fgdb-cvs%2F2019-
09%2Fmsg00064.html&amp;data=02%7C01%7Czhenhua.luo%40nxp.com%7Cf
7
1fca435a564dbe676308d7ea78b14f%7C686ea1d3bc2b4c6fa92cd99c5c30163
5%
7C0%7C0%7C637235676418274147&amp;sdata=FwmBOoCsXBdzRuExOVTl6r
26
3T26N9hTw5f5igDsibc%3D&amp;reserved=0
o
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.
sourceware.org%2Fml%2Fgdb-cvs%2F2019-
09%2Fmsg00072.html&amp;data=02%7C
01%7Czhenhua.luo%40nxp.com%7Cf71fca435a564dbe676308d7ea78b14f%7
C6
86ea1
d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637235676418274147&amp;s
dat
a=1MxK
Fc6pEwt0rlYQ0%2Fc1%2F%2FETpkOLRMyyC99FRh0aCpU%3D&amp;reserved=0

This fix make perf able to build with both old and new libbfd.

Signed-off-by: Changbin Du <changbin.du@...>
Acked-by: Jiri Olsa <jolsa@...>
Cc: Peter Zijlstra <peterz@...>
Link:
https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Flor
e.kerne
l.org%2Flkml%2F20200128152938.31413-1-
changbin.du%40gmail.com&amp;data=02%7C01%7Czhenhua.luo%40nxp.com%
7Cf71fca435a564dbe676308d7ea78b14f%7C686ea1d3bc2b4c6fa92cd99c5c3
01
635%7C0%7C0%7C637235676418274147&amp;sdata=SWo0QUl5N%2F7HTYJ
Ur
Udyo4zgn%2BG844E4ZdB9cLcCEco%3D&amp;reserved=0
Signed-off-by: Arnaldo Carvalho de Melo <acme@...>
Signed-off-by: Bruce Ashfield <bruce.ashfield@...>

tools/perf/util/srcline.c | 16 +++++++++++++++-
1 file changed, 15 insertions(+), 1 deletion(-)

I want to know when linux-qoriq will be updated next time?
I have this patch ported to linux-imx kernel [1], probably you
should do the same for linux-qoriq. Try to add it into the recipe and if it
would work out - send a PR.


Best regards
Lei Maohui




[1]:
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgi
thub.co
m%2FFreescale%2Fmeta-freescale%2Fblob%2Fmaster%2Frecipes-
kernel%2Flinux%2Flinux-imx-5.4.3%2F0001-perf-Make-perf-able-to-build
-with-
latest-
libbfd.patch&amp;data=02%7C01%7Czhenhua.luo%40nxp.com%7Cf71fca435a
5
64dbe676308d7ea78b14f%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7
C0
%7C637235676418274147&amp;sdata=7GeXcgw7qGut%2FI%2Bn%2Bq%2
B42A
8go1FaegAgzOzNVMPpwsk%3D&amp;reserved=0

--
Regards,
Andrey.


--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://code.ossystems.com.br
Mobile: +55 (53) 9 9981-7854 Mobile: +1 (347) 903-9750

Join meta-freescale@lists.yoctoproject.org to automatically receive all group messages.