Re: a bug of perf


Andrey Zhizhikin
 

On Mon, Apr 27, 2020 at 8:54 AM leimaohui <leimaohui@...> wrote:

Hi,

I met perf bug by meta-freescale as following:
---------------------------------------------------------------------
tmp/work/armv8-linux/perf/1.0-r9/perf-1.0/perf-in.o: in function `find_address_in_section':
| /usr/src/debug/perf/1.0-r9/perf-1.0/tools/perf/util/srcline.c:200: undefined reference to `bfd_get_section_flags'
perf/1.0-r9/recipe-sysroot-native/usr/bin/aarch64-linux/../../libexec/aarch64-linux/gcc/aarch64-linux/9.3.0/ld: /usr/src/debug/perf/1.0-r9/perf-1.0/tools/perf/util/srcline.c:204: undefined reference to `bfd_get_section_vma'

I found that this bug has been fixed in upstream:
---------------------------------------------------------------------
commit f4d7dbafb103e4f782323017c239c548871c1567
Author: Changbin Du <changbin.du@...>
Date: Tue Jan 28 23:29:38 2020 +0800

perf: Make perf able to build with latest libbfd

libbfd has changed the bfd_section_* macros to inline functions
bfd_section_<field> since 2019-09-18. See below two commits:
o http://www.sourceware.org/ml/gdb-cvs/2019-09/msg00064.html
o https://www.sourceware.org/ml/gdb-cvs/2019-09/msg00072.html

This fix make perf able to build with both old and new libbfd.

Signed-off-by: Changbin Du <changbin.du@...>
Acked-by: Jiri Olsa <jolsa@...>
Cc: Peter Zijlstra <peterz@...>
Link: http://lore.kernel.org/lkml/20200128152938.31413-1-changbin.du@gmail.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@...>
Signed-off-by: Bruce Ashfield <bruce.ashfield@...>

tools/perf/util/srcline.c | 16 +++++++++++++++-
1 file changed, 15 insertions(+), 1 deletion(-)

I want to know when linux-qoriq will be updated next time?
I have this patch ported to linux-imx kernel [1], probably you should
do the same for linux-qoriq. Try to add it into the recipe and if it
would work out - send a PR.


Best regards
Lei Maohui




[1]: https://github.com/Freescale/meta-freescale/blob/master/recipes-kernel/linux/linux-imx-5.4.3/0001-perf-Make-perf-able-to-build-with-latest-libbfd.patch

--
Regards,
Andrey.

Join meta-freescale@lists.yoctoproject.org to automatically receive all group messages.