[linux-yocto v5.10/standard/sdkv5.10/xlnx-soc][PATCH 1/4] arm64: zynqmp: fix warning about lack of #interrupt-cells


quanyang.wang
 

From: Quanyang Wang <quanyang.wang@windriver.com>

The interrupt controller nodes need #interrupt-cells property. When
building device-tree files with "DTC_FLAGS='-@'", there is warning
as below:

arch/arm64/boot/dts/xilinx/zynqmp.dtsi:450.38-460.5: Warning (interrupt_provider): /axi/interrupt-controller@f9010000: Missing #address-cells in interrupt provider
arch/arm64/boot/dts/xilinx/zynqmp.dtsi:720.23-731.5: Warning (interrupt_provider): /axi/gpio@ff0a0000: Missing #address-cells in interrupt provider

Since they have no children in the device-tree hierarchy, assign '0'
to the "interrupt-cells" property.

Signed-off-by: Quanyang Wang <quanyang.wang@windriver.com>
---
arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 2 ++
1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
index 2e1ccd179d17d..8c2cad7816435 100644
--- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
+++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
@@ -451,6 +451,7 @@ fpd_dma_chan8: dma@fd570000 {
gic: interrupt-controller@f9010000 {
compatible = "arm,gic-400";
#interrupt-cells = <3>;
+ #address-cells = <0>;
reg = <0x0 0xf9010000 0x0 0x10000>,
<0x0 0xf9020000 0x0 0x20000>,
<0x0 0xf9040000 0x0 0x20000>,
@@ -665,6 +666,7 @@ gpio: gpio@ff0a0000 {
interrupts = <0 16 4>;
interrupt-controller;
#interrupt-cells = <2>;
+ #address-cells = <0>;
reg = <0x0 0xff0a0000 0x0 0x1000>;
power-domains = <&zynqmp_firmware PD_GPIO>;
};
--
2.25.1


Bruce Ashfield
 

In message: [linux-yocto][linux-yocto v5.10/standard/sdkv5.10/xlnx-soc][PATCH 1/4] arm64: zynqmp: fix warning about lack of #interrupt-cells
on 27/07/2021 quanyang.wang@windriver.com wrote:

From: Quanyang Wang <quanyang.wang@windriver.com>

The interrupt controller nodes need #interrupt-cells property. When
building device-tree files with "DTC_FLAGS='-@'", there is warning
as below:

arch/arm64/boot/dts/xilinx/zynqmp.dtsi:450.38-460.5: Warning (interrupt_provider): /axi/interrupt-controller@f9010000: Missing #address-cells in interrupt provider
arch/arm64/boot/dts/xilinx/zynqmp.dtsi:720.23-731.5: Warning (interrupt_provider): /axi/gpio@ff0a0000: Missing #address-cells in interrupt provider

Since they have no children in the device-tree hierarchy, assign '0'
to the "interrupt-cells" property.
The commit message doesn't match the code. You are assigning to
the #address-cells property, not interrupt-cells. Or am I misreading ?

Bruce


Signed-off-by: Quanyang Wang <quanyang.wang@windriver.com>
---
arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 2 ++
1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
index 2e1ccd179d17d..8c2cad7816435 100644
--- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
+++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
@@ -451,6 +451,7 @@ fpd_dma_chan8: dma@fd570000 {
gic: interrupt-controller@f9010000 {
compatible = "arm,gic-400";
#interrupt-cells = <3>;
+ #address-cells = <0>;
reg = <0x0 0xf9010000 0x0 0x10000>,
<0x0 0xf9020000 0x0 0x20000>,
<0x0 0xf9040000 0x0 0x20000>,
@@ -665,6 +666,7 @@ gpio: gpio@ff0a0000 {
interrupts = <0 16 4>;
interrupt-controller;
#interrupt-cells = <2>;
+ #address-cells = <0>;
reg = <0x0 0xff0a0000 0x0 0x1000>;
power-domains = <&zynqmp_firmware PD_GPIO>;
};
--
2.25.1


quanyang.wang
 

Hi Bruce,

On 7/27/21 9:28 PM, Bruce Ashfield wrote:
In message: [linux-yocto][linux-yocto v5.10/standard/sdkv5.10/xlnx-soc][PATCH 1/4] arm64: zynqmp: fix warning about lack of #interrupt-cells
on 27/07/2021 quanyang.wang@windriver.com wrote:

From: Quanyang Wang <quanyang.wang@windriver.com>

The interrupt controller nodes need #interrupt-cells property. When
building device-tree files with "DTC_FLAGS='-@'", there is warning
as below:

arch/arm64/boot/dts/xilinx/zynqmp.dtsi:450.38-460.5: Warning (interrupt_provider): /axi/interrupt-controller@f9010000: Missing #address-cells in interrupt provider
arch/arm64/boot/dts/xilinx/zynqmp.dtsi:720.23-731.5: Warning (interrupt_provider): /axi/gpio@ff0a0000: Missing #address-cells in interrupt provider

Since they have no children in the device-tree hierarchy, assign '0'
to the "interrupt-cells" property.
The commit message doesn't match the code. You are assigning to
the #address-cells property, not interrupt-cells. Or am I misreading ?
Thank you for your review. I will send a V2 with new commit message.

Thanks,

Quanyang


Bruce

Signed-off-by: Quanyang Wang <quanyang.wang@windriver.com>
---
arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 2 ++
1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
index 2e1ccd179d17d..8c2cad7816435 100644
--- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
+++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
@@ -451,6 +451,7 @@ fpd_dma_chan8: dma@fd570000 {
gic: interrupt-controller@f9010000 {
compatible = "arm,gic-400";
#interrupt-cells = <3>;
+ #address-cells = <0>;
reg = <0x0 0xf9010000 0x0 0x10000>,
<0x0 0xf9020000 0x0 0x20000>,
<0x0 0xf9040000 0x0 0x20000>,
@@ -665,6 +666,7 @@ gpio: gpio@ff0a0000 {
interrupts = <0 16 4>;
interrupt-controller;
#interrupt-cells = <2>;
+ #address-cells = <0>;
reg = <0x0 0xff0a0000 0x0 0x1000>;
power-domains = <&zynqmp_firmware PD_GPIO>;
};
--
2.25.1