<div dir="auto"><div><br><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Jul 3, 2019, 1:08 AM Adrian Bunk <<a href="mailto:bunk@stusta.de" target="_blank" rel="noreferrer">bunk@stusta.de</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Tue, Jul 02, 2019 at 03:21:32PM -0500, Joshua Watt wrote:<br>
> Updates bzip2 to version 1.0.7 to match master in oe-core. The patch to<br>
> change the path separator was properly upstreamed and hopefully will no<br>
> longer be necessary going forward.<br>
>...<br>
> +--- a/bzip2.c<br>
> ++++ b/bzip2.c<br>
> +@@ -128,7 +128,7 @@<br>
> + #if BZ_LCCWIN32<br>
> + #Â Â include <io.h><br>
> + #Â Â include <fcntl.h><br>
> +-#Â Â include <sys\stat.h><br>
> ++#Â Â include <sys/stat.h><br>
>...<br>
<br>
Why is this a bbappend at all?<br>
<br>
This should have been part of the package in oe-core from the beginning,<br>
and could still be added there right now.<br></blockquote></div></div><div dir="auto"><br></div><div dir="auto">Yes, that would be better. Unfortunately this was merged quickly to prevent breaking master with the upgrade in OE core. We can move the patch to OE core still, but it will require some more coordination to prevent breaking again.</div><div dir="auto"><br></div><div dir="auto">On the other hand, I did upstream the patch, so hopefully the next release of bzip2 will also allow us to delete the bbappend from meta-mingw</div><div dir="auto"><br></div><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
cu<br>
Adrian<br>
<br>
-- <br>
<br>
    "Is there not promise of rain?" Ling Tan asked suddenly out<br>
    of the darkness. There had been need of rain for many days.<br>
    "Only a promise," Lao Er said.<br>
                    Pearl S. Buck - Dragon Seed<br>
<br>
</blockquote></div></div></div>