<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Feb 7, 2019 at 9:44 AM Alejandro Del Castillo <<a href="mailto:alejandro.delcastillo@ni.com">alejandro.delcastillo@ni.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
<br>
On 2/7/19 11:36 AM, Scott Rifenbark wrote:<br>
> This change looks like it impacts documentation (i.e. <br>
> <a href="https://yoctoproject.org/docs/2.7/ref-manual/ref-manual.html#var-BAD_RECOMMENDATIONS" rel="noreferrer" target="_blank">https://yoctoproject.org/docs/2.7/ref-manual/ref-manual.html#var-BAD_RECOMMENDATIONS</a>.  <br>
> When will this change go into effect? <br>
<br>
I believe it doesn't. It is refactoring the opkg implementation to <br>
leverage a new opkg feature (--add-ignore-recommends), which is a more <br>
robust implementation. Should be transparent to users.<br></blockquote><div><br></div><div>Thank you for the clarification... I thought it might be a user option.</div><div> <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
> On Thu, Feb 7, 2019 at 7:58 AM Alejandro del Castillo <br>
> <<a href="mailto:alejandro.delcastillo@ni.com" target="_blank">alejandro.delcastillo@ni.com</a> <mailto:<a href="mailto:alejandro.delcastillo@ni.com" target="_blank">alejandro.delcastillo@ni.com</a>>> wrote:<br>
> <br>
>  Â  Â To be used for BAD_RECOMMENDATIONS feature.<br>
> <br>
>  Â  Â Signed-off-by: Alejandro del Castillo <<a href="mailto:alejandro.delcastillo@ni.com" target="_blank">alejandro.delcastillo@ni.com</a><br>
>  Â  Â <mailto:<a href="mailto:alejandro.delcastillo@ni.com" target="_blank">alejandro.delcastillo@ni.com</a>>><br>
>  Â  Â ---<br>
>  Â  Â  Â ...pkg-add-add-ignore-recommends-option.patch | 259 ++++++++++++++++++<br>
>  Â  Â  Â meta/recipes-devtools/opkg/<a href="http://opkg_0.4.0.bb" rel="noreferrer" target="_blank">opkg_0.4.0.bb</a><br>
>  Â  Â <<a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__opkg-5F0.4.0.bb&d=DwMFaQ&c=I_0YwoKy7z5LMTVdyO6YCiE2uzI1jjZZuIPelcSjixA&r=wNcrL2akRn6jfxhHaKavUrJB_C9JAMXtynjLd8ZzgXQ&m=8hd_9vew95YIf_VIv2QHNu2EFnc3G2WZ5KA2Upnv5j8&s=JvgzuAyAoVrkeSZAdWZUuIsFWQ8okApbCk1iiF13CDc&e=" rel="noreferrer" target="_blank">https://urldefense.proofpoint.com/v2/url?u=http-3A__opkg-5F0.4.0.bb&d=DwMFaQ&c=I_0YwoKy7z5LMTVdyO6YCiE2uzI1jjZZuIPelcSjixA&r=wNcrL2akRn6jfxhHaKavUrJB_C9JAMXtynjLd8ZzgXQ&m=8hd_9vew95YIf_VIv2QHNu2EFnc3G2WZ5KA2Upnv5j8&s=JvgzuAyAoVrkeSZAdWZUuIsFWQ8okApbCk1iiF13CDc&e=</a>> <br>
>  Â  Â  Â  Â  |  Â 1 +<br>
>  Â  Â  Â 2 files changed, 260 insertions(+)<br>
>  Â  Â  Â create mode 100644<br>
>  Â  Â meta/recipes-devtools/opkg/opkg/0001-libopkg-add-add-ignore-recommends-option.patch<br>
> <br>
>  Â  Â diff --git<br>
>  Â  Â a/meta/recipes-devtools/opkg/opkg/0001-libopkg-add-add-ignore-recommends-option.patch<br>
>  Â  Â b/meta/recipes-devtools/opkg/opkg/0001-libopkg-add-add-ignore-recommends-option.patch<br>
>  Â  Â new file mode 100644<br>
>  Â  Â index 0000000000..47d1b3c37e<br>
>  Â  Â --- /dev/null<br>
>  Â  Â +++<br>
>  Â  Â b/meta/recipes-devtools/opkg/opkg/0001-libopkg-add-add-ignore-recommends-option.patch<br>
>  Â  Â @@ -0,0 +1,259 @@<br>
>  Â  Â +From 64aa98646a17c299bf37af2975b98daf5d7d30b4 Mon Sep 17 00:00:00 2001<br>
>  Â  Â +From: Alejandro del Castillo <<a href="mailto:alejandro.delcastillo@ni.com" target="_blank">alejandro.delcastillo@ni.com</a><br>
>  Â  Â <mailto:<a href="mailto:alejandro.delcastillo@ni.com" target="_blank">alejandro.delcastillo@ni.com</a>>><br>
>  Â  Â +Date: Thu, 31 Jan 2019 18:16:08 -0600<br>
>  Â  Â +Subject: [PATCH] libopkg: add --add-ignore-recommends option<br>
>  Â  Â +<br>
>  Â  Â +Add option to ignore specific recommended packages. On the libsolv<br>
>  Â  Â +backed, this feature will only work on libsolv version > 0.7.2 [1].<br>
>  Â  Â +<br>
>  Â  Â +[1]<br>
>  Â  Â <a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_openSUSE_libsolv_issues_254&d=DwIBaQ&c=I_0YwoKy7z5LMTVdyO6YCiE2uzI1jjZZuIPelcSjixA&r=wNcrL2akRn6jfxhHaKavUrJB_C9JAMXtynjLd8ZzgXQ&m=GObNHzFJpWpf_PripIrf-K2RhsktYdAUEieAJexXOKw&s=3G-meChUqClFggFPqsrAxIZBfLnRKIHm62Uuy1X6nQQ&e=" rel="noreferrer" target="_blank">https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_openSUSE_libsolv_issues_254&d=DwIBaQ&c=I_0YwoKy7z5LMTVdyO6YCiE2uzI1jjZZuIPelcSjixA&r=wNcrL2akRn6jfxhHaKavUrJB_C9JAMXtynjLd8ZzgXQ&m=GObNHzFJpWpf_PripIrf-K2RhsktYdAUEieAJexXOKw&s=3G-meChUqClFggFPqsrAxIZBfLnRKIHm62Uuy1X6nQQ&e=</a><br>
>  Â  Â +<br>
>  Â  Â +Signed-off-by: Alejandro del Castillo <<a href="mailto:alejandro.delcastillo@ni.com" target="_blank">alejandro.delcastillo@ni.com</a><br>
>  Â  Â <mailto:<a href="mailto:alejandro.delcastillo@ni.com" target="_blank">alejandro.delcastillo@ni.com</a>>><br>
>  Â  Â +<br>
>  Â  Â +Upstream-Status: Accepted<br>
>  Â  Â +---<br>
>  Â  Â + libopkg/opkg_conf.c  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â |  2 +<br>
>  Â  Â + libopkg/opkg_conf.h  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â |  1 +<br>
>  Â  Â + .../solvers/internal/pkg_depends_internal.c  Â |  3 +-<br>
>  Â  Â + libopkg/solvers/libsolv/opkg_solver_libsolv.c | 21 ++++++-<br>
>  Â  Â + man/<a href="http://opkg.1.in" rel="noreferrer" target="_blank">opkg.1.in</a><br>
>  Â  Â <<a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__opkg.1.in&d=DwMFaQ&c=I_0YwoKy7z5LMTVdyO6YCiE2uzI1jjZZuIPelcSjixA&r=wNcrL2akRn6jfxhHaKavUrJB_C9JAMXtynjLd8ZzgXQ&m=8hd_9vew95YIf_VIv2QHNu2EFnc3G2WZ5KA2Upnv5j8&s=8yIWRVT6JV0YnkHzVgeo8pAkiFPM4xz8y9APvxobmhY&e=" rel="noreferrer" target="_blank">https://urldefense.proofpoint.com/v2/url?u=http-3A__opkg.1.in&d=DwMFaQ&c=I_0YwoKy7z5LMTVdyO6YCiE2uzI1jjZZuIPelcSjixA&r=wNcrL2akRn6jfxhHaKavUrJB_C9JAMXtynjLd8ZzgXQ&m=8hd_9vew95YIf_VIv2QHNu2EFnc3G2WZ5KA2Upnv5j8&s=8yIWRVT6JV0YnkHzVgeo8pAkiFPM4xz8y9APvxobmhY&e=</a>> <br>
>  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â |  3 +<br>
>  Â  Â + src/opkg.c  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  |  6 ++<br>
>  Â  Â + tests/Makefile  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  |  1 +<br>
>  Â  Â + tests/core/43_add_ignore_recommends.py  Â  Â  Â  | 62 +++++++++++++++++++<br>
>  Â  Â + 8 files changed, 97 insertions(+), 2 deletions(-)<br>
>  Â  Â + create mode 100755 tests/core/43_add_ignore_recommends.py<br>
>  Â  Â +<br>
>  Â  Â +diff --git a/libopkg/opkg_conf.c b/libopkg/opkg_conf.c<br>
>  Â  Â +index 06880a1..f2330cd 100644<br>
>  Â  Â +--- a/libopkg/opkg_conf.c<br>
>  Â  Â ++++ b/libopkg/opkg_conf.c<br>
>  Â  Â +@@ -597,6 +597,7 @@ int opkg_conf_init(void)<br>
>  Â  Â +  Â  Â pkg_dest_list_init(&opkg_config->tmp_dest_list);<br>
>  Â  Â +  Â  Â nv_pair_list_init(&opkg_config->arch_list);<br>
>  Â  Â +  Â  Â str_list_init(&opkg_config->exclude_list);<br>
>  Â  Â ++  Â  str_list_init(&opkg_config->ignore_recommends_list);<br>
>  Â  Â +<br>
>  Â  Â +  Â  Â return 0;<br>
>  Â  Â + }<br>
>  Â  Â +@@ -938,6 +939,7 @@ void opkg_conf_deinit(void)<br>
>  Â  Â +  Â  Â pkg_dest_list_deinit(&opkg_config->pkg_dest_list);<br>
>  Â  Â +  Â  Â nv_pair_list_deinit(&opkg_config->arch_list);<br>
>  Â  Â +  Â  Â str_list_deinit(&opkg_config->exclude_list);<br>
>  Â  Â ++  Â  str_list_deinit(&opkg_config->ignore_recommends_list);<br>
>  Â  Â +<br>
>  Â  Â +  Â  Â if (opkg_config->verbosity >= DEBUG) {<br>
>  Â  Â +  Â  Â  Â  Â hash_print_stats(&opkg_config->pkg_hash);<br>
>  Â  Â +diff --git a/libopkg/opkg_conf.h b/libopkg/opkg_conf.h<br>
>  Â  Â +index eb56a29..316c500 100644<br>
>  Â  Â +--- a/libopkg/opkg_conf.h<br>
>  Â  Â ++++ b/libopkg/opkg_conf.h<br>
>  Â  Â +@@ -61,6 +61,7 @@ typedef struct opkg_conf {<br>
>  Â  Â +  Â  Â pkg_dest_list_t tmp_dest_list;<br>
>  Â  Â +  Â  Â nv_pair_list_t arch_list;<br>
>  Â  Â +  Â  Â str_list_t exclude_list;<br>
>  Â  Â ++  Â  str_list_t ignore_recommends_list;<br>
>  Â  Â +<br>
>  Â  Â +  Â  Â int restrict_to_default_dest;<br>
>  Â  Â +  Â  Â pkg_dest_t *default_dest;<br>
>  Â  Â +diff --git a/libopkg/solvers/internal/pkg_depends_internal.c<br>
>  Â  Â b/libopkg/solvers/internal/pkg_depends_internal.c<br>
>  Â  Â +index cd56d84..5deee70 100644<br>
>  Â  Â +--- a/libopkg/solvers/internal/pkg_depends_internal.c<br>
>  Â  Â ++++ b/libopkg/solvers/internal/pkg_depends_internal.c<br>
>  Â  Â +@@ -228,7 +228,8 @@ int<br>
>  Â  Â pkg_hash_fetch_unsatisfied_dependencies(pkg_t *pkg,<br>
>  Â  Â +  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â || compound_depend->type == SUGGEST)<br>
>  Â  Â +  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â && (satisfying_pkg->state_want == SW_DEINSTALL<br>
>  Â  Â +  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â || satisfying_pkg->state_want == SW_PURGE<br>
>  Â  Â +-  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  || opkg_config->no_install_recommends);<br>
>  Â  Â ++  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  || opkg_config->no_install_recommends<br>
>  Â  Â ++  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  ||<br>
>  Â  Â str_list_contains(&opkg_config->ignore_recommends_list,<br>
>  Â  Â satisfying_pkg->name));<br>
>  Â  Â +  Â  Â  Â  Â  Â  Â  Â  Â if (ignore) {<br>
>  Â  Â +  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â opkg_msg(NOTICE,<br>
>  Â  Â +  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  "%s: ignoring recommendation for "<br>
>  Â  Â +diff --git a/libopkg/solvers/libsolv/opkg_solver_libsolv.c<br>
>  Â  Â b/libopkg/solvers/libsolv/opkg_solver_libsolv.c<br>
>  Â  Â +index 2b27e3a..403e07b 100644<br>
>  Â  Â +--- a/libopkg/solvers/libsolv/opkg_solver_libsolv.c<br>
>  Â  Â ++++ b/libopkg/solvers/libsolv/opkg_solver_libsolv.c<br>
>  Â  Â +@@ -484,6 +484,7 @@ static void pkg2solvable(pkg_t *pkg, Solvable<br>
>  Â  Â *solvable_out)<br>
>  Â  Â + static void populate_installed_repo(libsolv_solver_t *libsolv_solver)<br>
>  Â  Â + {<br>
>  Â  Â +  Â  Â int i;<br>
>  Â  Â ++  Â  Id what;<br>
>  Â  Â +<br>
>  Â  Â +  Â  Â pkg_vec_t *installed_pkgs = pkg_vec_alloc();<br>
>  Â  Â +<br>
>  Â  Â +@@ -507,6 +508,15 @@ static void<br>
>  Â  Â populate_installed_repo(libsolv_solver_t *libsolv_solver)<br>
>  Â  Â +  Â  Â  Â  Â /* set solvable attributes */<br>
>  Â  Â +  Â  Â  Â  Â pkg2solvable(pkg, solvable);<br>
>  Â  Â +<br>
>  Â  Â ++  Â  Â  Â  /* if the package is in ignore-recommends-list, disfavor<br>
>  Â  Â installation */<br>
>  Â  Â ++  Â  Â  Â  if<br>
>  Â  Â (str_list_contains(&opkg_config->ignore_recommends_list, pkg->name)) {<br>
>  Â  Â ++  Â  Â  Â  Â  Â  opkg_message(NOTICE, "Disfavor package: %s\n",<br>
>  Â  Â ++  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â pkg->name);<br>
>  Â  Â ++  Â  Â  Â  Â  Â  what = pool_str2id(libsolv_solver->pool, pkg->name, 1);<br>
>  Â  Â ++  Â  Â  Â  Â  Â  queue_push2(&libsolv_solver->solver_jobs,<br>
>  Â  Â SOLVER_SOLVABLE_NAME<br>
>  Â  Â ++  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  | SOLVER_DISFAVOR, what);<br>
>  Â  Â ++  Â  Â  Â  }<br>
>  Â  Â ++<br>
>  Â  Â +  Â  Â  Â  Â /* if the package is not autoinstalled, mark it as user<br>
>  Â  Â installed */<br>
>  Â  Â +  Â  Â  Â  Â if (!pkg->auto_installed)<br>
>  Â  Â +  Â  Â  Â  Â  Â  Â queue_push2(&libsolv_solver->solver_jobs, SOLVER_SOLVABLE<br>
>  Â  Â +@@ -539,7 +549,7 @@ static void<br>
>  Â  Â populate_available_repos(libsolv_solver_t *libsolv_solver)<br>
>  Â  Â + {<br>
>  Â  Â +  Â  Â int i;<br>
>  Â  Â +  Â  Â Solvable *solvable;<br>
>  Â  Â +-  Â  Id solvable_id;<br>
>  Â  Â ++  Â  Id solvable_id, what;<br>
>  Â  Â +<br>
>  Â  Â +  Â  Â pkg_vec_t *available_pkgs = pkg_vec_alloc();<br>
>  Â  Â +<br>
>  Â  Â +@@ -608,6 +618,15 @@ static void<br>
>  Â  Â populate_available_repos(libsolv_solver_t *libsolv_solver)<br>
>  Â  Â +  Â  Â  Â  Â solvable = pool_id2solvable(libsolv_solver->pool,<br>
>  Â  Â solvable_id);<br>
>  Â  Â +  Â  Â  Â  Â pkg2solvable(pkg, solvable);<br>
>  Â  Â +<br>
>  Â  Â ++  Â  Â  Â  /* if the package is in ignore-recommends-list, disfavor<br>
>  Â  Â installation */<br>
>  Â  Â ++  Â  Â  Â  if<br>
>  Â  Â (str_list_contains(&opkg_config->ignore_recommends_list, pkg->name)) {<br>
>  Â  Â ++  Â  Â  Â  Â  Â  opkg_message(NOTICE, "Disfavor package: %s\n",<br>
>  Â  Â ++  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â pkg->name);<br>
>  Â  Â ++  Â  Â  Â  Â  Â  what = pool_str2id(libsolv_solver->pool, pkg->name, 1);<br>
>  Â  Â ++  Â  Â  Â  Â  Â  queue_push2(&libsolv_solver->solver_jobs,<br>
>  Â  Â SOLVER_SOLVABLE_NAME<br>
>  Â  Â ++  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  | SOLVER_DISFAVOR, what);<br>
>  Â  Â ++  Â  Â  Â  }<br>
>  Â  Â ++<br>
>  Â  Â +  Â  Â  Â  Â /* if the --force-depends option is specified make<br>
>  Â  Â dependencies weak */<br>
>  Â  Â +  Â  Â  Â  Â if (opkg_config->force_depends)<br>
>  Â  Â +  Â  Â  Â  Â  Â  Â queue_push2(&libsolv_solver->solver_jobs, SOLVER_SOLVABLE<br>
>  Â  Â +diff --git a/man/<a href="http://opkg.1.in" rel="noreferrer" target="_blank">opkg.1.in</a><br>
>  Â  Â <<a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__opkg.1.in&d=DwMFaQ&c=I_0YwoKy7z5LMTVdyO6YCiE2uzI1jjZZuIPelcSjixA&r=wNcrL2akRn6jfxhHaKavUrJB_C9JAMXtynjLd8ZzgXQ&m=8hd_9vew95YIf_VIv2QHNu2EFnc3G2WZ5KA2Upnv5j8&s=8yIWRVT6JV0YnkHzVgeo8pAkiFPM4xz8y9APvxobmhY&e=" rel="noreferrer" target="_blank">https://urldefense.proofpoint.com/v2/url?u=http-3A__opkg.1.in&d=DwMFaQ&c=I_0YwoKy7z5LMTVdyO6YCiE2uzI1jjZZuIPelcSjixA&r=wNcrL2akRn6jfxhHaKavUrJB_C9JAMXtynjLd8ZzgXQ&m=8hd_9vew95YIf_VIv2QHNu2EFnc3G2WZ5KA2Upnv5j8&s=8yIWRVT6JV0YnkHzVgeo8pAkiFPM4xz8y9APvxobmhY&e=</a>><br>
>  Â  Â b/man/<a href="http://opkg.1.in" rel="noreferrer" target="_blank">opkg.1.in</a><br>
>  Â  Â <<a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__opkg.1.in&d=DwMFaQ&c=I_0YwoKy7z5LMTVdyO6YCiE2uzI1jjZZuIPelcSjixA&r=wNcrL2akRn6jfxhHaKavUrJB_C9JAMXtynjLd8ZzgXQ&m=8hd_9vew95YIf_VIv2QHNu2EFnc3G2WZ5KA2Upnv5j8&s=8yIWRVT6JV0YnkHzVgeo8pAkiFPM4xz8y9APvxobmhY&e=" rel="noreferrer" target="_blank">https://urldefense.proofpoint.com/v2/url?u=http-3A__opkg.1.in&d=DwMFaQ&c=I_0YwoKy7z5LMTVdyO6YCiE2uzI1jjZZuIPelcSjixA&r=wNcrL2akRn6jfxhHaKavUrJB_C9JAMXtynjLd8ZzgXQ&m=8hd_9vew95YIf_VIv2QHNu2EFnc3G2WZ5KA2Upnv5j8&s=8yIWRVT6JV0YnkHzVgeo8pAkiFPM4xz8y9APvxobmhY&e=</a>><br>
>  Â  Â +index 27fa9c1..f192c3b 100644<br>
>  Â  Â +--- a/man/<a href="http://opkg.1.in" rel="noreferrer" target="_blank">opkg.1.in</a><br>
>  Â  Â <<a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__opkg.1.in&d=DwMFaQ&c=I_0YwoKy7z5LMTVdyO6YCiE2uzI1jjZZuIPelcSjixA&r=wNcrL2akRn6jfxhHaKavUrJB_C9JAMXtynjLd8ZzgXQ&m=8hd_9vew95YIf_VIv2QHNu2EFnc3G2WZ5KA2Upnv5j8&s=8yIWRVT6JV0YnkHzVgeo8pAkiFPM4xz8y9APvxobmhY&e=" rel="noreferrer" target="_blank">https://urldefense.proofpoint.com/v2/url?u=http-3A__opkg.1.in&d=DwMFaQ&c=I_0YwoKy7z5LMTVdyO6YCiE2uzI1jjZZuIPelcSjixA&r=wNcrL2akRn6jfxhHaKavUrJB_C9JAMXtynjLd8ZzgXQ&m=8hd_9vew95YIf_VIv2QHNu2EFnc3G2WZ5KA2Upnv5j8&s=8yIWRVT6JV0YnkHzVgeo8pAkiFPM4xz8y9APvxobmhY&e=</a>><br>
>  Â  Â ++++ b/man/<a href="http://opkg.1.in" rel="noreferrer" target="_blank">opkg.1.in</a><br>
>  Â  Â <<a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__opkg.1.in&d=DwMFaQ&c=I_0YwoKy7z5LMTVdyO6YCiE2uzI1jjZZuIPelcSjixA&r=wNcrL2akRn6jfxhHaKavUrJB_C9JAMXtynjLd8ZzgXQ&m=8hd_9vew95YIf_VIv2QHNu2EFnc3G2WZ5KA2Upnv5j8&s=8yIWRVT6JV0YnkHzVgeo8pAkiFPM4xz8y9APvxobmhY&e=" rel="noreferrer" target="_blank">https://urldefense.proofpoint.com/v2/url?u=http-3A__opkg.1.in&d=DwMFaQ&c=I_0YwoKy7z5LMTVdyO6YCiE2uzI1jjZZuIPelcSjixA&r=wNcrL2akRn6jfxhHaKavUrJB_C9JAMXtynjLd8ZzgXQ&m=8hd_9vew95YIf_VIv2QHNu2EFnc3G2WZ5KA2Upnv5j8&s=8yIWRVT6JV0YnkHzVgeo8pAkiFPM4xz8y9APvxobmhY&e=</a>><br>
>  Â  Â +@@ -162,6 +162,9 @@ priority \fIprio\fP. Lower priorities take<br>
>  Â  Â precedence.<br>
>  Â  Â + \fB\--add-exclude <\fIname\fP>\fR<br>
>  Â  Â + Register package to be excluded from install<br>
>  Â  Â + .TP<br>
>  Â  Â ++\fB\--add-ignore-recommends <\fIname\fP>\fR<br>
>  Â  Â ++Register package to be ignored as a recomendee<br>
>  Â  Â ++.TP<br>
>  Â  Â + \fB\--prefer-arch-to-version\fR<br>
>  Â  Â + Use the architecture priority package rather than the higher version<br>
>  Â  Â + one if more than one candidate is found.<br>
>  Â  Â +diff --git a/src/opkg.c b/src/opkg.c<br>
>  Â  Â +index 650e278..3c93a3b 100644<br>
>  Â  Â +--- a/src/opkg.c<br>
>  Â  Â ++++ b/src/opkg.c<br>
>  Â  Â +@@ -51,6 +51,7 @@ enum {<br>
>  Â  Â +  Â  Â ARGS_OPT_ADD_DEST,<br>
>  Â  Â +  Â  Â ARGS_OPT_SIZE,<br>
>  Â  Â +  Â  Â ARGS_OPT_ADD_EXCLUDE,<br>
>  Â  Â ++  Â  ARGS_OPT_ADD_IGNORE_RECOMMENDS,<br>
>  Â  Â +  Â  Â ARGS_OPT_NOACTION,<br>
>  Â  Â +  Â  Â ARGS_OPT_DOWNLOAD_ONLY,<br>
>  Â  Â +  Â  Â ARGS_OPT_NODEPS,<br>
>  Â  Â +@@ -112,6 +113,7 @@ static struct option long_options[] = {<br>
>  Â  Â +  Â  Â {"add-dest", 1, 0, ARGS_OPT_ADD_DEST},<br>
>  Â  Â +  Â  Â {"size", 0, 0, ARGS_OPT_SIZE},<br>
>  Â  Â +  Â  Â {"add-exclude", 1, 0, ARGS_OPT_ADD_EXCLUDE},<br>
>  Â  Â ++  Â  {"add-ignore-recommends", 1, 0, ARGS_OPT_ADD_IGNORE_RECOMMENDS},<br>
>  Â  Â +  Â  Â {"test", 0, 0, ARGS_OPT_NOACTION},<br>
>  Â  Â +  Â  Â {"tmp-dir", 1, 0, 't'},<br>
>  Â  Â +  Â  Â {"tmp_dir", 1, 0, 't'},<br>
>  Â  Â +@@ -234,6 +236,9 @@ static int args_parse(int argc, char *argv[])<br>
>  Â  Â +  Â  Â  Â  Â case ARGS_OPT_ADD_EXCLUDE:<br>
>  Â  Â +  Â  Â  Â  Â  Â  Â str_list_append(&opkg_config->exclude_list, optarg);<br>
>  Â  Â +  Â  Â  Â  Â  Â  Â break;<br>
>  Â  Â ++  Â  Â  Â  case ARGS_OPT_ADD_IGNORE_RECOMMENDS:<br>
>  Â  Â ++  Â  Â  Â  Â  Â  str_list_append(&opkg_config->ignore_recommends_list,<br>
>  Â  Â optarg);<br>
>  Â  Â ++  Â  Â  Â  Â  Â  break;<br>
>  Â  Â +  Â  Â  Â  Â case ARGS_OPT_SIZE:<br>
>  Â  Â +  Â  Â  Â  Â  Â  Â opkg_config->size = 1;<br>
>  Â  Â +  Â  Â  Â  Â  Â  Â break;<br>
>  Â  Â +@@ -343,6 +348,7 @@ static void usage()<br>
>  Â  Â +  Â  Â printf("\t--add-dest <name>:<path>  Â  Â  Â  Register destination<br>
>  Â  Â with given path\n");<br>
>  Â  Â +  Â  Â printf("\t--add-arch <arch>:<prio>  Â  Â  Â  Register<br>
>  Â  Â architecture with given priority\n");<br>
>  Â  Â +  Â  Â printf("\t--add-exclude <name>  Â  Â  Â  Â  Â  Register package to<br>
>  Â  Â be excluded from install\n");<br>
>  Â  Â ++  Â  printf("\t--add-ignore-recommends <name>  Register package to<br>
>  Â  Â be ignored as a recomendee\n");<br>
>  Â  Â +  Â  Â printf("\t--prefer-arch-to-version  Â  Â  Â  Use the architecture<br>
>  Â  Â priority package rather\n");<br>
>  Â  Â +  Â  Â printf("\t  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  than the higher<br>
>  Â  Â version one if more\n");<br>
>  Â  Â +  Â  Â printf("\t  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  than one candidate<br>
>  Â  Â is found.\n");<br>
>  Â  Â +diff --git a/tests/Makefile b/tests/Makefile<br>
>  Â  Â +index 8e5be08..799816d 100644<br>
>  Â  Â +--- a/tests/Makefile<br>
>  Â  Â ++++ b/tests/Makefile<br>
>  Â  Â +@@ -42,6 +42,7 @@ REGRESSION_TESTS := core/01_install.py \<br>
>  Â  Â +  Â  Â  Â  Â  Â  Â  Â  Â  Â core/40_arch.py \<br>
>  Â  Â +  Â  Â  Â  Â  Â  Â  Â  Â  Â core/41_info_fields.py \<br>
>  Â  Â +  Â  Â  Â  Â  Â  Â  Â  Â  Â core/42_info_description.py \<br>
>  Â  Â ++  Â  Â  Â  Â  Â  Â  Â  Â  core/43_add_ignore_recommends.py \<br>
>  Â  Â +  Â  Â  Â  Â  Â  Â  Â  Â  Â regress/issue26.py \<br>
>  Â  Â +  Â  Â  Â  Â  Â  Â  Â  Â  Â regress/issue31.py \<br>
>  Â  Â +  Â  Â  Â  Â  Â  Â  Â  Â  Â regress/issue32.py \<br>
>  Â  Â +diff --git a/tests/core/43_add_ignore_recommends.py<br>
>  Â  Â b/tests/core/43_add_ignore_recommends.py<br>
>  Â  Â +new file mode 100755<br>
>  Â  Â +index 0000000..7da0096<br>
>  Â  Â +--- /dev/null<br>
>  Â  Â ++++ b/tests/core/43_add_ignore_recommends.py<br>
>  Â  Â +@@ -0,0 +1,62 @@<br>
>  Â  Â ++#! /usr/bin/env python3<br>
>  Â  Â ++#<br>
>  Â  Â ++# Create package 'a' (1.0) which Recommends 'c'.<br>
>  Â  Â ++# Install 'a' with --add-ignore-recommends 'c'.<br>
>  Â  Â ++# Check that only 'a' (1.0) is installed.<br>
>  Â  Â ++# Create package 'b' which Depends on 'c'.<br>
>  Â  Â ++# Install 'a' & 'b', with --add-ignore-recommends 'c'.<br>
>  Â  Â ++# Verify that 'a','b' & 'c' are installed.<br>
>  Â  Â ++# Uninstall 'b' & 'c'.<br>
>  Â  Â ++# Create package 'a' (2.0), which Recommends 'c'.<br>
>  Â  Â ++# Upgrade 'a' with --add-ignore-recommends 'c'<br>
>  Â  Â ++# Verify that only 'a' (2.0) is installed<br>
>  Â  Â ++#<br>
>  Â  Â ++<br>
>  Â  Â ++import os<br>
>  Â  Â ++import opk, cfg, opkgcl<br>
>  Â  Â ++<br>
>  Â  Â ++opk.regress_init()<br>
>  Â  Â ++o = opk.OpkGroup()<br>
>  Â  Â ++<br>
>  Â  Â ++o.add(Package='a', Recommends='c', Version='1.0')<br>
>  Â  Â ++o.add(Package='b', Depends='c')<br>
>  Â  Â ++o.add(Package='c')<br>
>  Â  Â ++o.write_opk()<br>
>  Â  Â ++o.write_list()<br>
>  Â  Â ++<br>
>  Â  Â ++opkgcl.update()<br>
>  Â  Â ++<br>
>  Â  Â ++opkgcl.install('a', '--add-ignore-recommends c')<br>
>  Â  Â ++<br>
>  Â  Â ++if not opkgcl.is_installed('a'):<br>
>  Â  Â ++  Â  Â  opk.fail("Package 'a' installed but reports as not installed.")<br>
>  Â  Â ++<br>
>  Â  Â ++if opkgcl.is_installed('c'):<br>
>  Â  Â ++  Â  Â  opk.xfail("[libsolv<0.7.3] Package 'c' should not have been<br>
>  Â  Â installed since it was in --add-ignore-recommends.")<br>
>  Â  Â ++<br>
>  Â  Â ++opkgcl.remove('a')<br>
>  Â  Â ++opkgcl.install('a b', '--add-ignore-recommends c')<br>
>  Â  Â ++<br>
>  Â  Â ++if not opkgcl.is_installed('a'):<br>
>  Â  Â ++  Â  Â  opk.fail("Package 'a' installed but reports as not installed.")<br>
>  Â  Â ++<br>
>  Â  Â ++if not opkgcl.is_installed('b'):<br>
>  Â  Â ++  Â  Â  opk.fail("Package 'b' installed but reports as not installed.")<br>
>  Â  Â ++<br>
>  Â  Â ++if not opkgcl.is_installed('c'):<br>
>  Â  Â ++  Â  Â  opk.fail("Package 'c' should have been installed since 'b'<br>
>  Â  Â depends on it.")<br>
>  Â  Â ++<br>
>  Â  Â ++opkgcl.remove('b c', '--force-depends')<br>
>  Â  Â ++o.add(Package='a', Recommends='c', Version='2.0')<br>
>  Â  Â ++o.write_opk()<br>
>  Â  Â ++o.write_list()<br>
>  Â  Â ++<br>
>  Â  Â ++opkgcl.update()<br>
>  Â  Â ++<br>
>  Â  Â ++opkgcl.upgrade('a', '--add-ignore-recommends c')<br>
>  Â  Â ++<br>
>  Â  Â ++if not opkgcl.is_installed('a', '2.0'):<br>
>  Â  Â ++  Â  Â  opk.fail("Package 'a (2.0)' installed but reports as not<br>
>  Â  Â installed.")<br>
>  Â  Â ++<br>
>  Â  Â ++if opkgcl.is_installed('c'):<br>
>  Â  Â ++  Â  Â  opk.fail("Package 'c' should not have been installed since<br>
>  Â  Â it was in --add-ignore-recommends.")<br>
>  Â  Â +--<br>
>  Â  Â +2.20.1<br>
>  Â  Â +<br>
>  Â  Â diff --git a/meta/recipes-devtools/opkg/<a href="http://opkg_0.4.0.bb" rel="noreferrer" target="_blank">opkg_0.4.0.bb</a><br>
>  Â  Â <<a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__opkg-5F0.4.0.bb&d=DwMFaQ&c=I_0YwoKy7z5LMTVdyO6YCiE2uzI1jjZZuIPelcSjixA&r=wNcrL2akRn6jfxhHaKavUrJB_C9JAMXtynjLd8ZzgXQ&m=8hd_9vew95YIf_VIv2QHNu2EFnc3G2WZ5KA2Upnv5j8&s=JvgzuAyAoVrkeSZAdWZUuIsFWQ8okApbCk1iiF13CDc&e=" rel="noreferrer" target="_blank">https://urldefense.proofpoint.com/v2/url?u=http-3A__opkg-5F0.4.0.bb&d=DwMFaQ&c=I_0YwoKy7z5LMTVdyO6YCiE2uzI1jjZZuIPelcSjixA&r=wNcrL2akRn6jfxhHaKavUrJB_C9JAMXtynjLd8ZzgXQ&m=8hd_9vew95YIf_VIv2QHNu2EFnc3G2WZ5KA2Upnv5j8&s=JvgzuAyAoVrkeSZAdWZUuIsFWQ8okApbCk1iiF13CDc&e=</a>><br>
>  Â  Â b/meta/recipes-devtools/opkg/<a href="http://opkg_0.4.0.bb" rel="noreferrer" target="_blank">opkg_0.4.0.bb</a><br>
>  Â  Â <<a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__opkg-5F0.4.0.bb&d=DwMFaQ&c=I_0YwoKy7z5LMTVdyO6YCiE2uzI1jjZZuIPelcSjixA&r=wNcrL2akRn6jfxhHaKavUrJB_C9JAMXtynjLd8ZzgXQ&m=8hd_9vew95YIf_VIv2QHNu2EFnc3G2WZ5KA2Upnv5j8&s=JvgzuAyAoVrkeSZAdWZUuIsFWQ8okApbCk1iiF13CDc&e=" rel="noreferrer" target="_blank">https://urldefense.proofpoint.com/v2/url?u=http-3A__opkg-5F0.4.0.bb&d=DwMFaQ&c=I_0YwoKy7z5LMTVdyO6YCiE2uzI1jjZZuIPelcSjixA&r=wNcrL2akRn6jfxhHaKavUrJB_C9JAMXtynjLd8ZzgXQ&m=8hd_9vew95YIf_VIv2QHNu2EFnc3G2WZ5KA2Upnv5j8&s=JvgzuAyAoVrkeSZAdWZUuIsFWQ8okApbCk1iiF13CDc&e=</a>><br>
>  Â  Â index 9b7cf3f596..a2329d3e71 100644<br>
>  Â  Â --- a/meta/recipes-devtools/opkg/<a href="http://opkg_0.4.0.bb" rel="noreferrer" target="_blank">opkg_0.4.0.bb</a><br>
>  Â  Â <<a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__opkg-5F0.4.0.bb&d=DwMFaQ&c=I_0YwoKy7z5LMTVdyO6YCiE2uzI1jjZZuIPelcSjixA&r=wNcrL2akRn6jfxhHaKavUrJB_C9JAMXtynjLd8ZzgXQ&m=8hd_9vew95YIf_VIv2QHNu2EFnc3G2WZ5KA2Upnv5j8&s=JvgzuAyAoVrkeSZAdWZUuIsFWQ8okApbCk1iiF13CDc&e=" rel="noreferrer" target="_blank">https://urldefense.proofpoint.com/v2/url?u=http-3A__opkg-5F0.4.0.bb&d=DwMFaQ&c=I_0YwoKy7z5LMTVdyO6YCiE2uzI1jjZZuIPelcSjixA&r=wNcrL2akRn6jfxhHaKavUrJB_C9JAMXtynjLd8ZzgXQ&m=8hd_9vew95YIf_VIv2QHNu2EFnc3G2WZ5KA2Upnv5j8&s=JvgzuAyAoVrkeSZAdWZUuIsFWQ8okApbCk1iiF13CDc&e=</a>><br>
>  Â  Â +++ b/meta/recipes-devtools/opkg/<a href="http://opkg_0.4.0.bb" rel="noreferrer" target="_blank">opkg_0.4.0.bb</a><br>
>  Â  Â <<a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__opkg-5F0.4.0.bb&d=DwMFaQ&c=I_0YwoKy7z5LMTVdyO6YCiE2uzI1jjZZuIPelcSjixA&r=wNcrL2akRn6jfxhHaKavUrJB_C9JAMXtynjLd8ZzgXQ&m=8hd_9vew95YIf_VIv2QHNu2EFnc3G2WZ5KA2Upnv5j8&s=JvgzuAyAoVrkeSZAdWZUuIsFWQ8okApbCk1iiF13CDc&e=" rel="noreferrer" target="_blank">https://urldefense.proofpoint.com/v2/url?u=http-3A__opkg-5F0.4.0.bb&d=DwMFaQ&c=I_0YwoKy7z5LMTVdyO6YCiE2uzI1jjZZuIPelcSjixA&r=wNcrL2akRn6jfxhHaKavUrJB_C9JAMXtynjLd8ZzgXQ&m=8hd_9vew95YIf_VIv2QHNu2EFnc3G2WZ5KA2Upnv5j8&s=JvgzuAyAoVrkeSZAdWZUuIsFWQ8okApbCk1iiF13CDc&e=</a>><br>
>  Â  Â @@ -14,6 +14,7 @@ PE = "1"<br>
>  Â  Â  Â SRC_URI =<br>
>  Â  Â "<a href="http://downloads.yoctoproject.org/releases/$%7BBPN%7D/$%7BBPN%7D-$%7BPV%7D.tar.gz" rel="noreferrer" target="_blank">http://downloads.yoctoproject.org/releases/${BPN}/${BPN}-${PV}.tar.gz</a><br>
>  Â  Â <<a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__downloads.yoctoproject.org_releases_-24-257BBPN-257D_-24-257BBPN-257D-2D-24-257BPV-257D.tar.gz&d=DwMFaQ&c=I_0YwoKy7z5LMTVdyO6YCiE2uzI1jjZZuIPelcSjixA&r=wNcrL2akRn6jfxhHaKavUrJB_C9JAMXtynjLd8ZzgXQ&m=8hd_9vew95YIf_VIv2QHNu2EFnc3G2WZ5KA2Upnv5j8&s=YLvorPjD5Y4WlqpYdjRMCkzwnh_cz-C6op19u5O23b8&e=" rel="noreferrer" target="_blank">https://urldefense.proofpoint.com/v2/url?u=http-3A__downloads.yoctoproject.org_releases_-24-257BBPN-257D_-24-257BBPN-257D-2D-24-257BPV-257D.tar.gz&d=DwMFaQ&c=I_0YwoKy7z5LMTVdyO6YCiE2uzI1jjZZuIPelcSjixA&r=wNcrL2akRn6jfxhHaKavUrJB_C9JAMXtynjLd8ZzgXQ&m=8hd_9vew95YIf_VIv2QHNu2EFnc3G2WZ5KA2Upnv5j8&s=YLvorPjD5Y4WlqpYdjRMCkzwnh_cz-C6op19u5O23b8&e=</a>><br>
>  Â  Â \<br>
>  Â  Â  Â  Â  Â  Â  Â  Â  file://opkg.conf \<br>
>  Â  Â  Â  Â  Â  Â  Â  Â <br>
>  Â  Â file://0001-opkg_conf-create-opkg.lock-in-run-instead-of-var-run.patch \<br>
>  Â  Â +  Â  Â  Â  Â  Â file://0001-libopkg-add-add-ignore-recommends-option.patch \<br>
>  Â  Â  Â "<br>
> <br>
>  Â  Â  Â SRC_URI[md5sum] = "ae51d95fee599bb4dce08453529158f5"<br>
>  Â  Â -- <br>
>  Â  Â 2.20.1<br>
> <br>
>  Â  Â -- <br>
>  Â  Â _______________________________________________<br>
>  Â  Â Openembedded-core mailing list<br>
>  Â  Â <a href="mailto:Openembedded-core@lists.openembedded.org" target="_blank">Openembedded-core@lists.openembedded.org</a><br>
>  Â  Â <mailto:<a href="mailto:Openembedded-core@lists.openembedded.org" target="_blank">Openembedded-core@lists.openembedded.org</a>><br>
>  Â  Â <a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer" target="_blank">http://lists.openembedded.org/mailman/listinfo/openembedded-core</a><br>
>  Â  Â <<a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.openembedded.org_mailman_listinfo_openembedded-2Dcore&d=DwMFaQ&c=I_0YwoKy7z5LMTVdyO6YCiE2uzI1jjZZuIPelcSjixA&r=wNcrL2akRn6jfxhHaKavUrJB_C9JAMXtynjLd8ZzgXQ&m=8hd_9vew95YIf_VIv2QHNu2EFnc3G2WZ5KA2Upnv5j8&s=UHPegBWeyh1LTyIdp2oai1-Ecy-s_l8In1Kk14OFS6Q&e=" rel="noreferrer" target="_blank">https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.openembedded.org_mailman_listinfo_openembedded-2Dcore&d=DwMFaQ&c=I_0YwoKy7z5LMTVdyO6YCiE2uzI1jjZZuIPelcSjixA&r=wNcrL2akRn6jfxhHaKavUrJB_C9JAMXtynjLd8ZzgXQ&m=8hd_9vew95YIf_VIv2QHNu2EFnc3G2WZ5KA2Upnv5j8&s=UHPegBWeyh1LTyIdp2oai1-Ecy-s_l8In1Kk14OFS6Q&e=</a>><br>
> <br>
<br>
-- <br>
Cheers,<br>
<br>
Alejandro<br>
</blockquote></div></div>