<div dir="ltr"><div class="gmail_default" style="font-family:tahoma,sans-serif">Hi Ravi,<br><br>I did not understand at first your comment about <br><span style="font-size:11pt;font-family:"Calibri","sans-serif";color:rgb(31,73,125)">> if the <span class="">cookie</span>
 is not set (user visits the page for the first time and does not change
 the columns visibility) then all the columns are being displayed.</span><br><br></div><div class="gmail_default" style="font-family:tahoma,sans-serif">I think you need to add <br><br>'hidden' : 1 <br><br></div><div class="gmail_default" style="font-family:tahoma,sans-serif">

in the tablecols[] entry for the column you want to hide by default.<br><br>Cheers,<br>Alex<br></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Jan 22, 2014 at 2:57 AM, Ravi Chintakunta <span dir="ltr"><<a href="mailto:ravi.chintakunta@timesys.com" target="_blank">ravi.chintakunta@timesys.com</a>></span> wrote:<br>

<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div link="blue" vlink="purple" lang="EN-US"><div><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Hi Alex,<u></u><u></u></span></p>

<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">I have fixed the builds view so that the filters Â work Â well and pushed it to ravi/all-tasks-feature branch.<u></u><u></u></span></p>

<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><a href="http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/bitbake/lib/toaster?h=ravi/all-tasks-feature&id=dfde36b1f9131af4a20d683196eb619e2813d0c8" target="_blank">http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/bitbake/lib/toaster?h=ravi/all-tasks-feature&id=dfde36b1f9131af4a20d683196eb619e2813d0c8</a><u></u><u></u></span></p>

<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Thanks,<u></u><u></u></span></p>

<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Ravi<u></u><u></u></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>

<div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt"><div><div style="border:none;border-top:solid #b5c4df 1.0pt;padding:3.0pt 0in 0in 0in"><p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> Damian, Alexandru [mailto:<a href="mailto:alexandru.damian@intel.com" target="_blank">alexandru.damian@intel.com</a>] <br>

<b>Sent:</b> Tuesday, January 21, 2014 9:49 AM</span></p><div><div class="h5"><br><b>To:</b> Ravi Chintakunta<br><b>Cc:</b> Paul Eggleton; Barros Pena, Belen; Reyna, David L (Wind River); Lerner, David M (Wind River); Zhang, Jessica; <a href="mailto:toaster@yoctoproject.org" target="_blank">toaster@yoctoproject.org</a><br>

<b>Subject:</b> Re: git push for base html, base table, custom tags, fitler dialog and All Tasks feature to ravi/all-tasks-feature<u></u><u></u></div></div><p></p></div></div><div><div class="h5"><p class="MsoNormal"><u></u> <u></u></p>

<div><div><p class="MsoNormal" style="margin-bottom:12.0pt"><span style="font-family:"Tahoma","sans-serif"">Hi Ravi,<u></u><u></u></span></p></div><div><p class="MsoNormal" style="margin-bottom:12.0pt">

<span style="font-family:"Tahoma","sans-serif"">You're right, I added the cookie functionality. I think this is how it should work :).<u></u><u></u></span></p></div><div><p class="MsoNormal" style="margin-bottom:12.0pt">

<span style="font-family:"Tahoma","sans-serif"">About the patches, the commits look right; yet the last patch breaks the filters on the "Build Dashboard" page. We can't take patches that break other things, so can you please update the settings for "Build" page as well to work with the new filter code ?<u></u><u></u></span></p>

</div><div><p class="MsoNormal"><span style="font-family:"Tahoma","sans-serif"">Cheers,<br>Alex<u></u><u></u></span></p></div></div><div><p class="MsoNormal" style="margin-bottom:12.0pt"><u></u> <u></u></p>

<div><p class="MsoNormal">On Mon, Jan 20, 2014 at 7:50 PM, Ravi Chintakunta <<a href="mailto:ravi.chintakunta@timesys.com" target="_blank">ravi.chintakunta@timesys.com</a>> wrote:<u></u><u></u></p><div><div><p class="MsoNormal">

<span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Hi Alex,</span><u></u><u></u></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"> </span><u></u><u></u></p>

<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">I rebased my code on top of master, resolved conflicts, fixed the code to reflect master code changes, changed the order of the commits of views and filter dialog and pushed it to my branch ravi/all-tasks-feature.</span><u></u><u></u></p>

<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"> </span><u></u><u></u></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Please review and let me know.</span><u></u><u></u></p>

<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"> </span><u></u><u></u></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">I noted that you changed the show/hide of table columns to use cookie. I just wanted to let you know that this is working when the cookie is set (that is the user has changed the columns visibility), but if the cookie is not set (user visits the page for the first time and does not change the columns visibility) then all the columns are being displayed.</span><u></u><u></u></p>

<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"> </span><u></u><u></u></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Thanks for your help,</span><u></u><u></u></p>

<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Ravi</span><u></u><u></u></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"> </span><u></u><u></u></p>

<div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt"><div><div style="border:none;border-top:solid #b5c4df 1.0pt;padding:3.0pt 0in 0in 0in"><p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> Damian, Alexandru [mailto:<a href="mailto:alexandru.damian@intel.com" target="_blank">alexandru.damian@intel.com</a>] <br>

<b>Sent:</b> Monday, January 20, 2014 10:11 AM</span><u></u><u></u></p><div><div><p class="MsoNormal"><br><b>To:</b> Ravi Chintakunta<br><b>Cc:</b> Paul Eggleton; Barros Pena, Belen; Reyna, David L (Wind River); Lerner, David M (Wind River); Zhang, Jessica; <a href="mailto:toaster@yoctoproject.org" target="_blank">toaster@yoctoproject.org</a><br>

<b>Subject:</b> Re: git push for base html, base table, custom tags, fitler dialog and All Tasks feature to ravi/all-tasks-feature<u></u><u></u></p></div></div></div></div><div><div><p class="MsoNormal"> <u></u><u></u></p>

<div><div><p class="MsoNormal" style="margin-bottom:12.0pt"><span style="font-family:"Tahoma","sans-serif"">Hi,</span><u></u><u></u></p></div><div><p class="MsoNormal" style="margin-bottom:12.0pt"><span style="font-family:"Tahoma","sans-serif"">1. I applied the patches in order, and after each patch tested to see if things still work. I expect on each patch in a patchset to leave things in an workable state, no unresolved dependencies in a future patch. So if I need to apply a views.py patch, that should come either before this patch, or, if there is a circular dependency (i.e. views and templates change together), the changes must be part of the same patch.</span><u></u><u></u></p>

</div><div><p class="MsoNormal"><span style="font-family:"Tahoma","sans-serif"">2. yes, you need to rebase on top of toaster/master; the way that I do it:</span><u></u><u></u></p></div><div><p class="MsoNormal">

<span style="font-family:"Tahoma","sans-serif"">- I have a local toaster/master which follows upstream poky-contrib/toaster/master</span><u></u><u></u></p></div><div><p class="MsoNormal" style="margin-bottom:12.0pt">

<span style="font-family:"Tahoma","sans-serif"">- I have my development branch based on the local toaster/master</span><u></u><u></u></p></div><div><p class="MsoNormal" style="margin-bottom:12.0pt"><span style="font-family:"Tahoma","sans-serif"">When I need to rebase, <br>

  - I do git pull on the local toaster/master branch, and then <br>  - move to the development branch and do git rebase -i toaster/master</span><u></u><u></u></p></div><div><p class="MsoNormal"><span style="font-family:"Tahoma","sans-serif"">Hope this helps,<br>

Alex</span><u></u><u></u></p></div><div><p class="MsoNormal"><span style="font-family:"Tahoma","sans-serif""> </span><u></u><u></u></p></div></div><div><p class="MsoNormal" style="margin-bottom:12.0pt">

 <u></u><u></u></p><div><p class="MsoNormal">On Mon, Jan 20, 2014 at 2:54 PM, Ravi Chintakunta <<a href="mailto:ravi.chintakunta@timesys.com" target="_blank">ravi.chintakunta@timesys.com</a>> wrote:<u></u><u></u></p>

<div><div><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Hi Alex,</span><u></u><u></u></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"> </span><u></u><u></u></p>

<p><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">1.</span><span style="font-size:7.0pt;color:#1f497d">      </span><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">The filter dialog has been changed to use options name and value as tuples and that may be the reason you are seeing only the first letters. Did you change the code in views.py to set the filter options as tuples?</span><u></u><u></u></p>

<p><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">2.</span><span style="font-size:7.0pt;color:#1f497d">      </span><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">To check that the All tasks feature patch applies, should I fetch from toaster/master and then rebase?</span><u></u><u></u></p>

<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"> </span><u></u><u></u></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Thanks,</span><u></u><u></u></p>

<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Ravi</span><u></u><u></u></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"> </span><u></u><u></u></p>

<div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt"><div><div style="border:none;border-top:solid #b5c4df 1.0pt;padding:3.0pt 0in 0in 0in"><p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> Damian, Alexandru [mailto:<a href="mailto:alexandru.damian@intel.com" target="_blank">alexandru.damian@intel.com</a>] <br>

<b>Sent:</b> Monday, January 20, 2014 7:16 AM<br><b>To:</b> Ravi Chintakunta<br><b>Cc:</b> Paul Eggleton; Barros Pena, Belen; Reyna, David L (Wind River); Lerner, David M (Wind River); Zhang, Jessica; <a href="mailto:toaster@yoctoproject.org" target="_blank">toaster@yoctoproject.org</a><br>

<b>Subject:</b> Re: git push for base html, base table, custom tags, fitler dialog and All Tasks feature to ravi/all-tasks-feature</span><u></u><u></u></p></div></div><div><div><p class="MsoNormal"> <u></u><u></u></p><div>

<div><p class="MsoNormal" style="margin-bottom:12.0pt"><span style="font-family:"Tahoma","sans-serif"">Hello,</span><u></u><u></u></p></div><div><p class="MsoNormal"><span style="font-family:"Tahoma","sans-serif"">I have taken in some of the patches in this branch, with changes:</span><u></u><u></u></p>

</div><div><p class="MsoNormal"><span style="font-family:"Tahoma","sans-serif"">- "viewName" was also implemented, of sorts, as "objectname". I have replaced "{{viewName}}" with "{{objectname|title}}" as to capitalize the name</span><u></u><u></u></p>

</div><div><p class="MsoNormal" style="margin-bottom:12.0pt"><span style="font-family:"Tahoma","sans-serif"">- whitespace fixes; please don't do whitespace at the end of a line.</span><u></u><u></u></p>

</div><div><p class="MsoNormal"><span style="font-family:"Tahoma","sans-serif""><br><br>What I didn't take:<br><br>* bitbake: toaster: Filter Dialog fix to display filter options as radio buttons</span><u></u><u></u></p>

</div><div><p class="MsoNormal"><span style="font-family:"Tahoma","sans-serif"">-   The option names are only showing the first letter.<br><br>* bitbake: toaster: All Tasks Feature with sorting and filtering</span><u></u><u></u></p>

</div><div><p class="MsoNormal"><span style="font-family:"Tahoma","sans-serif"">-   Does not apply cleanly on the latest version. Please rebase</span><u></u><u></u></p></div><div><p class="MsoNormal" style="margin-bottom:12.0pt">

<span style="font-family:"Tahoma","sans-serif"">-   Whitespace at the end of lines.</span><u></u><u></u></p></div><div><p class="MsoNormal"><span style="font-family:"Tahoma","sans-serif"">Thank you,<br>

Alex</span><u></u><u></u></p></div><div><p class="MsoNormal"><span style="font-family:"Tahoma","sans-serif""> </span><u></u><u></u></p></div><div><p class="MsoNormal"><span style="font-family:"Tahoma","sans-serif""> </span><u></u><u></u></p>

</div></div><div><p class="MsoNormal" style="margin-bottom:12.0pt"> <u></u><u></u></p><div><p class="MsoNormal">On Sat, Jan 18, 2014 at 4:20 PM, Ravi Chintakunta <<a href="mailto:ravi.chintakunta@timesys.com" target="_blank">ravi.chintakunta@timesys.com</a>> wrote:<u></u><u></u></p>

<p class="MsoNormal" style="margin-bottom:12.0pt">I have completed<br><br>the All Tasks feature<br><br><a href="https://bugzilla.yoctoproject.org/show_bug.cgi?id=4275" target="_blank">https://bugzilla.yoctoproject.org/show_bug.cgi?id=4275</a><br>

<br>and<br><br>filtering tasks in a table<br><br><a href="https://bugzilla.yoctoproject.org/show_bug.cgi?id=4278" target="_blank">https://bugzilla.yoctoproject.org/show_bug.cgi?id=4278</a><br><br>and pushed it to ravi/all-tasks-feature branch:<br>

<br><a href="http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=ravi/all-tasks-feature&id=f75622b67a86ff9b14c6ef4b902c324be573e9a1" target="_blank">http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=ravi/all-tasks-feature&id=f75622b67a86ff9b14c6ef4b902c324be573e9a1</a><br>

<br><br><br>The push also includes fixes to:<br><br>1. Base html - to set the title of the page<br><br><a href="http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=ravi/all-tasks-feature&id=46353d4bfdd8176244599b80b81ed27bf720ddac" target="_blank">http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=ravi/all-tasks-feature&id=46353d4bfdd8176244599b80b81ed27bf720ddac</a><br>

<br>2. Base table - Fix the header text style, sort icon, filter icon<br><br><a href="http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=ravi/all-tasks-feature&id=426874b4139618dd25a774a7c113097f75938be9" target="_blank">http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=ravi/all-tasks-feature&id=426874b4139618dd25a774a7c113097f75938be9</a><br>

<br>3. Custom Tags - Added custom tags for setting color based on task outcome, filter icon, filter icon tooltip, display zero and other values as blank.<br><br><a href="http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=ravi/all-tasks-feature&id=ac2f8b18d2a728efb0b5bccce6be7f9e5acb467b" target="_blank">http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=ravi/all-tasks-feature&id=ac2f8b18d2a728efb0b5bccce6be7f9e5acb467b</a><br>

<br>4. Filter Dialog - Modified it to display the filter options as radio buttons, and changed the filter options data structure from dictionary to list so that the order of the filter options is preserved.<br><br><a href="http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=ravi/all-tasks-feature&id=2a8742d6e7ce75cd9b6f854874b2ac15a58a45ab" target="_blank">http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=ravi/all-tasks-feature&id=2a8742d6e7ce75cd9b6f854874b2ac15a58a45ab</a><br>

<br>Few of these were pushed previously, but now I have cleaned up the commit message and grouped multiple commits based on the functionality.<br><br>Please review and let me know what you think.<br><br>Thanks,<br>Ravi<u></u><u></u></p>

</div><p class="MsoNormal"><br><br clear="all"><br>-- <u></u><u></u></p><div><p class="MsoNormal">Alex Damian<u></u><u></u></p><div><p class="MsoNormal">Yocto Project<u></u><u></u></p></div><div><p class="MsoNormal">SSG / OTC <u></u><u></u></p>

</div></div></div></div></div></div></div></div></div><p class="MsoNormal"><br><br clear="all"><br>-- <u></u><u></u></p><div><p class="MsoNormal">Alex Damian<u></u><u></u></p><div><p class="MsoNormal">Yocto Project<u></u><u></u></p>

</div><div><p class="MsoNormal">SSG / OTC <u></u><u></u></p></div></div></div></div></div></div></div></div></div><p class="MsoNormal"><br><br clear="all"><br>-- <u></u><u></u></p><div><p class="MsoNormal">Alex Damian<u></u><u></u></p>

<div><p class="MsoNormal">Yocto Project<u></u><u></u></p></div><div><p class="MsoNormal">SSG / OTC <u></u><u></u></p></div></div></div></div></div></div></div></div></blockquote></div><br><br clear="all"><br>-- <br><div dir="ltr">

Alex Damian<div>Yocto Project<br></div><div>SSG / OTC </div></div>
</div>