<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Menlo-Regular;
panose-1:0 0 0 0 0 0 0 0 0 0;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman",serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.apple-converted-space
{mso-style-name:apple-converted-space;}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Hi Jean,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Agreed on your approach, will apply for the branches mentioned<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Thanks,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Manju<o:p></o:p></span></p>
<p class="MsoNormal"><a name="_MailEndCompose"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></a></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt">
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">From:</span></b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> Jean-Francois Dagenais [mailto:jeff.dagenais@gmail.com]
<br>
<b>Sent:</b> Thursday, May 17, 2018 6:34 AM<br>
<b>To:</b> Manjukumar Harthikote Matha <MANJUKUM@xilinx.com><br>
<b>Cc:</b> meta-xilinx@yoctoproject.org; nathan@nathanrossi.com<br>
<b>Subject:</b> Re: [PATCH] bootbin: fix race condition in create_bif<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Hi Manju!<o:p></o:p></p>
<div>
<div>
<p class="MsoNormal"><br>
<br>
<o:p></o:p></p>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<div>
<p class="MsoNormal">On May 16, 2018, at 12:36 PM, Manjukumar Harthikote Matha <<a href="mailto:MANJUKUM@xilinx.com">MANJUKUM@xilinx.com</a>> wrote:<o:p></o:p></p>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal"><span style="font-size:8.5pt;font-family:"Menlo-Regular",serif">Will change python code to add <br>
bootbindeps = bootbindeps + " " + attrdepends[cfg] + ":do_deploy"<span class="apple-converted-space"> </span><br>
instead of do_deploy in BIF_PARTITION_DEPENDS and apply it.</span><o:p></o:p></p>
</div>
</blockquote>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<div>
<p class="MsoNormal">See the last part of my commit message. The reason I chose to do it like this is<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">explained. Essentially, when xilinx-bootbin.bb adds the "do_deploy" it assumes<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">that the source of BIF_ATTRIBUTE_xyz used a "DEPLOY_DIR" file. This creates an<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">unhealthy assumption, tightly couples xilinx-bootbin.bb and the BIF_ATTRIBUTE<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">assignments and makes the recipe more fragile.<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">If I were to use a file found in say ${STAGING_DIR_HOST}, then xilinx-bootbin.bb<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">would incorrectly add ":do_deploy" when in fact, ":do_populate_sysroot" should be<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">appended.<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">Putting the ":do_deploy" in xilinx-bootbin.bb sure means less characters overall, but<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">that doesn't mean it's objectively "better". ;)<o:p></o:p></p>
</div>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">I recommend leaving my patch as-is, i.e. as I it was "signed-off".<o:p></o:p></p>
</div>
</div>
</div>
</body>
</html>