<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p>Please ignore this mail, this mail is same as next one, just
send two times by mistake.<br>
</p>
<br>
<div class="moz-cite-prefix">On 10/09/2018 11:13 AM, Changqing Li
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:caff70ef-6fa8-1b0e-2a20-b6639a349923@windriver.com">
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<p><br>
</p>
<br>
<div class="moz-cite-prefix">On 10/01/2018 09:22 AM, Bruce
Ashfield wrote:<br>
</div>
<blockquote type="cite"
cite="mid:CADkTA4PWSA+Pf79s0CzxNaWpLo04CFkGBZEoPuqKFD3RSwxARQ@mail.gmail.com">
<pre wrap="">On Sat, Sep 29, 2018 at 11:18 PM <a class="moz-txt-link-rfc2396E" href="mailto:changqing.li@windriver.com" moz-do-not-send="true"><changqing.li@windriver.com></a> wrote:
</pre>
<blockquote type="cite">
<pre wrap="">From: Changqing Li <a class="moz-txt-link-rfc2396E" href="mailto:changqing.li@windriver.com" moz-do-not-send="true"><changqing.li@windriver.com></a>
fix below warning:
do_package_qa: QA Issue: ELF binary 'xxx/usr/sbin/registry'
has relocations in .text [textrel]
Add GOBUILDFLAGS which have -buildmode=pie to fix it
</pre>
</blockquote>
<pre wrap="">This is not universally true, so your configuration needs more
explanation. We haven't needed these flags before, and I've never seen
the warnings.
I just build docker and dumped the environment, my GOBUILDFLAGS do not
have buildmode=pie
So clearly, your config is different.
I'm not against adding the extra variable, but we are taking a the
risk of injecting build configurations that we haven't needed before,
and may not want.
So I need to understand what configuration you are building that is
making them required, and then figure out what else is being injected
that wasn't being injected before.
Same comment applies for all the QA fixes.
Bruce</pre>
</blockquote>
<br>
Hi, Bruce<br>
<br>
I do some research, package QA check is enabled by default in
insane.bbclass. <br>
variable WARN_QA contains the checked items. and textrel is
checked by default.<br>
<span style="color: rgb(51, 51, 51); font-family: Verdana, Sans,
sans-serif; font-size: medium; font-style: normal;
font-variant-ligatures: normal; font-variant-caps: normal;
font-weight: 400; letter-spacing: normal; orphans: 2;
text-align: start; text-indent: 0px; text-transform: none;
white-space: normal; widows: 2; word-spacing: 0px;
-webkit-text-stroke-width: 0px; background-color: rgb(255, 255,
255); text-decoration-style: initial; text-decoration-color:
initial; display: inline !important; float: none;"><span></span></span><br>
But, this warning is arch related(Besides arch, no other
special config).<br>
Here is my test result of which archs the warnings can see.<br>
<br>
docker                                     arm64 arm x86Â
x86-64<br>
docker-distribution                  arm64          <br>
containerd-opencontainers    arm64 arm x86 x86-64<br>
oci-image-tools                       arm64<br>
oci-runtime-tools                    arm64<br>
runc-docker                            arm64 arm x86 x86-64<br>
<br>
<br>
About GOBUILDFLAGS, buildmode=pie is added to oe-core recently,
so maybe you need<br>
to check lastest code, here is the patch.<br>
<img src="cid:part3.9CD4704C.28855D48@windriver.com" alt=""
class=""><br>
<br>
<br>
Do you think we need add the fix patch only for special arch? like<br>
SRC_URI_append_aarch64=<a class="moz-txt-link-rfc2396E"
href="file://0001-fix-do_package_qa-error.patch"
moz-do-not-send="true">"file://0001-fix-do_package_qa-error.patch"</a><br>
<br>
<blockquote type="cite"
cite="mid:CADkTA4PWSA+Pf79s0CzxNaWpLo04CFkGBZEoPuqKFD3RSwxARQ@mail.gmail.com">
<pre wrap="">
</pre>
<blockquote type="cite">
<pre wrap="">Signed-off-by: Changqing Li <a class="moz-txt-link-rfc2396E" href="mailto:changqing.li@windriver.com" moz-do-not-send="true"><changqing.li@windriver.com></a>
---
.../docker-distribution/docker-distribution_git.bb | 1 +
.../files/0001-fix-do_package_qa-error.patch | 32 ++++++++++++++++++++++
2 files changed, 33 insertions(+)
create mode 100644 recipes-containers/docker-distribution/files/0001-fix-do_package_qa-error.patch
diff --git a/recipes-containers/docker-distribution/docker-distribution_git.bb b/recipes-containers/docker-distribution/docker-distribution_git.bb
index add5ce1..7c7bce2 100644
--- a/recipes-containers/docker-distribution/docker-distribution_git.bb
+++ b/recipes-containers/docker-distribution/docker-distribution_git.bb
@@ -6,6 +6,7 @@ LIC_FILES_CHKSUM = <a class="moz-txt-link-rfc2396E" href="file://LICENSE;md5=d2794c0df5b907fdace235a619d80314" moz-do-not-send="true">"file://LICENSE;md5=d2794c0df5b907fdace235a619d80314"</a>
SRCREV_distribution="48294d928ced5dd9b378f7fd7c6f5da3ff3f2c89"
SRC_URI = "git://github.com/docker/distribution.git;branch=release/2.6;name=distribution;destsuffix=git/src/github.com/docker/distribution \
<a class="moz-txt-link-freetext" href="file://docker-registry.service" moz-do-not-send="true">file://docker-registry.service</a> \
+ <a class="moz-txt-link-freetext" href="file://0001-fix-do_package_qa-error.patch" moz-do-not-send="true">file://0001-fix-do_package_qa-error.patch</a> \
"
PACKAGES =+ "docker-registry"
diff --git a/recipes-containers/docker-distribution/files/0001-fix-do_package_qa-error.patch b/recipes-containers/docker-distribution/files/0001-fix-do_package_qa-error.patch
new file mode 100644
index 0000000..269b0cd
--- /dev/null
+++ b/recipes-containers/docker-distribution/files/0001-fix-do_package_qa-error.patch
@@ -0,0 +1,32 @@
+From 4b9d701fabff8e7969db081406d00fa9fe46b3fd Mon Sep 17 00:00:00 2001
+From: Changqing Li <a class="moz-txt-link-rfc2396E" href="mailto:changqing.li@windriver.com" moz-do-not-send="true"><changqing.li@windriver.com></a>
+Date: Thu, 27 Sep 2018 11:05:51 +0800
+Subject: [PATCH] fix do_package_qa error
+
+fix below error:
+do_package_qa: QA Issue: ELF binary 'xxx/usr/sbin/registry'
+has relocations in .text [textrel]
+
+Upstream-Status: Inappropriate [oe-specific]
+
+Signed-off-by: Changqing Li <a class="moz-txt-link-rfc2396E" href="mailto:changqing.li@windriver.com" moz-do-not-send="true"><changqing.li@windriver.com></a>
+---
+ Makefile | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/Makefile b/Makefile
+index 47b8f1d..13b0f92 100644
+--- a/Makefile
++++ b/Makefile
+@@ -39,7 +39,7 @@ GODEP=$(shell which godep || echo '')
+
+ ${PREFIX}/bin/registry: $(GOFILES)
+ @echo "+ $@"
+- @go build -tags "${DOCKER_BUILDTAGS}" -o $@ ${GO_LDFLAGS} ${GO_GCFLAGS} ./cmd/registry
++ @go build -tags "${DOCKER_BUILDTAGS}" -o $@ ${GO_LDFLAGS} ${GOBUILDFLAGS} ${GO_GCFLAGS} ./cmd/registry
+
+ ${PREFIX}/bin/digest: $(GOFILES)
+ @echo "+ $@"
+--
+2.7.4
+
--
2.7.4
--
_______________________________________________
meta-virtualization mailing list
<a class="moz-txt-link-abbreviated" href="mailto:meta-virtualization@yoctoproject.org" moz-do-not-send="true">meta-virtualization@yoctoproject.org</a>
<a class="moz-txt-link-freetext" href="https://lists.yoctoproject.org/listinfo/meta-virtualization" moz-do-not-send="true">https://lists.yoctoproject.org/listinfo/meta-virtualization</a>
</pre>
</blockquote>
<pre wrap="">
</pre>
</blockquote>
<br>
<pre class="moz-signature" cols="72">--
BRs
Sandy(Li Changqing)
Wind River Linux</pre>
<!--'"--><br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
</blockquote>
<br>
<pre class="moz-signature" cols="72">--
BRs
Sandy(Li Changqing)
Wind River Linux</pre>
</body>
</html>